Bug 36517: Fix output from install_plugins.pl
authorMagnus Enger <magnus@libriotech.no>
Fri, 5 Apr 2024 13:41:08 +0000 (13:41 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 28 May 2024 17:55:06 +0000 (17:55 +0000)
commit2644f581fd1f82a029a465a33f941141c6947a45
tree83155b560b68ea98e6d7b96e1652b672698c3bc9
parentde189183397479a0ef4866156f72117cc9f8573e
Bug 36517: Fix output from install_plugins.pl

When misc/devel/install_plugins.pl does not find any plugins, it prints
the list of pluginsdir, but with a literal \n separating the dirs, and
no newline at the end.

To test:
- Edit koha-conf.xml and add a second entry for <pluginsdir>, so there
  are two entries. The second one could just be a copy of the original.
- Run "perl misc/devel/install_plugins.pl"
- Note the output looks something like this:

No plugins found
pluginsdir contains:
/var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$

- Apply the patch and run the script again. Output should be:

No plugins found
pluginsdir contains:
/var/lib/koha/kohadev/plugins
/var/lib/koha/kohadev/plugins
root@kohadevbox:koha(master)$

- Sign off

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 4848def5e2a336e01bf0dd0ff61a75a30b35f137)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f2a05fadd06f40ad385ed8f7792ac7b68c16e7d7)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
misc/devel/install_plugins.pl