Bug 35394: Correction to booked items logic
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 8 Mar 2024 15:25:10 +0000 (15:25 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 23 May 2024 13:41:03 +0000 (15:41 +0200)
commit40bd96aa82f5513fb8a72b7198498a8b560067e3
treeae96b2f2391acc82bd099011a0015dbfa1a50339
parent89ce196ea77e0e46d6d66b1710325673b753bbd3
Bug 35394: Correction to booked items logic

This patch fixes the overly extreme message that was designed to appeared
when someone tried to check out a booked item to the wrong user.
However, the message never appeared due to a logic error within
CanBookBeIssued which this patch also resolved.

Test plan
1) Make an item bookable
2) Add a booking for the item to patron A from tomorrow
3) In the database, update the booking start_date to today (or wait a
   day before the next step)
4) Attempt to check the book out to patron B.
   Note that you are displayed with the new message 'The item is booked
   for another patron' and you are unable to check the item out.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 1ebd742e08494c111a8998bee730ed8bd4bcee37)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Circulation.pm
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt