]> git.koha-community.org Git - koha.git/commit
Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we...
authorSlava Shishkin <slavashishkin@gmail.com>
Fri, 6 Oct 2023 16:25:30 +0000 (19:25 +0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 10 Nov 2023 02:20:46 +0000 (16:20 -1000)
commit99f69e987faae7c91ffc46c4abfc65d09519a5cf
tree744d524d9733238b759d98f73432aee1587a4469
parent3621e32bd13a467734894486db73e84a21d7baf6
Bug 35004: Set row.quantity_received to 1 if row.quantity_received is empty and we're in 'cataloguing' mode

Before the code changes only field value was set to 1,
but "row.quantity_received" still had an undefined value.
After correction row.quantity_received set to 1 if it is empty,
but only when effective_create_items == 'cataloguing',
and after that its value assigned to the form field.

To test:
1. Add a new basket.
2. Create an order line
3. Receive shipment and create an invoice
4. Start receiving your order:
    Verify:
    - Quantity ordered: X
    - Quantity received: 1 (pre-filled, don't touch or change it)
5. Click "Confirm"
6. Observe the Receive error popup: "Order ZZZ: No quantity to receive
   set. No items will be created."
7. Verify that "Order receive" was not happen (received orders remains
   empty)
8. Apply the patch and make sure your order is received correctly after
   step 5.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9110547de098264e2574e27f35859674f1ed18a2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt