]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoBug5640: BZ5640 (MT3584): Nimes icon set
Paul Poulain [Tue, 18 Jan 2011 15:56:59 +0000 (10:56 -0500)]
Bug5640: BZ5640 (MT3584): Nimes icon set

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327: Shifting and little tidy up of the members tests
Chris Cormack [Wed, 19 Jan 2011 22:52:19 +0000 (11:52 +1300)]
Bug 5327: Shifting and little tidy up of the members tests

13 years agoBug 5327 Some tests added
johnboy [Wed, 19 Jan 2011 21:32:58 +0000 (10:32 +1300)]
Bug 5327 Some tests added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4289: Updating other sysprefs until we change the installer, we need to do this
Chris Cormack [Wed, 19 Jan 2011 07:55:33 +0000 (20:55 +1300)]
Bug 4289: Updating other sysprefs until we change the installer, we need to do this

13 years agoBug 4289: Bumping version number up
Chris Cormack [Wed, 19 Jan 2011 01:31:58 +0000 (14:31 +1300)]
Bug 4289: Bumping version number up

13 years agoBug 4289 Followup: Add syspref default value and in opac.pref
Frédéric Demians [Tue, 7 Dec 2010 16:33:13 +0000 (17:33 +0100)]
Bug 4289 Followup: Add syspref default value and in opac.pref

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4289: 'OpacPublic' feature
Mason James [Tue, 7 Dec 2010 16:33:12 +0000 (17:33 +0100)]
Bug 4289: 'OpacPublic' feature

applied to git tag 'v3.02.00-rc'

Frédéric Demians:

  - Rebased this patch to HEAD
  - Solved a merge conflict
  - The patch works as described here:
    http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4289

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
Chris Cormack [Wed, 19 Jan 2011 00:38:52 +0000 (13:38 +1300)]
Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent

13 years agoAdded unit tests to test all of get_amazon_tld in Amazon.pm.
Zach Sim [Tue, 18 Jan 2011 23:07:25 +0000 (12:07 +1300)]
Added unit tests to test all of get_amazon_tld in Amazon.pm.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 22:26:18 +0000 (11:26 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327: Little change to Record.t
Chris Cormack [Tue, 18 Jan 2011 22:09:28 +0000 (11:09 +1300)]
Bug 5327: Little change to Record.t

13 years agoBug 5327 1 more test added.
johnboy [Tue, 18 Jan 2011 21:44:11 +0000 (10:44 +1300)]
Bug 5327 1 more test added.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdded unit tests for Biblio and moved it to db_dependent as it requires the database.
Zach Sim [Tue, 18 Jan 2011 21:52:23 +0000 (10:52 +1300)]
Added unit tests for Biblio and moved it to db_dependent as it requires the database.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 09:54:06 +0000 (22:54 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 Cleaning up XISBN.t a bit
Chris Cormack [Tue, 18 Jan 2011 09:52:02 +0000 (22:52 +1300)]
Bug 5327 Cleaning up XISBN.t a bit

13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 06:55:12 +0000 (19:55 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 - Fixing a path issue with XISBN.t
Chris Cormack [Tue, 18 Jan 2011 06:53:58 +0000 (19:53 +1300)]
Bug 5327 - Fixing a path issue with XISBN.t

13 years agoBug 5327 litte fix for Background tests
Chris Cormack [Tue, 18 Jan 2011 03:35:08 +0000 (16:35 +1300)]
Bug 5327 litte fix for Background tests

13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 03:25:58 +0000 (16:25 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 shifting database dependent modules and scripts to t/db_dependent
Chris Cormack [Tue, 18 Jan 2011 03:18:37 +0000 (16:18 +1300)]
Bug 5327 shifting database dependent modules and scripts to t/db_dependent

13 years agobug 5327 updated test file
johnboy [Tue, 18 Jan 2011 02:56:38 +0000 (15:56 +1300)]
bug 5327 updated test file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdded unit tests using a test database for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:54:49 +0000 (15:54 +1300)]
Added unit tests using a test database for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoCreated unit testing using the testdatabase for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:25:22 +0000 (15:25 +1300)]
Created unit testing using the testdatabase for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 23:01:04 +0000 (12:01 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoAdded extra unit tests to Debug.t
Zach Sim [Mon, 17 Jan 2011 22:14:21 +0000 (11:14 +1300)]
Added extra unit tests to Debug.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5327 started testing
johnboy [Mon, 17 Jan 2011 22:34:39 +0000 (11:34 +1300)]
bug 5327 started testing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 Starting tests for BackgroundJob
johnboy [Mon, 17 Jan 2011 22:06:05 +0000 (11:06 +1300)]
Bug 5327 Starting tests for BackgroundJob

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 22:35:15 +0000 (11:35 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 Starting Unit Tests for Auth.pm
spartaness [Mon, 17 Jan 2011 21:57:31 +0000 (10:57 +1300)]
Bug 5327 Starting Unit Tests for Auth.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 20:41:53 +0000 (09:41 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 removing uneeded tests
claudia [Mon, 17 Jan 2011 19:56:33 +0000 (08:56 +1300)]
Bug 5327 removing uneeded tests

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5399: Follow up style patch, moving exits out of subroutine
Chris Cormack [Mon, 17 Jan 2011 09:53:28 +0000 (22:53 +1300)]
Bug 5399: Follow up style patch, moving exits out of subroutine

13 years agoBug 5399: remove useless eval 'use C4::Foo'
Galen Charlton [Mon, 17 Jan 2011 09:45:41 +0000 (09:45 +0000)]
Bug 5399: remove useless eval 'use C4::Foo'

Also add a couple FIXMEs

Marcel: Signed and updated for current master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5026 Undefined dates formatted poorly in serials-edit
Colin Campbell [Mon, 17 Jan 2011 08:17:40 +0000 (08:17 +0000)]
Bug 5026 Undefined dates formatted poorly in serials-edit

Don't display junk in empty fields
Don't generate errors

Merged some changes to make variable names moremeaningful in loops ( within loops)

Thanks to M De Rooy for spotting a couple of issues in the original patch

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdding a new developer to the history
Chris Cormack [Mon, 17 Jan 2011 07:59:11 +0000 (20:59 +1300)]
Adding a new developer to the history

13 years agoBug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Dobrica Pavlinusic [Mon, 20 Dec 2010 12:08:23 +0000 (12:08 +0000)]
Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload

Currently, modifying existing orders will recalculate values if exchange rate
has changed, which destroys previous data (our use case is just to modify
Planning value fields).

Since fields also have onChange event which also triggers caclNeworderTotal,
onload event seems redundant.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn
Colin Campbell [Tue, 14 Dec 2010 09:28:53 +0000 (09:28 +0000)]
Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn

These two subroutines were no longer being used by any other code
removed them from their respective modules
If we need any ISBN in future we should use Business::ISBN directly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 - Adding UNIT Tests.
Zach Sim [Mon, 17 Jan 2011 03:14:22 +0000 (16:14 +1300)]
Bug 5327 - Adding UNIT Tests.

Squashed commit of the following:

commit 146d14665c52edaa85e38b70aabc9d52be5d64b6
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:07:24 2011 +1300

    Edited DisplayISBN to cleanup the ISBN using _isbn_cleanup if it is not 13 or 10 digits long.

commit ba97b26d9a25470b0717cdd60a3d4f7a5c459ca9
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:06:14 2011 +1300

    Added extra unit tests to test C4::Koha::DisplayISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3459, topissues doesn't take care of ccode
Owen Leonard [Thu, 13 Jan 2011 21:53:51 +0000 (22:53 +0100)]
Fix for Bug 3459, topissues doesn't take care of ccode

- Change conditional to display filter in sidebar without EXPR
- Enhance switch between ccode default and itemtype default searches
- Enable preselect of submitted collection code in filter form,
  stealing code from opac-search.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view
Owen Leonard [Thu, 13 Jan 2011 21:31:09 +0000 (22:31 +0100)]
Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view

Fixed by doing a pretty dumb copy of GetMarcNotes. Functional,
but it could be there is a more efficient way to do it given
we want one repeating tag rather than a range of tags?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- fixed small typo in opac-detail
- corrected isbd punctuation in opac-detail
- tested with 0, 1, 2, 3 isbns in 020, MARC21
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4438: incorrect "Budget total exceeds period allocation" error when editing fund
Henri-Damien LAURENT [Thu, 13 Jan 2011 14:04:19 +0000 (09:04 -0500)]
Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund

The process in check_parent_total for period allocation was not good.
It took all the children of a period.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago(bug #3743) fix acquisition stats ordering
Nahuel ANGELINETTI [Wed, 12 Jan 2011 15:08:46 +0000 (10:08 -0500)]
(bug #3743) fix acquisition stats ordering

This patch fix ordering in acquisition stats to order by month number.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5611' into kcmaster
Chris Cormack [Wed, 12 Jan 2011 19:19:46 +0000 (08:19 +1300)]
Merge remote branch 'kc/new/bug_5611' into kcmaster

13 years agoBug 5611: Simple typo fix in the comments
Chris Cormack [Wed, 12 Jan 2011 19:17:27 +0000 (08:17 +1300)]
Bug 5611: Simple typo fix in the comments

13 years agoTypo fix for history file
Chris Cormack [Wed, 12 Jan 2011 18:23:08 +0000 (07:23 +1300)]
Typo fix for history file

13 years agoAdding release info, and missing meetings to the history
Chris Cormack [Wed, 12 Jan 2011 17:56:58 +0000 (06:56 +1300)]
Adding release info, and missing meetings to the history

13 years agoAdding new developers to the history
Chris Cormack [Wed, 12 Jan 2011 17:52:06 +0000 (06:52 +1300)]
Adding new developers to the history

13 years agoBug 5611 Tidy up C4::Scrubber
Colin Campbell [Wed, 12 Jan 2011 16:53:22 +0000 (16:53 +0000)]
Bug 5611 Tidy up C4::Scrubber

Remove the unneeded package variables
Remove unnecessary variables
Removed some cargo-cult programming
Tidied the indentation from mix of tabs & spaces
Add a Test that we actually return the required class
of object

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5611 INIT block causes failure with mod perl
Bryce Sanchez [Wed, 12 Jan 2011 16:53:21 +0000 (16:53 +0000)]
Bug 5611 INIT block causes failure with mod perl

Per module INIT Blocks are not run in mod_perl so their
variables are not visible. A lexical var is adequate
for this purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5601 :: Add tests for bugfix
Colin Campbell [Wed, 12 Jan 2011 06:34:22 +0000 (07:34 +0100)]
Bug 5601 :: Add tests for bugfix

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5601 Fix processing of DueDate return
Colin Campbell [Wed, 12 Jan 2011 06:34:21 +0000 (07:34 +0100)]
Bug 5601 Fix processing of DueDate return

item duedate is not a datetime entity but a string retrieved
direct from the db that only needs restructuring
checkout was doing so but item_info was pretending it was in secs
(actually Item.pm manipulated then overwrote it!!)
assume the date in the db is correct (otherwise madness ensues)
dont try to second guess it
As duedates do not yet include a time element assume end of day
as a safety first

[F. Demians] I confirm Joe Atzberger diagnostic. That's a bug reported by a
library. I've tested Colin Campell solution. It fixes the bug.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5055 Use standard file paths in crontab.example
Magnus Enger [Wed, 5 Jan 2011 21:06:54 +0000 (22:06 +0100)]
Bug 5055 Use standard file paths in crontab.example

This is a revised patch, removing the lines pertaining to logrotate.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4131 have subscription so edit routing if one exists
Nicole Engard [Tue, 11 Jan 2011 07:33:51 +0000 (02:33 -0500)]
bug 4131 have subscription so edit routing if one exists

Changes the template variable checked in serials-menu.inc for determining where to
show 'Create Routing List' or 'Edit Routing List' to hasRouting.

Also adds the $hasRouting variable to serials/routing.pl and serials/routing-preview.pl,
for completeness.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5486 remove note about HomeOrHoldingBranch being removed soon
Nicole Engard [Tue, 11 Jan 2011 06:55:21 +0000 (01:55 -0500)]
bug 5486 remove note about HomeOrHoldingBranch being removed soon

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5603: advance_notice.pl uninitialized element in hash
Ian Walls [Sat, 8 Jan 2011 22:25:56 +0000 (17:25 -0500)]
Bug 5603: advance_notice.pl uninitialized element in hash

Changings one of the LEFT JOINS in C4::Members::Messaging::GetMessagingPreferences
to a JOIN to prevent NULL message_transport_types from being returned

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 2142 : Bumping database version
Chris Cormack [Tue, 11 Jan 2011 19:47:57 +0000 (08:47 +1300)]
Bug 2142 : Bumping database version

13 years agoBug 2142: reinstate maxItemInSearchResults systempreference
Ian Walls [Sat, 8 Jan 2011 22:24:41 +0000 (17:24 -0500)]
Bug 2142: reinstate maxItemInSearchResults systempreference

Reinstates the deleted maxItemsInSearchResults system preference, which was erroneously thought to no longer be utilized.
It's removal has led to bug 4430

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5492 update import patrons page title
Nicole Engard [Tue, 11 Jan 2011 06:52:56 +0000 (01:52 -0500)]
bug 5492 update import patrons page title

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5604 additional icons in the Seshat icon set
Nicole Engard [Tue, 11 Jan 2011 06:36:40 +0000 (01:36 -0500)]
bug 5604 additional icons in the Seshat icon set

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4945 - Patron search is limited by default to the currently logged-in...
Owen Leonard [Tue, 4 Jan 2011 14:04:41 +0000 (09:04 -0500)]
Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library

I couldn't figure out how (or whether) GetBranchesLoop could be
convinced to return a list of branches without selecting one, so
I swapped GetBranchesLoop with GetBranches. This will preselect
a branch only if a branch has been submitted as part of a query.

This does NOT preselect the correct branch when IndependantBranches
is turned on.

I also added a template variable which is true if a query has
been submitted with a branch or a category so that the extra
form fields can be displayed, reminding the user that they
added limiters to their query.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago(bug #3737) fix title search in order history
Nahuel ANGELINETTI [Mon, 10 Jan 2011 16:37:02 +0000 (16:37 +0000)]
(bug #3737) fix title search in order history

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database number to 011
Chris Cormack [Mon, 10 Jan 2011 19:12:59 +0000 (08:12 +1300)]
Bumping database number to 011

13 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Mon, 10 Jan 2011 19:10:52 +0000 (08:10 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

13 years agoBug 5186: Follow-up - Fixing wrong database number
Katrin Fischer [Thu, 23 Sep 2010 23:24:19 +0000 (01:24 +0200)]
Bug 5186: Follow-up - Fixing wrong database number

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5240' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:16:50 +0000 (09:16 +1300)]
Merge remote branch 'kc/new/bug_5240' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:14:22 +0000 (09:14 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_4838' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:13:17 +0000 (09:13 +1300)]
Merge remote branch 'kc/new/bug_4838' into kcmaster

13 years agoMerge remote branch 'kc/new/enh/bug_5560' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:11:50 +0000 (09:11 +1300)]
Merge remote branch 'kc/new/enh/bug_5560' into kcmaster

13 years agoBug 5589: Remove duplicated Exports in Suggestions.pm
Colin Campbell [Fri, 7 Jan 2011 11:44:03 +0000 (11:44 +0000)]
Bug 5589: Remove duplicated Exports in Suggestions.pm

Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA
and $VERSION twice. Have removed one invocation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4984, Invalid XHTML in staff client search results
Owen Leonard [Wed, 5 Jan 2011 08:24:53 +0000 (03:24 -0500)]
Fix for Bug 4984, Invalid XHTML in staff client search results

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdditional fix for Bug 3550, Use GetRecordValue to get the subtitle
Owen Leonard [Fri, 7 Jan 2011 10:34:11 +0000 (05:34 -0500)]
Additional fix for Bug 3550, Use GetRecordValue to get the subtitle

- Adding subtitle to Hold Ratio report output
- Sorting by default on ratio, descending
- Adding author
- Removing description

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore
Frédéric Demians [Mon, 20 Dec 2010 13:13:41 +0000 (14:13 +0100)]
Bug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore

[3.2] To be applied

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_4820' into kcmaster
Chris Cormack [Fri, 7 Jan 2011 01:27:06 +0000 (14:27 +1300)]
Merge remote branch 'kc/new/enh/bug_4820' into kcmaster

13 years agoFollow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page
Owen Leonard [Thu, 6 Jan 2011 21:03:07 +0000 (16:03 -0500)]
Follow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page

One instance of "default" usage missed in the original update

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow up on fix for Bug 5570, item types not showing on other editions
Owen Leonard [Thu, 6 Jan 2011 21:31:00 +0000 (16:31 -0500)]
Follow up on fix for Bug 5570, item types not showing on other editions

Fix for the staff client.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5570 - item types not showing on other editions
Owen Leonard [Tue, 4 Jan 2011 17:47:29 +0000 (12:47 -0500)]
Fix for Bug 5570 - item types not showing on other editions

The item type which shows on other editions is the biblio-level
itemtype. XISBN.pm had some item-handling code, but I'm
removing it because it is unused. The editions tab should
now display item type only if item-level itemtypes are not
enabled.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5006 - Invalid XHTML in record matching rules template
Owen Leonard [Wed, 5 Jan 2011 08:26:30 +0000 (03:26 -0500)]
Fix for Bug 5006 - Invalid XHTML in record matching rules template

- Rework JavaScript clone routines to use jQuery, to take
  label "for" into account, to handle incrementing label,
  and to properly place cloned blocks at the bottom of the group
- Rework JavaScript delete routines to use jQuery, to take
  block label numbers into account, and to show the "add"
  link if you have deleted the last block.
- Correcting markup which nests <div> inside <fieldset>
- Ensuring labels' "for" attribute matches input IDs
- Adding "required" style to required fields

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5583 Rename fieldnumber to blocknumber
Colin Campbell [Thu, 6 Jan 2011 11:37:19 +0000 (11:37 +0000)]
Bug 5583 Rename fieldnumber to blocknumber

Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5582 Pass tag nums as a string to Doc Popup
Colin Campbell [Thu, 6 Jan 2011 11:15:41 +0000 (11:15 +0000)]
Bug 5582 Pass tag nums as a string to Doc Popup

Add quotes around tag number when calling doc popup
Otherwise numbers with leading zeroes are interpreted
as octal e.g. 020 returns doc for 016

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5585: fix display of current date on receipts and slips
Galen Charlton [Wed, 5 Jan 2011 16:19:57 +0000 (11:19 -0500)]
bug 5585: fix display of current date on receipts and slips

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4950 - checkbox should be removed when can't place a hold
Owen Leonard [Wed, 5 Jan 2011 05:27:14 +0000 (00:27 -0500)]
Fix for Bug 4950 - checkbox should be removed when can't place a hold

- Hiding form controls for titles which can't be placed on hold
- Highlighting hold blocked message for better visibility
- Showing table of blocked holds even if none can be placed on
  hold: hiding the table hides the messages explaining why
  titles can't be placed on hold
- Removing an unused line from the script which was leaving errors
  in the error log
- Consolidating error messages into one box which were displaying
  in two.
- Correcting link to unused opac-userdetails.pl

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl
Owen Leonard [Wed, 5 Jan 2011 04:51:54 +0000 (23:51 -0500)]
Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl

Changes to list contents view to make it consistent with search results

My intention is to make the OPAC more consistent in the way it displays
lists of items, whether it be in search results, lists, etc. This patch
adds data to the list contents output and reformats it to that end.

The other significant change is the removal of jQuery table sorting.
Since list contents are both sorted and paginated on the server
side. Adding a client-side sort to one page of many doesn't make sense.

Other changes include:

- Change "Your lists" to "Your private lists"
- Remove "sort by" column because it seems unnecessary
- Adding logic to control display of count (item or items
  rather than item(s)
- Styling pagination bar and placing at the bottom of the page,
  consistent with other instances of pagination navigation

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5571 - tags as bulleted list too long
Owen Leonard [Wed, 5 Jan 2011 01:31:37 +0000 (20:31 -0500)]
Fix for Bug 5571 - tags as bulleted list too long

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5419: make reason checkouts blocked stand out
Nicole Engard [Thu, 30 Dec 2010 16:57:06 +0000 (11:57 -0500)]
bug 5419: make reason checkouts blocked stand out

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5497: make all library fields available to circ receipt/slips
Galen Charlton [Tue, 4 Jan 2011 19:38:44 +0000 (14:38 -0500)]
bug 5497: make all library fields available to circ receipt/slips

This allows the receipt template to be more readily customized
to include the library's address, phone number, email address, etc.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3918 - Add to order lists inconsistent
Owen Leonard [Tue, 4 Jan 2011 19:31:46 +0000 (14:31 -0500)]
Fix for Bug 3918 - Add to order lists inconsistent

- Added new include to contain add to basket options
- Minor markup corrections

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5375 (Update date/time last transaction (MARC 005) when saving authority record)
Marcel de Rooy [Thu, 16 Dec 2010 01:12:28 +0000 (20:12 -0500)]
Bug 5375 (Update date/time last transaction (MARC 005) when saving authority record)

Update 005 date/time when saving authority record for MARC21 and UNIMARC.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5374 (update transaction date when saving biblio) RESENT with small fix
Marcel de Rooy [Wed, 15 Dec 2010 23:11:28 +0000 (18:11 -0500)]
Bug 5374 (update transaction date when saving biblio) RESENT with small fix

Currently, the plugin marc21_field_005 and its unimarc opponent fill field 005
when this field gets focus. This implies that updating a record without
touching this field does not update 005.
At the same time, a user could accidentally delete a character in the 005 when
having focus. This mutilated field value will be saved however.

I would suggest to add a few lines to ModBiblioMarc in Biblio.pm to ascertain
that adding or updating a record always updates 005 in marc21 as well as
unimarc.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5563' into kcmaster
Chris Cormack [Mon, 3 Jan 2011 09:03:28 +0000 (22:03 +1300)]
Merge remote branch 'kc/new/bug_5563' into kcmaster

13 years agobug 5562 change 'issues' to read 'checkouts'
Nicole Engard [Thu, 30 Dec 2010 16:59:20 +0000 (11:59 -0500)]
bug 5562 change 'issues' to read 'checkouts'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5563 change note about cover images on enhanced content
Nicole Engard [Thu, 30 Dec 2010 17:02:15 +0000 (12:02 -0500)]
bug 5563 change note about cover images on enhanced content

on the enhanced content tab of system
preferences it says that Koha will pick
the first cover image - but in fact it
shows them all - that note needs to be
updated to properly warn of the expected
behavior.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoReimplemented fix for bug 5556, OPAC does not display the type of authority
Owen Leonard [Thu, 30 Dec 2010 17:07:11 +0000 (12:07 -0500)]
Reimplemented fix for bug 5556, OPAC does not display the type of authority

Formatting Janusz's suggested changes as a patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoReimplement fix for bug 5557 - Link to logs for user with view_system_logs permission
Owen Leonard [Thu, 30 Dec 2010 17:20:33 +0000 (12:20 -0500)]
Reimplement fix for bug 5557 - Link to logs for user with view_system_logs permission

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version to 3.03.00.010
Chris Cormack [Sat, 1 Jan 2011 20:30:23 +0000 (09:30 +1300)]
Bumping database version to 3.03.00.010

13 years agobug 5040 fix misspelling of distance in marc21 framework
Nicole Engard [Thu, 30 Dec 2010 17:32:37 +0000 (12:32 -0500)]
bug 5040 fix misspelling of distance in marc21 framework

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4942 - add validation to patron administration
Robin Sheat [Fri, 31 Dec 2010 14:18:55 +0000 (09:18 -0500)]
bug 4942 - add validation to patron administration

This validation requires an enrollment period or a date to be provided
before the form will save, which will prevent invalid dates getting into
the system.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5045 - Help works even when the referrer is being stripped
Robin Sheat [Fri, 31 Dec 2010 16:19:17 +0000 (11:19 -0500)]
bug 5045 - Help works even when the referrer is being stripped

This fix puts the URL of the source page as a parameter to help.pl,
which will override the referrer value, if it's provided. This deals
with people sitting behind proxies that strip the referrer information
out.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3665, adding another submit button as in OPAC
Owen Leonard [Thu, 30 Dec 2010 11:33:46 +0000 (06:33 -0500)]
Fix for Bug 3665, adding another submit button as in OPAC

This is the only change proposed in Bug 3665 which hasn't
already been implemented by someone else. It adds a submit
button under the first section of the advanced search page
just like the OPAC advanced search has.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4820, Alter layout of Circulation and fines rules page for clarity
Owen Leonard [Thu, 30 Dec 2010 11:31:23 +0000 (06:31 -0500)]
Fix for Bug 4820, Alter layout of Circulation and fines rules page for clarity

I propose some changes to the issuing rules interface to improve usability:

 - Better define and delineate the sub-sections on the page:
   - Default checkout and hold policy
   - Checkout limit by patron category
   - Holds policy by item type

 - Repeat the current library name, when selected, for clarity: "Default
   checkout and hold policy for Athens" rather than "Default checkout and
   hold policy for this library"

 - Use the phrase "all libraries" when no library is selected. "Default
   library" seems ambiguous. "All libraries" better defines how the rule
   will be applied: to all libraries in the absence of a more specific rule.

 - Use the term "all" instead of "default" in cases where a rule will apply
   to all categories or item types.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5550 - correct filename referenced in docs
Robin Sheat [Wed, 29 Dec 2010 01:20:19 +0000 (14:20 +1300)]
Bug 5550 - correct filename referenced in docs

Spotted by Reed Wade.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>