We were calling get biblioitemdata when we should have been calling get bibliodata

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug that was causing a charge to be added twice if renewing in circulation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to stop a silent failing of issuing when an item from a branch is checked out at another branch and independent branches is on

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

update facets: remove count

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for branch facet - [homebranch]

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: do not crash when searching 'default' (all) heading types

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

corrections to biblio indexing for authority record links

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfixes for reindexing problems

* now properly deletes deleted authorities from index
* now actually ignores duplicate work
* standardized on recordDelete instead of delete_record
  for bibs and recordDelete for authorities

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

when reverting import batch: don't try to delete items that are already deleted

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

various authorities fixes

* improve generation of summaries for MARC21 authorities
* fix search syntax for link to display bibs linked to a given authority
* in addbiblio.pl's BiblioAddAuthorities, check all headings, not just the first of each tag

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

misc labels fixes

* Corrected sample label data
* Commented out debug warns and smart comments
* Correct location of a template

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature cleanup for returns

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing the behaviour the browse by letters links show all the time now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 404 error when clicking on a reserve in circulations

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for borrower name not showing when a borrower is debarred

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to add dbms type and port & rename db vars for multi-dbms

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Commenting out link to addnotes.pl which doesnt exist

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Setting it up so circ and members use a different toolbar so that actions can return to their right destination

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix so that if you edit a borrower from circ, or change a password from circ you are taken back there

Toolbar needs to be made for members too, its using the same one as circ, which isnt right, will do this next

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Modifying styling of resident search boxes in order to prevent brief appearance of search boxes that get hidden by javascript."

This reverts commit 0cfc014f896adceadb7471bb35076bb6d3f9fe7d.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating img filefind that has been moved

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

record.abs: rm 090$c , add 952$y itemtype

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating language slightly - branch->library, etc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

too many column merged. minor change

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

relooking histsearch & adding some links to jump to basket, biblio...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

UNIMARC zebra config files updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating about.pl

- adding all dependencies
- adding yui tabs for a better look
- adding BibLibre in credits for frenchies main contributors
- removing translators for other languages than french, as only french is available now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

handling wrong MARC record better

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix to limit search to branch in OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

utf8 handling fixes 'Wide character in print at' encoding errors.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improvements to nomenclature and translations

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing encoding declarations to make it easier to translate

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

wrapping AddBiblio(), and AddItem() in evals{} to protect import from failure due to bad records.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

wrapping write to *.iso file in eval{}, to handle failure, caused by bad record.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing default behaviour of reserves back to needing a return. (this can be switched off in sys prefs)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shifting other variables, no need to have the same code twice just more chance for a typo :)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for variable scoping problem

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for reserve notes not showing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

further mods to change from ccode to itype at item-level itypes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updatedatabase for itype.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changes to item-level itype reintroduce items.itype (had been removed by updatedatabase but still in kohastructure) populate itype with bi.itemtype. fix error in getbiblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

quick auth hack for zebra 2.0.18 could probably be cleaner...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Making SQL more portable

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing nomenclature and tmpl_process3.pl bugs

tmpl_process3.pl still throws some multi-byte warnings
but no markup errors

There are still quite a few places we could normalize
to reduce the size of the translation file

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing dumper

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added inital 'delete' lines, so running 'mysql koha3 < marc21_framework_DEFAULT.sql' doesnt fail if you currently have existing rows in your marc-framework tables (which is likely)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Added class tables

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing advanced search

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updating to .0024 (conflict between joshua and mason, both updated to 23)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changing biblioitems.itemtype to varchar(10)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing : dates orders were inverted

Newest to Oldest is desc and not asc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

zebra abs file update.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating labels* tables for innodb, and recent dev work.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tidying. Properly commenting javascript in some search includes. Standardizing markup in tools and labels. Correction to date function in label-item-search.pl (Thanks Joe)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating version to trigger updatedatabase

adding yuipath system preference to updatedatabase

adding new sysprefs for YUI Path, default to pull from external source

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing failed merge in updatedatabase

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing typo Test::CSV should be Text::CSV

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bumping to .0022

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correction from my batch of search include changes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing some unused menus, moving a couple of simple toolbars into the page body.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Modifying styling of resident search boxes in order to prevent brief appearance of search boxes that get hidden by javascript.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting admin-home into columns, styling system preferences 'add' button.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Enabling yuipath system preference for choosing local or Yahoo-hosted YUI js library includes. Removing yui-toolbars.inc include.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Lots of work to standardize elements like Save/Cancel buttons and delete confirmations. A couple of changes to auth_subfields_structure.pl in order to enable display of tagfield and tagsubfield without outputting hidden form field at the same time (for breadcrumbs).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Corrected marc_subfield_structure.authorised_value & authtypecode to varchar(20)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Corrected marc_subfield_structure.seealso to varchar(1100)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Corrected marc_subfield_structure.seealso to varchar(600)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed references to disused value_builders

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding extra MARC frameworks development comments and SQL statements for MARC fields with letters to misc/installer_devel_notes/data/en/marcflavour .

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding English UNIMARC frameworks.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Chaning MARC 21 bibliographic frameworks. Removing plugins which have yet to be written. Adding missing biblioitems.cn_prefix column link. Translating Recommandation 995 to English. Removing some development comments and SQL statements for MARC 21 field names with letters.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Moving simple MARC 21 bibliographic frameworks to installer/data/en/marcflavour/marc21/optional .

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC 21 frameworks changes. Moving bibliographic frameworks field names with letters and many development comments, and removing use of unwritten plugins, Changing authority frameworks syntax.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: prevent multiple addition of the same authorised value in a category

Also put the prev/next page buttons in the same place relative to the
action links

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUMP to 022 : items.damaged added

It was declared in kohastructure, but forgotten in updater. libraries upgrading from 2.2 will have problem...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

dealing with >=, <= and date stuff in NoZebra

- if the user search on >= or <=, fix a bug removing the < and >
- if the user search on a numeric value (mainly for dates search), retrieve only numeric results

Example : previously Date >=2005 returned "printed in 1976", as "printed" was > than 2005
now it don't.
note that Date >=1900 returns "printed in 1976" as NZ search is a always wrdl search (and, as you know 1976 > 1900 ;-) )

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added missing admin menu to two templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

NZOrder Broken

Sorting Operands changed : Adapting NZOrder to these changes
Removing < > from string deletion.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1565, added close link.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug-1565, added close , and search-again links

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

extended missed branchcode columns to 10 chars

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changing missed branchcode columns from varchar(4) to 10

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding "Loading" overlay for addbiblio and add authority pages. Adding YUI button to authorites.tmpl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Lots of work to standardize elements like Save/Cancel buttons and delete confirmations. A couple of changes to auth_subfields_structure.pl in order to enable display of tagfield and tagsubfield without outputting hidden form field at the same time (for breadcrumbs).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small fix for a variable out of scope

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1546 REPLACE statements (continued)

- biblio framework
- marc tag
- auth tag

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfixes to config files for zebra 2.0.18

those 2 lines are invalid

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small change in french translation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding Class::Factory::Util dep

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove facets header if there is no facets to show

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more corrects to MARC21 leader editing templates

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moved kohaspsuggest preference to OPAC features tab

Was in 'Catalogue', but this feature is not related to
cataloguing but OPAC search logging.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo that caused MARC21 leader form to emit 25 characters instead of 24

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "leader must be 25 and not 24 char long"

This reverts commit 991ae79bb607b84e8df23023b7eeda11d4ca8ff5.

Note: the MARC21 (and UNIMARC) leader length is *24* characters,
not 25.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix typos on syspref

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1526 reserve status not showing on detail.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

further item-level itype changes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

notforloan from items.ccode->itemtypes.notforloan instead of bi.itemtype

(by syspref)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>