]> git.koha-community.org Git - koha.git/log
koha.git
10 years agoBug 12557: Add a way to revert the changes made on items on receving
Jonathan Druart [Fri, 11 Jul 2014 10:09:32 +0000 (12:09 +0200)]
Bug 12557: Add a way to revert the changes made on items on receving

Bug 8307 introduces the AcqItemSetSubfieldsWhenReceived pref.
You can now update an item field on receiving (if you create items on
ordering).
But if the receipt is cancel, there is no way to revert these changes.

This patch adds a new pref AcqItemSetSubfieldsWhenReceiptIsCancelled to
allow to revert changes previously done on receiving

Test plan:
0/ Set the AcqCreateItems to 'ordering'
1/ Fill AcqItemSetSubfieldsWhenReceived with o=1 (UNIMARC) or 7=1
(MARC21).
2/ Fill AcqItemSetSubfieldsWhenReceiptIsCancelled with o=2 (UNIMARC) or
7=2 (MARC21)
3/ Create an order with some items
4/ Receive the order and verify the notforloan value is set to 1
5/ Cancel the receipt and verify the notforloan value is set to 2

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12557: DB changes - Add the AcqItemSetSubfieldsWhenReceiptIsCancelled pref
Jonathan Druart [Fri, 11 Jul 2014 10:08:07 +0000 (12:08 +0200)]
Bug 12557: DB changes - Add the AcqItemSetSubfieldsWhenReceiptIsCancelled pref

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12833: Patron search should search on extended attributes
Jonathan Druart [Thu, 28 Aug 2014 08:51:03 +0000 (10:51 +0200)]
Bug 12833: Patron search should search on extended attributes

Before Bug 9811, the patron search searched on extended attributes.

This patch restore this behavior.

Test plan:
0/ Create a patron attribute PA
1/ Create a patron A (cardnumber CNA) with PA="foo"
2/ Create a patron B (cardnumber CNB) with PA="foo bar"
3/ Search for CNA should redirect on the patron detail page.
4/ Search for "foo" should display the search result with 2 results.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
'Searchable' patron attributes can now be searched for again.
Works as described, passes stests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12698 - If user changes home library in Opac change is not visible in staff client
Marc Véron [Mon, 21 Jul 2014 18:03:01 +0000 (20:03 +0200)]
Bug 12698 - If user changes home library in Opac change is not visible in staff client

To test:
- Set opacuserlogin and OPACPatronDetails to allow
- Log in to OPAC, go to 'your personal details'
- Change Home library
- Go to staff client: Patrons requesting modifications (/cgi-bin/koha/members/members-update.pl)
- Without patch, you do not see the change request, but can Approve, Deny or Ignore it
- With patch, you see the change request, indicating the Home library (branchcode)

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I "slightly" rewrote the patch so it applies on current master.

10 years agoBug 7817: (followup) add test on MARC bibliographic framework test
Tomas Cohen Arazi [Mon, 8 Sep 2014 15:28:41 +0000 (12:28 -0300)]
Bug 7817: (followup) add test on MARC bibliographic framework test

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7817: DBRev 3.17.00.022
Tomas Cohen Arazi [Mon, 8 Sep 2014 15:04:40 +0000 (12:04 -0300)]
Bug 7817: DBRev 3.17.00.022

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7817: QA Follow-up: Print a warning when permanent location is mapped
Marcel de Rooy [Mon, 25 Aug 2014 11:24:03 +0000 (13:24 +0200)]
Bug 7817: QA Follow-up: Print a warning when permanent location is mapped

Item field permanent location should not be mapped to the MARC structure.
If a library did so, this dbrev will print a warning.
If refers to report 12818 for help in moving the data to more_subfields_xml.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested by putting permanent_location in and out of the MARC structure.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7817: Follow-up for original patch
Marcel de Rooy [Mon, 18 Aug 2014 11:25:48 +0000 (13:25 +0200)]
Bug 7817: Follow-up for original patch

This patch removes the commented line for permanent_location.
It adds a more general comment.
Adjusts the exists check on permanent_location.
Adds a reference to bug 12817 that will deal with paidfor similarly.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7817 - Items Permanent location (shelving location) is set to NULL when item...
Olli-Antti Kivilahti [Wed, 18 Jun 2014 15:31:13 +0000 (18:31 +0300)]
Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited

A quick fix to prevent more damages.
No perceived side-effects so far.

Signed-off-by: David Cook <dcook@prosentient.com.au>
This is actually a perfectly good fix for this issue. I've changed
the explanatory comment to explain why.

Another option would be to remove the 'exists' check in the sub
_do_column_fixes_for_mod(), but this is just as functional.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Detailed comment on Bugzilla.
Adding a small follow-up.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12467 [QA Followup] - Unit Tests
Kyle M Hall [Thu, 28 Aug 2014 17:47:18 +0000 (13:47 -0400)]
Bug 12467 [QA Followup] - Unit Tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12467 - Lost items marked as not on loan even if they are!
Kyle M Hall [Mon, 23 Jun 2014 16:21:16 +0000 (12:21 -0400)]
Bug 12467 - Lost items marked as not on loan even if they are!

The cronjob longoverdue.pl does not require that an item marked as lost
be returned automatically, but there is a line in ModItem that
automatically marks the item's onloan as false if itemlost is set!

Test Plan:
1) Mark an item as lost with longoverdue.pl, without --mark-returned
2) Inspect the db, note that items.onloan is now 0
3) Apply this patch
4) Mark repeat step 1
5) Inspect the db, noe that items.onloan is still 1
6) Test marking an item as lost from staff interface,
   ensure there are no regressions.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works according to test plan and fixes a data loss bug.

Some notes:
- This patch would be nicer with a regression test.
- Also checked that returning the item removes lost status and onloan still.
- Tried to test with --mark-returned, but couldn't get it to
  return my item neither with nor without the patch. (see comment on
  bug report)

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12835 - Acquisitions: Show search terms in z39.50 results
Marc Véron [Fri, 15 Aug 2014 04:28:07 +0000 (06:28 +0200)]
Bug 12835 - Acquisitions: Show search terms in z39.50 results

To test:

- Go to Acquisitions, select a bookshop and a basket, click 'Add to basket':'From an external source'
- Do a search
- Your search terms should display at the top of the results page.
- Repeat search with several combinations of search terms (with and without results).

- Check the output for correct html.

Fields Raw (any) and Standard ID removed / MV

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script, works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12828: Update Z39.50/SRU online help
Marcel de Rooy [Tue, 26 Aug 2014 15:06:57 +0000 (17:06 +0200)]
Bug 12828: Update Z39.50/SRU online help

Test plan:
Go to Z39.50/SRU servers, click Help and read the text.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Additions to help file, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12746 - Remove empty onclick attribute from memberentrygen.tt
Marc Véron [Tue, 29 Jul 2014 14:56:44 +0000 (16:56 +0200)]
Bug 12746 - Remove empty onclick attribute from memberentrygen.tt

This patch removes empty onclick attribute from memberentrygen.tt

To test:
Apply patch.
Use git grep 'onclick=""' to make sure that there are no more empty onlick attributes
Go to Home > patrons  and click 'New patron'
Check HTML of 'Cancel' link
Make sure that 'Cancel' link still works

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes the link to cancel adding a manual restriction.
No regressions found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12821: (qa followup) fix History -> Timeline on the help page
Tomas Cohen Arazi [Mon, 8 Sep 2014 13:52:05 +0000 (10:52 -0300)]
Bug 12821: (qa followup) fix History -> Timeline on the help page

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12821: Capitalization: about page fixes
Tomas Cohen Arazi [Mon, 25 Aug 2014 15:29:27 +0000 (12:29 -0300)]
Bug 12821: Capitalization: about page fixes

This patch fixes several capitalization issues in the about page.

To test:
- Go to the about page
=> FAIL: you should see
   * Server Information (tab)
   * Koha Team (tab)
   * Koha Timeline (tab)
   * Additional Thanks To... (at the bottom of the Koha Team tab
- Apply the patch and reload
=> SUCCESS: you should see
  * Server information
  * Koha team
  * Timeline
  * Additional thanks to...
- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String changes, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12765: Fix capitalization - "Try another search"
Katrin Fischer [Mon, 8 Sep 2014 09:28:49 +0000 (11:28 +0200)]
Bug 12765: Fix capitalization - "Try another search"

To test:
- Go to cataloguing
- Perform a z39.50 search with no results
- Check "Try another search" is displayed
- Perform a z39.50 search with results
- Verify display is correct as well.

Signed-off-by: George Williams <georgew@latahlibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12788: (followup) minor optimization with proper tests
Tomas Cohen Arazi [Wed, 20 Aug 2014 14:39:27 +0000 (11:39 -0300)]
Bug 12788: (followup) minor optimization with proper tests

This patch removes the $facets_info calculation from the _get_facets_data_from_record
sub so it is not done for each record. It introduces a new sub, _get_facets_info
that is called from the getRecords loop, that does the job only once.

To test:
- Apply on top of the previous patches
- Run
  $ prove -v t/db_dependent/Search.t
=> SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and UNIMARC.
  Facets rendering should remain unchaged on the UI.
- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12788: facets calculation should skip 100 if ind1=z
Tomas Cohen Arazi [Wed, 20 Aug 2014 03:48:07 +0000 (00:48 -0300)]
Bug 12788: facets calculation should skip 100 if ind1=z

This patch adds a test for field 100, to skip it on facet calculation
if ind1=z.

To test:
- Have IncludeSeeFromInSearches set.
- Create a biblio record, when adding an author, create a new authority record
  that contains a 400$a field (see from).
- Rebuild zebra db.
- Search for the record making sure the search returns more than one record.
=> FAIL: the facets contain the 'see from' field.
- Run
  $ prove -v t/db_dependent/Search.t
=> FAIL: it fails
- Apply the patch
- Run
  $ prove -v t/db_dependent/Search.t
=> SUCCESS: it passes
- Re-run the search, notice the 'see from' doesn't show anymore on the facets.
- Sign off :-D

Edit: minor stylistic change

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBub 12788: (regression test) refactor facet extraction code to allow testing
Tomas Cohen Arazi [Wed, 20 Aug 2014 03:33:40 +0000 (00:33 -0300)]
Bub 12788: (regression test) refactor facet extraction code to allow testing

This patch refactors the facet extraction loop into a proper function.
The loop is changed so the MARC::Record objects are created only once
instead of the old/current behaviour: once for each defined facet (in
C4::Koha::getFacets).

To test:
- Apply the patch
=> SUCCESS: verify facets functionality remains unchanged.
- Run:
  $ prove -v t/db_dependent/Search.t
=> SUCCESS: tests for _get_facets_data_from_record fail, because
  100$a is considered for fields with indicator 1=z (field added
  by IncludeSeeFromInSearches syspref).
- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12582: DBRev 3.17.00.021
Tomas Cohen Arazi [Fri, 5 Sep 2014 15:18:34 +0000 (12:18 -0300)]
Bug 12582: DBRev 3.17.00.021

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch
Kyle M Hall [Wed, 16 Jul 2014 11:44:12 +0000 (07:44 -0400)]
Bug 12582 - Control of branch displayed in search results linked to HomeOrHoldingBranch

Some libraries would like the ability choose to display the home branch
on search results while having circulation rules based on the holding
branch. This is currently impossible because both the display of the
branch in search results, and the selection of the home or holding
branch for circulation rules are controlled by the same system
preference: HomeOrHoldingBranch. This preference is described as being
used only for circulation rules, and makes no mention of its use for
display control. The display control should be split off into a separate
preference.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note the value of the new system preference StaffSearchResultsDisplayBranch
   matches the current value of HomeOrHoldingBranch
4) Set the preference to home branch
5) Perform a staff catalog search with results having items with differing home and
   holding branches.
6) Note the home branch displays
7) Set the preference to holding branch
8) Repeat step 5
9) Note the holding branch displays

Signed-off-by: Jason Robb <jrobb@sekls.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, logic is now tied to a new system preference.
Passes tests and QA script.

10 years agoBug 12330: [QA Follow-up] Consistency between opac-search and staff client
Marcel de Rooy [Wed, 9 Jul 2014 13:56:54 +0000 (15:56 +0200)]
Bug 12330: [QA Follow-up] Consistency between opac-search and staff client

In opac-search two regexes are added for the results of splitting the
pref AdvancedSearchTypes, allowing spaces before and after the names.
The same regexes should be added to catalogue/search.pl to have the
same behavior there.

Test plan:
Set AdvancedSearchTypes to "itemtypes  |  ccode |  loc " (no quotes).
Check OPAC and staff with and without this patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12330: OpacHiddenItems not affecting Advanced Search
Mark Tompsett [Thu, 29 May 2014 22:31:03 +0000 (18:31 -0400)]
Bug 12330: OpacHiddenItems not affecting Advanced Search

This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.

TEST PLAN
---------
 1) Back up your DB (always handy)
 2) Set the Searching system preference AdvancedSearchTypes to:
    'itemtypes|ccode|loc' (without the single quotes).
 3) Set the OPAC system preference OpacHiddenItems to include the
    lines:
     itype: [{list of itemtype codes separated by commas}]
     location: [{list of comma delimited shelving location codes}]
     ccode: [{list of comma delimited collection codes}]
    Make sure to exclude one value for each, so there will be at
    least one known thing on each tab.
 4) Open the OPAC.
 5) Click on 'Advanced Search'
    -- three tabs appear: Itemtypes, Collection, Shelving location
    -- Everything is visible
 6) Set the Searching system preference AdvancedSearchTypes to:
    'itemtypes | ccode |     loc' (without the single quotes).
 7) Refresh the OPAC.
    -- There will be three tabs, but ugliness ensues.
 8) Apply the patch
 9) Refresh the OPAC.
    -- You will see: Itemtypes, Collection, Shelving location
    -- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Small rewording in comment only.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12864: Add LOC SRU server to sample z3950servers.sql
Marcel de Rooy [Wed, 3 Sep 2014 11:43:50 +0000 (13:43 +0200)]
Bug 12864: Add LOC SRU server to sample z3950servers.sql

Add LOC SRU server to sample servers installed.
This patch modifies four language files: de, en, es and nb.
For the other languages this may not be useful.

Test plan:
You could test this by using the webinstaller.
But you could also (backup) and delete your records in z3950servers, and
run the sample_z3950_servers.sql file from the command line.
Check if you see the new SRU server.

Tested using mysql. I truncated the table (to reset the IDs as well) and then ran the file. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8735: DBRev 3.17.00.020
Tomas Cohen Arazi [Fri, 5 Sep 2014 14:51:53 +0000 (11:51 -0300)]
Bug 8735: DBRev 3.17.00.020

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8735 [QA Followup 2] - Remove extra period, add bug number to db update
Kyle M Hall [Wed, 4 Jun 2014 18:22:23 +0000 (14:22 -0400)]
Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8735 [QA Followup] - Add Unit Tests
Kyle M Hall [Thu, 17 Apr 2014 18:33:16 +0000 (14:33 -0400)]
Bug 8735 [QA Followup] - Add Unit Tests

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8735 - Expire holds waiting only on days the library is open - Followup - Switch...
Kyle M Hall [Tue, 23 Apr 2013 16:32:03 +0000 (12:32 -0400)]
Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar

Test Plan:
 1) Set ExpireReservesMaxPickUpDelay
 2) Set ReservesMaxPickUpDelay to 1
 3) Place a hold, set it to waiting
 4) Using the MySQL console, modify the waiting date and set it to the
    day before yesterday.
 5) Set today as a holiday for the pickup branch in question.
 6) Run misc/cronjobs/holds/cancel_expired_holds.pl
 7) The hold should remain unchanged
 8) Remove today as a holiday
 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again
10) The hold should now be canceled

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8735 - Expire holds waiting only on days the library is open
Kyle M Hall [Thu, 6 Sep 2012 15:15:21 +0000 (11:15 -0400)]
Bug 8735 - Expire holds waiting only on days the library is open

Signed-off-by: Leila <koha.aixmarseille@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6149: (qa followup) sysprefs should be alphabetically sorted
Tomas Cohen Arazi [Fri, 5 Sep 2014 14:33:27 +0000 (11:33 -0300)]
Bug 6149: (qa followup) sysprefs should be alphabetically sorted

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6149: DBRev 3.17.00.019
Tomas Cohen Arazi [Fri, 5 Sep 2014 13:57:52 +0000 (10:57 -0300)]
Bug 6149: DBRev 3.17.00.019

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting
Martin Renvoize [Tue, 11 Mar 2014 09:05:51 +0000 (09:05 +0000)]
Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting

- global replaced HightedStopWords syspref with NotHightedWords for
  clarification purposes. Hopefully this is a bit better and still
  not too verbose.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, fixed some tabs and a typo.

10 years agoBug 6149: Follow-up [grouped] - Stopwords for Result Highlighting
Martin Renvoize [Tue, 19 Nov 2013 12:07:59 +0000 (12:07 +0000)]
Bug 6149: Follow-up [grouped] - Stopwords for Result Highlighting

- Added functionaility to opac-results-grouped page

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
10 years agoBug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting
Martin Renvoize [Mon, 28 Oct 2013 12:12:30 +0000 (12:12 +0000)]
Bug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting

- Added functionality to new bootstrap theme

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
10 years agoBug 6149: Follow-up [defaults] - Stopwords for Result Highlighting
Katrin Fischer [Sun, 27 Oct 2013 14:34:49 +0000 (15:34 +0100)]
Bug 6149: Follow-up [defaults] - Stopwords for Result Highlighting

- changed sample words to and|or|not in sysprefs.sql and
  updatedatabase
- changed systempreference name from OpacHighlightedStopwords
  to HighlightedStopwords, as it also works for the staff
  results page

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
10 years agoBug 6149 - Stopwords for Result Highlighting
Martin Renvoize [Fri, 9 Aug 2013 13:42:00 +0000 (14:42 +0100)]
Bug 6149 - Stopwords for Result Highlighting

This patch adds a system preference to control stopwords used to
prevent operators and other 'minor' words from being highlighted
in search results when the OpacHighlightWords syspref is enabled

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Works as advertised, I fixed the updatedatabase to use XXX so it won't
clash as much

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a conflict in updatedatabase.pl.
Also fixed tabs in opac-detail.tt

Feature passes all tests and QA script now.
Tested in intranet and OPAC with different words and searches.
Works on results pages and OPAC detail page.
Highlighting and unhighlighting still works correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works as expected.

10 years agoBug 7498 - Cloning a budget, enable change of description
charles [Wed, 6 Aug 2014 20:44:19 +0000 (16:44 -0400)]
Bug 7498 - Cloning a budget, enable change of description

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

This new patch builds on the work of Bug 12164 by allowing the
user to enter a new name (budget_period_description) for the
cloned budget.

A test was added to t/db_dependent/Budgets.t.

Sponsored-by: CCSR
Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Edit: added the sponsored-by line.

10 years agoBug 12790: QA-follow-up: Mention required version in online Help
Marcel de Rooy [Thu, 4 Sep 2014 06:40:05 +0000 (08:40 +0200)]
Bug 12790: QA-follow-up: Mention required version in online Help

For those who would not understand the two version numbers and come up
with the idea to check the Help page, some text is added.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12790 - Perl modules: Display required version numbers on about page
Marc Véron [Thu, 7 Aug 2014 05:45:34 +0000 (07:45 +0200)]
Bug 12790 - Perl modules: Display required version numbers on about page

This patch adds information about required perl module versions to the
'About' page.

To test:
Apply patch.
In staff client, go to 'About', tab 'Perl modules'
The required version numbers should display in small print next to or
underneath the module names.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12869 - update the version in build-git-snapshot
Robin Sheat [Thu, 4 Sep 2014 04:30:34 +0000 (16:30 +1200)]
Bug 12869 - update the version in build-git-snapshot

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12866: Fixes Display of Email in Alternate Address
Janet McGowan [Wed, 3 Sep 2014 16:05:58 +0000 (16:05 +0000)]
Bug 12866: Fixes Display of Email in Alternate Address

Incorrect display of Email Address in Alternate Address Patron Details

Without patch, mail from primary address is displayed in Alternate address
With patch, correct mail address is displayed
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance...
Tomas Cohen Arazi [Tue, 2 Sep 2014 13:40:32 +0000 (10:40 -0300)]
Bug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance behaviour regarding hold charges

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12205: DBRev 3.17.00.018
Tomas Cohen Arazi [Mon, 1 Sep 2014 15:58:22 +0000 (12:58 -0300)]
Bug 12205: DBRev 3.17.00.018

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12205 : Add a system preference allowing hold charges to block circ
Chris Cormack [Tue, 6 May 2014 22:15:20 +0000 (10:15 +1200)]
Bug 12205 : Add a system preference allowing hold charges to block circ

Currently, if you have holds charges, they are not taken into
consideration when circulating items.

Manual Invoices, and rental charges are governed by a systempreference

Holds are never counted

And all other charges (overdues, lost items etc) are counted

This patch adds a systempreference to allow Hold charges to be counted
as well.

To test

1/ Set a borrower category to have holds charges
2/ Place a hold for a borrower in that category
3/ Go to checkout, notice that charge is not showing or blocking on
that screen
4/ apply patch
5/ notice that charge now shows on checkout

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12705 - News not possible for one sublanguage if two sublanguages are installed
Marc Véron [Sun, 27 Jul 2014 06:03:23 +0000 (08:03 +0200)]
Bug 12705 - News not possible for one sublanguage if two sublanguages are installed

To test:
- Install two language variants (e.g. de-DE and de-CH)
- Create OPAC news for each of them
- Verify that they are displayed in OPAC as appropriate

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works Ok, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works ok, all installed languages now show up in the pull downs
and display for the selected language in the OPAC.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12309: Adapt zipcode wording to match the other patron pages
Jonathan Druart [Fri, 6 Jun 2014 14:36:46 +0000 (16:36 +0200)]
Bug 12309: Adapt zipcode wording to match the other patron pages

Replace "Zip code" with "Zip/Postal code" which is used in
members/memberentry.pl and members/moremember.pl.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12309 - Add more fields to batch patron modification tool
Owen Leonard [Thu, 22 May 2014 13:23:45 +0000 (09:23 -0400)]
Bug 12309 - Add more fields to batch patron modification tool

It would be helpful to be able to use the batch patron modification tool
to update city, state, zipcode, and country. This patch adds this
functionality.

This patch corrects an error in the batch modification script which
would have incorrectly marked first name as required if surname was
required.

This patch also converts the table sorting configuration to use table
header class names instead of index-based sorting for columns containing
dates.

To test, apply the patch and submit a batch of patrons to the batch
patron modification tool (Tools -> Batch patron modification).

In the list of patrons which will be modified you should see columns for
city, state, zipcode, and country. Table sorting should work correctly
without errors, including the registration and expiry date columns.

In the list of fields which can be batch modified you should see inputs
for city, state zipcode, and country. These fields should correctly
reflect mandatory/not mandatory based on the BorrowerMandatoryField
system preference.

Submit batch changes to a variety of fields and confirm that changes are
applied correctly. On the page of results the table should correctly
show all fields and be sorted correctly.

Signed-off-by: cachan <pierre.lorgue@ens-cachan.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12061 - tmpl_process3.pl - Include/exclude file by name
Bernardo Gonzalez Kriegel [Thu, 10 Apr 2014 01:30:35 +0000 (22:30 -0300)]
Bug 12061 - tmpl_process3.pl - Include/exclude file by name

This patch adds options to include/exclude files by matching their names.
Also modifies current code to check only filenames (not dirs)
Checking is case insensitive !!

NOTE: The difference between -f and -m is subtle, but important.
They differs mainly on update,: -f do a merge, -m a replace

To test after patch:

A) Include only 'normarc'
1. create
cd misc/translator
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc
- check provenance of strings
egrep "^#:" normarc.po | cut -d":" -f2 | sort | uniq
- only files with normarc in their names must be present

2. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s normarc.po -r -m normarc
- repeat check

3. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s normarc.po -r -m normarc
- check name of created files

rm -rf test normarc.po

B) Exclude
4. create
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc
- check provenance
egrep "^#:" xnormarc.po | cut -d":" -f2 | sort | uniq | grep -i normarc
- there must be no results

5. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s xnormarc.po -r -n normarc
- check provenance

6. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o ./test -s xnormarc.po -r -n normarc
- check files
find test | grep -i normarc
- there must be no results

You can also try another combination, use for example "-m patron -m user -m bottom" (or use -n)
or mixed "-m marc -n normarc", do create/install and look filenames

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12061 - tmpl_process3.pl - Multiple source dir
Bernardo Gonzalez Kriegel [Mon, 7 Apr 2014 00:39:08 +0000 (21:39 -0300)]
Bug 12061 - tmpl_process3.pl - Multiple source dir

This patch adds the option to use multiple source
dirs for tmpl_process3.pl on create/update actions.

To test after patch:
A) Old
1. install
cd misc/translator
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s bootstrap.po -r

2. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap -s bootstrap.po -r

3. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap -s bootstrap.po -r -o ./test -q
- check same number of files
ls -lR ../../koha-tmpl/opac-tmpl/bootstrap | wc -l
ls -lR ./test | wc -l

rm -f bootstrap.po

B) New
4. create from multiple sources
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s opac.po -r

5. update from multiple source
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s opac.po -r

6. install (must give an error)
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/prog/en -i ../../koha-tmpl/opac-tmpl/bootstrap -s opac.po -r -o ./test

7. updated help
perl tmpl_process3.pl --help

Any other functionality must not be affected

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12061 - tmpl_process3.pl - Remove obsoleted strings/backups
Bernardo Gonzalez Kriegel [Sun, 6 Apr 2014 22:21:47 +0000 (19:21 -0300)]
Bug 12061 - tmpl_process3.pl - Remove obsoleted strings/backups

This patch modifies the update process for PO files,
removing obsoleted strings. Currently they are removed
manually as part of the standar procedure of strings update.
Also backup files (*~) need to be removed manually.

To test:
1. Update translation files for any language, ej. fi-FI
(cd misc/translation; perl translate update fi-FI)

2. Check existence of obsoleted strings
egrep "#~ msg" misc/translator/po/fi-FI-*

3. Check existence of backup files
ls misc/translator/po/fi-FI-*~

4. Reset to HEAD and clean

5. Apply the patch

6. Update again, check there are no more obsoleted
strings nor backup files

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12837 - barcode entry box out of alignment
Liz Rea [Wed, 27 Aug 2014 22:28:33 +0000 (10:28 +1200)]
Bug 12837 - barcode entry box out of alignment

To test:

Load up a circulation page, note that the middle of the barcode field doesn't line up with the Check-out button.
note that the date-select tickbox is also not aligned with the rest of the things on it's line

Apply the patch

Reload the page, verify that things are now in alignment.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10308 - local subjects can use authorities too
Robin Sheat [Wed, 22 May 2013 02:38:08 +0000 (14:38 +1200)]
Bug 10308 - local subjects can use authorities too

This adds entries for 690-699 to the authorities linker, so they get
linked up like everything else.

To Test:
 * make sure your framework doesn't have 690 set up to link to
   authorities (or it'll get linked as part of cataloguing.)
 * add a subject with some term to the 690$a field.
 * add an authority for TOPIC_TERM with the matching term.
 * make sure zebra is up to date.
 * run link_bibs_to_authorities.pl over your system.
 * check that the authority is now linked to your record.
 * repeat with the other 69x fields if you like.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested using 696a (PERSO_NAME). Works as described, no errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described, but linked authorities won't search
correctly when clicking on the link on the detail page,
as the 69x $9 is not indexed.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12674: GetMarcISSN should not return empty ISSN
Tomas Cohen Arazi [Tue, 29 Jul 2014 19:12:52 +0000 (16:12 -0300)]
Bug 12674: GetMarcISSN should not return empty ISSN

This patch makes GetMarcISSN test for empty subfield before pushing to the
result array.

To test:
- Run the regression test
=> FAILS for all MARC flavours
- Apply the patch
- Run the regression test
=> SUCCESS: tests pass
- Sign off

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12674: (regression tests) GetMarcISSN should not return empty ISSN
Tomas Cohen Arazi [Tue, 29 Jul 2014 19:09:18 +0000 (16:09 -0300)]
Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN

Proves GetMarcISSN returns empty ISSNs in the results array.

To reproduce:
 - Run $ prove -v t/db_dependent/Biblio.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: (RM followup) make DBIx::Class::Schema::Loader happy
Tomas Cohen Arazi [Mon, 1 Sep 2014 13:25:25 +0000 (10:25 -0300)]
Bug 6536: (RM followup) make DBIx::Class::Schema::Loader happy

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: DBRev 3.17.00.017
Tomas Cohen Arazi [Mon, 1 Sep 2014 13:11:34 +0000 (10:11 -0300)]
Bug 6536: DBRev 3.17.00.017

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Follow-up: Updating installer sql files for z3950servers (Part 2)
Marcel de Rooy [Thu, 28 Aug 2014 13:17:34 +0000 (15:17 +0200)]
Bug 6536: Follow-up: Updating installer sql files for z3950servers (Part 2)

This patch renames name to servername and type to servertype.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested all sql files by script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Follow-up: Updating web installer sql files for z3950servers
Marcel de Rooy [Thu, 28 Aug 2014 12:59:56 +0000 (14:59 +0200)]
Bug 6536: Follow-up: Updating web installer sql files for z3950servers

Removing icon, description and position from installer sql files.
Not all files contained them.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I have run all sql files on an empty table by script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: QA Follow-up for fixing a unit test under Perl 5.18
Tomas Cohen Arazi [Wed, 27 Aug 2014 16:24:18 +0000 (13:24 -0300)]
Bug 6536: QA Follow-up for fixing a unit test under Perl 5.18

The last test on the first series, fails randomly on Perl 5.18:
    not ok 12 - Third query makes no difference
    #   Failed test 'Third query makes no difference'
    #   at t/db_dependent/Breeding.t line 104.
    #          got: ''
    #     expected: '1'
    # Looks like you failed 1 test of 12.
not ok 1 - _build_query

This change makes tests pass. Please consider if this needs to be fixed
(i.e. sort order matters) or the test needs to be rewritten.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I agree with adding the sort. (The need for doing this in Perl 5.18 is another
topic.)

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: QA Follow-up for removing warnings from QA tools
Marcel de Rooy [Wed, 27 Aug 2014 14:56:11 +0000 (16:56 +0200)]
Bug 6536: QA Follow-up for removing warnings from QA tools

Resolved:
[1]  FAIL   C4/Breeding.pm
FAIL   critic ControlStructures::ProhibitMutatingListFunctions

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
No warnings anymore.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: QA Follow-up: Add some unit tests for Z3950Search in Breeding.pm
Marcel de Rooy [Wed, 27 Aug 2014 14:45:56 +0000 (16:45 +0200)]
Bug 6536: QA Follow-up: Add some unit tests for Z3950Search in Breeding.pm

This patch may serve as a starting point for more unit tests in this part
of the code.
In this patch most internal subroutines of Z3950Search are covered.
In the XSLT part we reuse a XSL template from the XSLT_Handler.t test.
It needed a little tweaking for namespaces. And added the indicators on
the 990 field.

Test plan:
Run both Breeding.t and XSLT_Handler.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: QA Follow-up for string changes referring to Z39.50
Marcel de Rooy [Mon, 25 Aug 2014 12:52:58 +0000 (14:52 +0200)]
Bug 6536: QA Follow-up for string changes referring to Z39.50

Z39.50 search now includes SRU targets.
This patch only touches strings referring to it.
No changes in behavior.
It replaces Z39.50 with Z39.50/SRU or external.

Deletes obsolete template z3950/searchresult.tt: not in use for some time.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: [QA Follow-up] Remove surrounding spaces in sru_fields
Marcel de Rooy [Thu, 21 Aug 2014 12:47:06 +0000 (14:47 +0200)]
Bug 6536: [QA Follow-up] Remove surrounding spaces in sru_fields

This patch only removes surrouding spaces at comma and equals-sign while
passing the options in sru_fields to the ZOOM object.

Test plan:
If you add spaces between options in sru_fields, searching should still work.
E.g. sru_fields= sru = get , sru_version = 1.1

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Add XSLT transformation on Z3950 search results
Marcel de Rooy [Thu, 10 Jul 2014 15:21:21 +0000 (17:21 +0200)]
Bug 6536: Add XSLT transformation on Z3950 search results

Use the stylesheets listed in field add_xslt of z3950servers to transform
search results of Z3950/SRU search.
Additionally, the template has been changed to make more error messages (or
warnings) visible when displaying results. Until now, error message were
shown in the results table and when connection errors occurred, no results
were displayed at all.

Test plan:
Create some stylesheets (or see the sample patch on bug 6536).
Add these stylesheets to some Z3950/SRU servers.
Do Z3950 search and verify the transformations.
Do a search with 2 targets; make one target fail (by manipulating its server
data). Do you see the connection error and the results for the other target?
Generate a XSLT error by modifying one stylesheet. Check search results. You
should see warnings.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Include SRU searching in Breeding.pm
Marcel de Rooy [Thu, 5 Jun 2014 12:20:37 +0000 (14:20 +0200)]
Bug 6536: Include SRU searching in Breeding.pm

This patch makes it possible to include SRU servers in Z3950 search.
It adjusts the Z3950Search routine in Breeding module.
It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search
and the associated scripts z3950search.pl in cataloguing and acqui.

Test plan:
Verify if a normal Z3950 search still works in cataloging/acqui.
Add a SRU target. (You could just use Koha's port 9998.)
Define sru_options like sru=get.
Use that target in a Z3950 search in cataloging and acqui. (Import.)
Test sru_fields translation by comparing search results between various
settings for some of the fields. For instance, leave title empty and
after that set it to the title field of your SRU target.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Adjustments for servername and servertype
Marcel de Rooy [Thu, 5 Jun 2014 06:55:09 +0000 (08:55 +0200)]
Bug 6536: Adjustments for servername and servertype

Replaces name by servername, type by servertype for running Z3950 search.
Limit search scripts to zed (z3950) servers until sru is supported.

Test plan:
Perform a Z3950 search in Cataloguing and Acquisition.
Verify that it still works as it did.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: SRU servers administration
Marcel de Rooy [Wed, 16 Jul 2014 14:38:57 +0000 (16:38 +0200)]
Bug 6536: SRU servers administration

This patch makes adjustments in admin/z3950servers in order to insert,
edit and delete SRU server records.

Test plan:
Add, edit, copy and delete SRU server.
Check if adding, editing, copying and deleting Z3950 servers still works.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Update DBIx schema of z3950servers for testing
Marcel de Rooy [Thu, 22 May 2014 08:08:42 +0000 (10:08 +0200)]
Bug 6536: Update DBIx schema of z3950servers for testing

This patch adjusts the DBIx schema file for z3950servers table.
This can be used for testing this set of patches.
When the report is pushed, the RM should update the DBIx schema.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Dbrev for Z3950 search improvements
Marcel de Rooy [Thu, 1 May 2014 13:07:12 +0000 (15:07 +0200)]
Bug 6536: Dbrev for Z3950 search improvements

Adjusts table z3950servers:
Drops unused columns icon, description and position.
Moves id column to first position.
Renames name to servername, and type to servertype. (This is not only more
clear but may eliminate some problems too with DBIx.)
Changes recordtype from varchar(45) to enumeration with two members. [The
upgrade replaces unknown record types with biblio, although it is very
unlikely to find such records.]
Adds SRU as servertype enumeration member. Removes opensearch, since it is
not used/supported. [The upgrade replaces unknown server types with zed
(z3950) (in exceptional cases).]
Adds new columns: sru_options, sru_fields, add_xslt.

Test plan:
Run database update via webinstaller.
Check your z3950servers table.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 6536: Add a form for SRU Field mapping
Marcel de Rooy [Thu, 22 May 2014 13:37:29 +0000 (15:37 +0200)]
Bug 6536: Add a form for SRU Field mapping

This form allows you to enter the match between the standard names of
the Z3950 search fields and the field names for a specific SRU server.
This patch only adds the form; it will be used in a subsequent patch.

Test plan:
Not needed, but you can call the form by constructing a URL like:
    cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2
You should see the form with title and author filled.
Note that you cannot save the information yet.

Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoRevert "Bug 12176 - Remove HTML from additem.pl"
Tomas Cohen Arazi [Wed, 27 Aug 2014 11:24:44 +0000 (08:24 -0300)]
Revert "Bug 12176 - Remove HTML from additem.pl"

This reverts commit 0033d287bad3344fad0861134d8dd3e03e56ed24.

I made a mistake pushing this one before the UTF-8 work.

10 years agoBug 12626: SQLHelper replacement - C4::Acquisition
Yohann Dufour [Tue, 22 Jul 2014 11:48:03 +0000 (13:48 +0200)]
Bug 12626: SQLHelper replacement - C4::Acquisition

With this patch, the subroutine NewOrder uses DBIx::Class instead of C4::SQLHelper.

Test plan:
1) Apply the patch

2) Execute the unit tests by launching :
prove t/db_dependent/Acquisition.t

3) The result has to be a success without error or warning :
t/db_dependent/Acquisition.t .. ok
All tests successful.
Files=1, Tests=79,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.80 cusr  0.09 csys =  1.94 CPU)
Result: PASS

4) Log in the koha intranet and create a new order in the acquition module

5) The creation has to be a success

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Test pass, new order created without problem, no koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested creating a new order from a subscription, no problems found.
Passes tests and QA script.

10 years agoBug 12325 - Marc and Card view in Z39.50 Results doesn't work properly in IE 8
David Cook [Fri, 30 May 2014 06:18:03 +0000 (16:18 +1000)]
Bug 12325 - Marc and Card view in Z39.50 Results doesn't work properly in IE 8

This patch removes an unnecessary and problematic "return true" which
causes conflicts with Greybox when clicking on "MARC" or "Card" in
the search results of a Z39.50 search. The result is that the user is
taken to the showmarc.pl page and cannot return to the results, which
makes Z39.50 searching pretty much unusable for IE 8 users.

This patch also cleans up the "inline links" display for the separate
Z39.50 search pages. The 'biblio' version now has inline links for LCCN,
and the 'authority' version now prevents inline links for the MARC
and Import cells.

_TEST PLAN_

1) Open Internet Explorer 8 (if you don't have IE 8, use whatever Internet
Explorer version you do have. You can use F12 developer tools to emulate it.)
2) Go to Cataloguing > New from Z39.50
3) Do a search that will get results

(N.B. if you're using IE9+, hit F12 in the pop-up and change to IE 8 mode)

4) Click on "MARC" or "Card".
5) Note that Greybox tries to open a pop-over, but instead follows the
link to showmarc.pl. (If you're on IE 8, you can't use "Back" to go
back to the search results. If you're using an emulated version, you
can.)

(If you're testing the inline links, click on the LCCN cell for a biblio
search (not that no inline links appear), or MARC and Import cells when
doing an authority search (not that inline links do appear). Look at
bug 10096 for authority z39.50 server details.)

6) Apply the patch

7) Repeat steps 1-5
8) Note that Greybox now appears correctly when clicking "MARC" and
"Card"

9) Note also that inline links now appear for LCCN cell for biblio
searches, and inline links no longer appear for MARC and Import
cells when doing authority searches.

10) Profit

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested for regressions in Firefox and Chromium, no problems found.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12176 - Remove HTML from additem.pl
Bernardo Gonzalez Kriegel [Sat, 3 May 2014 03:21:48 +0000 (00:21 -0300)]
Bug 12176 - Remove HTML from additem.pl

This patch removes HTML code from additem.pl

To test:
1. Chech no regressions on Add/Edit/Save items
2. Update translation files for a language,
check new string "Tag editor" on staff PO file
3. Check it pass xt/tt_valid.t

Rebased

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12717: Library no longer receiving Overdue email for patrons without email address
Jonathan Druart [Wed, 20 Aug 2014 11:26:49 +0000 (13:26 +0200)]
Bug 12717: Library no longer receiving Overdue email for patrons without email address

Bug 10832 changes the fallback behavior if a patron does not have email
address: a print notice is generated into the message_queue table.
But this can cause issue for some libraries. The script should sent an
email and (generated csv, html, text file) with the list of all unsent
notices.

Test plan:
1/ Add overdue to a patron without email address (or smsalertnumber)
2/ Check email in the overdue rules configuration (or sms)
3/ Launch the overdue_notices.pl cronjob
4/ Verify the message_queue contain a print notice AND an email notice
for the library

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This works as described and restores the old behaviour for now, with
the difference that you have a print notice generated and visible
in the patron account notices tab that will say 'pending'.

We will have to figure out how we can change the workflows nicely
to have only one script deal with print notice in the future.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402: (QA followup) amend unit tests
Tomas Cohen Arazi [Tue, 26 Aug 2014 15:56:08 +0000 (12:56 -0300)]
Bug 10402: (QA followup) amend unit tests

10 years ago10402: DBIx::Class schema update
Tomas Cohen Arazi [Tue, 26 Aug 2014 14:55:40 +0000 (11:55 -0300)]
10402: DBIx::Class schema update

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years ago10402: DBRev 3.17.00.016
Tomas Cohen Arazi [Tue, 26 Aug 2014 14:51:22 +0000 (11:51 -0300)]
10402: DBRev 3.17.00.016

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402: FIX conflicts in Letters.t
Jonathan Druart [Fri, 22 Aug 2014 11:08:07 +0000 (13:08 +0200)]
Bug 10402: FIX conflicts in Letters.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402 follow-up: choose contacts for claims
Jared Camins-Esakov [Thu, 12 Sep 2013 13:29:40 +0000 (09:29 -0400)]
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
    > prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402 [Template follow-up] Add multiple contacts for vendors
Owen Leonard [Thu, 1 Aug 2013 18:35:35 +0000 (14:35 -0400)]
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change "Add contact" to "Add another contact" in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402: Add ability to enter multiple contacts
Jared Camins-Esakov [Thu, 13 Jun 2013 15:31:21 +0000 (11:31 -0400)]
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
    > prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402: Move contacts to separate table
Jared Camins-Esakov [Wed, 12 Jun 2013 13:25:20 +0000 (09:25 -0400)]
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10402: Use an object for contacts
Jared Camins-Esakov [Fri, 7 Jun 2013 02:38:19 +0000 (22:38 -0400)]
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
    > prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12718 - Show extended patron attributes in the OPAC
Owen Leonard [Thu, 7 Aug 2014 18:18:50 +0000 (14:18 -0400)]
Bug 12718 - Show extended patron attributes in the OPAC

At some point the patron details page in the OPAC lost the display of
patron attributes. This patch returns the attributes to the update page.

To test, log in to the OPAC as a patron who has data in one or more
extended patron attributes. View the "your personal details" page
(opac-memberentry.pl):

- Confirm that the information displays correctly.
- Test with OPACPatronDetails both on and off.
- Test with patron who has no data in extended patron attributes.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Attributes only display when 'display in OPAC' is configured.
Attribute shows correct description, when authorised value is used.
Works as expected, updating is currently not yet possible.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12808: remove useless diags from t/db_dependent/Context.t
Tomas Cohen Arazi [Fri, 22 Aug 2014 15:26:54 +0000 (12:26 -0300)]
Bug 12808: remove useless diags from t/db_dependent/Context.t

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12222: members-update.tt has a giant hash variable
Bernardo Gonzalez Kriegel [Mon, 11 Aug 2014 03:23:52 +0000 (00:23 -0300)]
Bug 12222: members-update.tt has a giant hash variable

This patch changes that giant hash by a TT block
to find apropriate strings

To test:
1) Apply the patch
2) On opac log as some user and request some modifications
on personal data
3) On staff, reload main, will see a notice that a patron
has requested modification, clic on the link
4) All modified data must show with apropriate legends
for each db column, check for regressions
5) Update translation files for your preferred language, xx-YY
Check for new strings, e.g.
egrep "Alternate address" misc/translator/po/xx-YY*
You must find old and new instances
(old with #~ , in particular the hash one)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Works as advertised, strings are now translatable.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I like to have this fixed. I'd like it to use C4::Templates::GetColumnDefs
instead, but it belongs to another bug report I guess.

10 years agoBug 10212: DBRev 3.17.00.015
Tomas Cohen Arazi [Tue, 26 Aug 2014 13:18:02 +0000 (10:18 -0300)]
Bug 10212: DBRev 3.17.00.015

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: (qa followup) accordion collapsed by default
Tomas Cohen Arazi [Tue, 26 Aug 2014 12:57:49 +0000 (09:57 -0300)]
Bug 10212: (qa followup) accordion collapsed by default

By default, the accordion shows the first element (Acquisitions) which
is empty, and missleading. This patch collapses it by default.

The expected behaviour is that if we are rendering because the user saved
its changes, the modified accordion should be expanded, so I added a test
for the $panel variable.

Template comment added for future references about it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Use the update_or_create DBIC method when possible
Jonathan Druart [Tue, 22 Jul 2014 08:21:53 +0000 (10:21 +0200)]
Bug 10212: Use the update_or_create DBIC method when possible

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Move colvis files to the include file
Jonathan Druart [Fri, 18 Jul 2014 13:22:06 +0000 (15:22 +0200)]
Bug 10212: Move colvis files to the include file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

Implements the option to change the default columns that appear in
a table while giving the user the option to change the columns
individually for a session.

As an example, this feature is implemented for the currencies table.

Works well for all possible combinations in configuration.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Add Colvis to the about page
Jonathan Druart [Tue, 15 Jul 2014 16:07:35 +0000 (18:07 +0200)]
Bug 10212: Add Colvis to the about page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Columns configuration for tables - POC
Jonathan Druart [Mon, 7 Jul 2014 11:08:13 +0000 (13:08 +0200)]
Bug 10212: Columns configuration for tables - POC

This patch proves that this feature is useful with a concret use case.

Test plan:
1/ Execute the updatedatabase in order to create the new table.
2/ Take a look to the yml structure.
3/ Go on the admin currency page (admin/currency.pl).
4/ Check that you cannot hide the 2 first columns on the table.
5/ Try to hide/show columns.
6/ Go on the columns configuration page (admin/columns_settings.pl).
7/ Only the admin tab are filled with data. Check/uncheck checkboxes and
save.
8/ Go on the admin currency page and check that the behavior is what
you expected.
9/ Give me some feedback :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Columns configuration for tables - Add Colvis files
Jonathan Druart [Tue, 7 May 2013 12:07:49 +0000 (14:07 +0200)]
Bug 10212: Columns configuration for tables - Add Colvis files

This patch only adds Colvis js and css files.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Columns configuration for tables - Unit tests
Jonathan Druart [Fri, 10 Jan 2014 17:26:27 +0000 (18:26 +0100)]
Bug 10212: Columns configuration for tables - Unit tests

test plan:
Verify the
  prove t/db_dependent/ColumnsSettings.t
returns green.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Columns configuration for tables - DB changes
Jonathan Druart [Mon, 7 Jul 2014 11:16:08 +0000 (13:16 +0200)]
Bug 10212: Columns configuration for tables - DB changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10212: Columns configuration for tables
Jonathan Druart [Mon, 7 Jul 2014 08:28:21 +0000 (10:28 +0200)]
Bug 10212: Columns configuration for tables

This development introduces ColVis into Koha and provides a configuration
page for columns visibility.

ColVis is a plugin for DataTables. It allows to change the visibility of
the columns in the table.

* This development adds:
  - the js and css file for ColVis
  - a new DB table 'columns_settings'
  - a new template plugin 'ColumnsSettings'
  - a new package C4::Utils::DataTables::ColumnsSettings
  - a new admin page admin/columns_settings.pl

* How it works:
A yaml file is created (admin/columns_settings.yml) in order to take an
inventory of all tables where ColVis is implemented. This file is read
to create the list of modules, pages and tables in the configuration
page.
There are 3 possible keys in the yml:
 - is_hidden: default is 0
The column will be hidden.
 - cannot_be_toggled: default is 0.
ColVis will allow to hide/show the column.
 - cannot_be_modified: default is 0
Default values (in the yml) won't be modifiable.

When a user changes (or saves) the configuration for one module, all
columns are added to the DB table. The values in the DB get the upper hand
on the yaml values.

* Humm, strange?
It seems weird to have 2 storages for the same values. But I
think it will be easy to add an entry and maintain the yaml rather than
adding a new row (and new entry in updatedatabase script) in the DB.

* To go further: We can imagine that the configuration is saved for each
user (and not globally like it is made with this patch).

This patch cannot be tested as it, you need to apply the "POC" patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, more comments on last patch.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12744 - Set language in staff client should have 'Cancel' link
Marc Véron [Tue, 29 Jul 2014 13:27:08 +0000 (15:27 +0200)]
Bug 12744 - Set language in staff client should have 'Cancel' link

Test plan

Without patch:
Click on Library name in head of any staff client page anc choose 'Set library'
Result: Form 'Set library' with no 'Cancel' near 'Submit' button

With patch:
Form displays 'Cancel' link.
This link closes the form and takes you back to the page where you came from.

New patch without empty "onclick" attribute.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Nice patch, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12720: (QA followup) use API instead of plain SQL
Tomas Cohen Arazi [Sun, 24 Aug 2014 16:09:33 +0000 (13:09 -0300)]
Bug 12720: (QA followup) use API instead of plain SQL

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>