]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoCleanup cities.pl and .tmpl - major
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major

80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings.  Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code.  Etc.

TODO: Stop redirecting to the same page.  Instead get the correct data and show it
on THIS pass.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup previous patch - remove disused $opacstylesheet
Galen Charlton [Fri, 5 Jun 2009 22:06:16 +0000 (17:06 -0500)]
followup previous patch - remove disused $opacstylesheet

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPull the last OPAC-specific tmpl vars out of gettemplate.
Joe Atzberger [Thu, 4 Jun 2009 17:43:52 +0000 (12:43 -0500)]
Pull the last OPAC-specific tmpl vars out of gettemplate.

These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3289 - Fixed bad conditional check that made news items not show up until the...
Liz Rea [Thu, 4 Jun 2009 16:22:00 +0000 (11:22 -0500)]
Bug 3289 - Fixed bad conditional check that made news items not show up until the day after pubdate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding another developer to the history
Chris Cormack [Wed, 3 Jun 2009 22:18:26 +0000 (10:18 +1200)]
Adding another developer to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2624: Fix for non-persistent check boxes in check-in screen.
Garry Collum [Wed, 3 Jun 2009 21:37:01 +0000 (17:37 -0400)]
Bug 2624: Fix for non-persistent check boxes in check-in screen.

Found this bug when playing with AutomaticItemReturn. The "Forgive overdue charges" and "Dropbox mode" would lose their value the item was transfered (if automatic transfer was off), caught a hold, or caught a hold at another location.
This patch does not completely do away with the problem.  If an item is checked-in in simple mode, then one of the forms mentioned above opens, then the user checks one of the selection boxes, the value is not retained.  Javasript would have to be added to transfer the value to the confirmation form when the checkbox is clicked.

This patch also cleans up a few minor XHTML errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3291) fix blue.css to bold fields and tags in marc view
Nahuel ANGELINETTI [Thu, 4 Jun 2009 10:26:10 +0000 (12:26 +0200)]
(bug #3291) fix blue.css to bold fields and tags in marc view

Add a css property, and fix a class, to show fields and subfields as bold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor POD update - copied section doesn't apply to other function
Joe Atzberger [Wed, 3 Jun 2009 16:26:26 +0000 (11:26 -0500)]
Minor POD update - copied section doesn't apply to other function

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadditional SCO template fixes
Galen Charlton [Wed, 3 Jun 2009 19:29:39 +0000 (14:29 -0500)]
additional SCO template fixes

* removed sco.js, which is no longer used
* fixed XHTML warnings in sco-main.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix minor warning issues in SCO
Galen Charlton [Wed, 3 Jun 2009 19:12:05 +0000 (14:12 -0500)]
fix minor warning issues in SCO

* test for NO_MORE_RENEWALS now does expect
  that hash key will always exist
* removed unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup SCO - OPAC self checkout
Joe Atzberger [Wed, 3 Jun 2009 14:31:46 +0000 (09:31 -0500)]
Cleanup SCO - OPAC self checkout

~ vestigial broken scripts and templates removed
~ meaningless dependencies removed
~ Focus handling issues resolved for cross-browsers
~ Timeout only invoked for non-first screen.  This keeps the refresh from
flooding the logs continuously for no purpose.
~ two halves of "validuser" conditional linked in TMPL
~ elsif's used for $op conditionals

The focus should now appear on the "Return to Account Summary" button during errors.
The user can scan anything (w/ carriage return) and get back to the first screen.
Also, special functionality is added for the magic barcode "__KOHA_NEW_CIRC__".
This effectively ends the patron session and logs them out so the next patron can begin.
The purpose is for patrons to avoid having to use a keyboard at all, if libraries
print and have this special barcode available for patrons at the SCO station.

Enhancement was requested by Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3268: Adds the ability to edit the description of a holiday.
Garry Collum [Sat, 30 May 2009 22:30:13 +0000 (18:30 -0400)]
Bug 3268: Adds the ability to edit the description of a holiday.

Adds another radio button to the edit holiday form. This is a partial fix, because you cannot make an edit to a single holiday for multiple branches.

Also fixed a small XHTML error and a wording error from my previous patch on holidays.tmpl (bug 3274).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a new developer to the history documentation
Chris Cormack [Fri, 29 May 2009 21:02:39 +0000 (09:02 +1200)]
Adding a new developer to the history documentation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3274: Patch to fix Holiday Exceptions radio button.
Garry Collum [Sat, 30 May 2009 16:29:11 +0000 (12:29 -0400)]
Bug 3274: Patch to fix Holiday Exceptions radio button.

Holiday exceptions only make since for repeatable holidays. Javascript showHoliday function was looking for a 'showTitle' id that no longer existed in the showHolidau form.  Added a hidden input field because of the possibility of re-adding the title text input field at a later time.
Added code to determine whether a holiday as an exception or not, so that the "Delete this program" radio button changes to "Delete this exception" because that is the program's true functionality if the holiday is an exception.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl
Garry Collum [Sun, 31 May 2009 02:27:33 +0000 (22:27 -0400)]
Bug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3276: Minor XHTML error in opac-passwd.tmpl
Garry Collum [Sun, 31 May 2009 11:02:29 +0000 (07:02 -0400)]
Bug 3276: Minor XHTML error in opac-passwd.tmpl

Fixes a reference to a non-existent id.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow zebra search for Lexile numbers in field 521$a
savitra.sirohi [Wed, 3 Jun 2009 03:55:41 +0000 (09:25 +0530)]
Allow zebra search for Lexile numbers in field 521$a

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl
Garry Collum [Tue, 2 Jun 2009 22:44:31 +0000 (18:44 -0400)]
Bug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3170 followup
Galen Charlton [Tue, 2 Jun 2009 20:05:05 +0000 (15:05 -0500)]
bug 3170 followup

* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
  regardless of whether a new one is created
  or an existing one modified

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3170) do not check fields < 010
Nahuel ANGELINETTI [Fri, 29 May 2009 10:32:46 +0000 (12:32 +0200)]
(bug #3170) do not check fields < 010

This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3170) check if mandatory fields are not empty
Nahuel ANGELINETTI [Thu, 30 Apr 2009 13:09:36 +0000 (15:09 +0200)]
(bug #3170) check if mandatory fields are not empty

This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3271 : Added tooltip when adding to a list with no item selected (same as for...
Matthias Meusburger [Fri, 29 May 2009 12:43:55 +0000 (14:43 +0200)]
bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3272: preserve formatting when editing help
Galen Charlton [Fri, 29 May 2009 13:37:14 +0000 (08:37 -0500)]
bug 3272: preserve formatting when editing help

Tweak the TinyMCE settings so that more of the original
whitespace and HTML is preserved when editing help, making
help patches easier to understand.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This...
Zeno Tajoli [Fri, 29 May 2009 08:28:25 +0000 (10:28 +0200)]
Fix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This second patch for the same bug is only for white spaces and newlines

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3252: Fixes XHTML on catalog statistic form page.
Garry Collum [Fri, 29 May 2009 02:30:24 +0000 (22:30 -0400)]
Bug 3252: Fixes XHTML on catalog statistic form page.

Several form input fields were within a <table> element, but not in a <td>.  This patch pulls the input fields out of the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding 2 new developers to the history
Chris Cormack [Fri, 29 May 2009 02:24:15 +0000 (14:24 +1200)]
Adding 2 new developers to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix markup error in unimarc_field_128a.tmpl
Galen Charlton [Fri, 29 May 2009 01:51:23 +0000 (20:51 -0500)]
fix markup error in unimarc_field_128a.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix markup problems in label-edit-layout.tmpl
Galen Charlton [Fri, 29 May 2009 01:44:44 +0000 (20:44 -0500)]
fix markup problems in label-edit-layout.tmpl

* couple constructs that caused translation bugs
* now valid XHTML

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix minor translation bugs in two OPAC templates
Galen Charlton [Fri, 8 May 2009 21:56:12 +0000 (16:56 -0500)]
fix minor translation bugs in two OPAC templates

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2884: followup patch
Galen Charlton [Fri, 29 May 2009 01:13:21 +0000 (20:13 -0500)]
bug 2884: followup patch

[1] Restore behavior of the input field for the library
    code; when adding a new library, it should be a
    a text box; when editing an existing library,
    should be a hidden input.
[2] When user attempts to add a new library with the same
    code as that of an existing library, populate the form
    with what the user entered for the new library, not the
    values from the existing library.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #2884: Add error management to branches
Paul Poulain [Thu, 28 May 2009 16:32:16 +0000 (18:32 +0200)]
fix for #2884: Add error management to branches

While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)
Galen Charlton [Thu, 28 May 2009 12:51:12 +0000 (07:51 -0500)]
bug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)

Also added index on authorised_values.lib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Galen Charlton [Fri, 13 Feb 2009 15:39:38 +0000 (09:39 -0600)]
bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes

Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix permissions error introduced in prior patch
Galen Charlton [Thu, 28 May 2009 23:47:01 +0000 (18:47 -0500)]
fix permissions error introduced in prior patch

15 years agoremoving comments
Paul Poulain [Thu, 28 May 2009 16:32:21 +0000 (18:32 +0200)]
removing comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing API of ModBiblioMarc
Paul Poulain [Thu, 28 May 2009 16:32:19 +0000 (18:32 +0200)]
Fixing API of ModBiblioMarc

no need to retrieve $biblionumber, as we already know it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(not new_acq related) smallfix to avoid a die in case of an invalid record
Paul Poulain [Thu, 28 May 2009 16:32:24 +0000 (18:32 +0200)]
(not new_acq related) smallfix to avoid a die in case of an invalid record

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremoving useless line (use Data::Dumper)
Paul Poulain [Thu, 28 May 2009 16:32:27 +0000 (18:32 +0200)]
removing useless line (use Data::Dumper)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for 2997 : superlibrarian's ability to edit item/patron home branch affected...
Paul Poulain [Thu, 28 May 2009 16:32:14 +0000 (18:32 +0200)]
fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected

Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc
Michael Hafen [Thu, 28 May 2009 18:36:22 +0000 (12:36 -0600)]
bugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc

There used to be two TMPL_IF's here, now there's just one.  Missed removing
the second /TMPL_IF though.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Zeno Tajoli [Thu, 28 May 2009 12:45:20 +0000 (14:45 +0200)]
Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Garry Collum [Thu, 28 May 2009 01:48:12 +0000 (21:48 -0400)]
Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.

Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow option to preserve Extended Attributes on patron import update.
Joe Atzberger [Wed, 27 May 2009 18:38:58 +0000 (13:38 -0500)]
Allow option to preserve Extended Attributes on patron import update.

Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.

Several functions added to Members::Attributes with corresponding tests.

[ LL ref. 342 ]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2641, 3263: minor fixes to labeled MARC view
Galen Charlton [Wed, 27 May 2009 18:10:47 +0000 (13:10 -0500)]
bug 2641, 3263: minor fixes to labeled MARC view

* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2642, 3263: new MARC display system preferences (DB rev 036)
Galen Charlton [Wed, 27 May 2009 18:10:46 +0000 (13:10 -0500)]
bug 2642, 3263: new MARC display system preferences (DB rev 036)

* Added definitions of the new display sysprefs:

  viewISBD - Allow display of ISBD view of bibiographic records
  viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
  viewMARC - viewMARC  Allow display of MARC view of bibiographic records

* Adjusted IntranetBiblioDefaultView
  * made type choice (fixing bug 1933)
  * added better description for English
  * added labeled_marc option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: fixed ersatz references to AmazonContent
Galen Charlton [Wed, 27 May 2009 18:10:45 +0000 (13:10 -0500)]
bug 3263: fixed ersatz references to AmazonContent

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2641, 3263: Staff Search Results Interface Changes
Rick Welykochy [Wed, 27 May 2009 18:10:44 +0000 (13:10 -0500)]
bug 2641, 3263: Staff Search Results Interface Changes

New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1933: started work fixing IntranetBiblioDefaultView syspref
Galen Charlton [Wed, 27 May 2009 18:10:43 +0000 (13:10 -0500)]
bug 1933: started work fixing IntranetBiblioDefaultView syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: Staff Search Results Interface Changes
Galen Charlton [Wed, 27 May 2009 18:10:42 +0000 (13:10 -0500)]
bug 3263: Staff Search Results Interface Changes

Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix DB rev for adding location to subscriptions: 035
Galen Charlton [Wed, 27 May 2009 14:57:23 +0000 (09:57 -0500)]
fix DB rev for adding location to subscriptions: 035

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agovarious improvements to subscription editing
Galen Charlton [Wed, 27 May 2009 14:57:24 +0000 (09:57 -0500)]
various improvements to subscription editing

* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding and managing location in subscription
Henri-Damien LAURENT [Wed, 27 May 2009 14:57:22 +0000 (09:57 -0500)]
Adding and managing location in subscription

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3244: Support for multiple PAC interfaces.
Ryan Higgins [Wed, 27 May 2009 15:31:47 +0000 (10:31 -0500)]
bug 3244: Support for multiple PAC interfaces.

Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Chris Nighswonger [Wed, 27 May 2009 15:30:14 +0000 (11:30 -0400)]
Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers

Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSmall documentation improvement for C4::Service
Jesse Weaver [Wed, 27 May 2009 14:31:29 +0000 (08:31 -0600)]
Small documentation improvement for C4::Service

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix uninitialized value warnings during COinS generation
Galen Charlton [Wed, 27 May 2009 14:01:00 +0000 (09:01 -0500)]
fix uninitialized value warnings during COinS generation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated INSTALL.opensuse file to wiki version
Ricardo Dias Marques [Tue, 26 May 2009 22:42:34 +0000 (23:42 +0100)]
Updated INSTALL.opensuse file to wiki version

Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:

Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0

This commit is supposed to be applied to the 3.0.x branch.

Changelog:

– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoQuick fix to catch some instances of XSS vulnerability, there will be more probably...
Chris Cormack [Fri, 22 May 2009 20:05:56 +0000 (08:05 +1200)]
Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circulation.pl
Joe Atzberger [Tue, 26 May 2009 21:41:01 +0000 (16:41 -0500)]
Cleanup circulation.pl

Removed many unused variables.
Switched to elsif where appropriate.
Cleaned up some whitespace.
Corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup waitingreserves.pl and .tmpl
Joe Atzberger [Tue, 26 May 2009 21:41:03 +0000 (16:41 -0500)]
Cleanup waitingreserves.pl and .tmpl

Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3169 - Google jacket display, remove preview image on result page
Frédéric Demians [Sat, 23 May 2009 06:43:01 +0000 (08:43 +0200)]
Bug 3169 - Google jacket display, remove preview image on result page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1687: Can't assign holidays to all branches at once.
Garry Collum [Sun, 24 May 2009 16:10:23 +0000 (12:10 -0400)]
Bug 1687: Can't assign holidays to all branches at once.

This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Garry Collum [Mon, 25 May 2009 00:51:18 +0000 (20:51 -0400)]
Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.

Added code to detect if the syspref for item-level_itypes is being used.  The report now correctly returns data based on the syspref.  There are some pre-existing XML errors with the FORM view of catalogue_stats.pl.  I'll send a subsequent patch to deal with these.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3219: handle variation in Amazon responses
Galen Charlton [Tue, 26 May 2009 19:20:03 +0000 (14:20 -0500)]
bug 3219: handle variation in Amazon responses

An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3261: Fix for invalid XHTML on Personal Details page.
Garry Collum [Wed, 27 May 2009 01:32:42 +0000 (21:32 -0400)]
Bug 3261: Fix for invalid XHTML on Personal Details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup view_holdsqueue.pl and .tmpl (minor)
Joe Atzberger [Fri, 22 May 2009 21:45:51 +0000 (16:45 -0500)]
Cleanup view_holdsqueue.pl and .tmpl (minor)

Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agominor fix - don't declare variables in a conditional
Galen Charlton [Wed, 27 May 2009 11:53:17 +0000 (06:53 -0500)]
minor fix - don't declare variables in a conditional

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup branchtransfers
Joe Atzberger [Fri, 22 May 2009 20:31:07 +0000 (15:31 -0500)]
Cleanup branchtransfers

Remove unused sub and variables.
Convert to using GetBranchesLoop instead of local code.
Use elsif where appropriate.
Added fallback values and enabled warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup transferstoreceive.pl and .tmpl
Joe Atzberger [Fri, 22 May 2009 19:35:35 +0000 (14:35 -0500)]
Cleanup transferstoreceive.pl and .tmpl

Removed unused variables.  Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field.  Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.

Mostly whitespace edits in template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3241: Place hold button appears on results page if opacuserlogin is off
Garry Collum [Sat, 23 May 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3241: Place hold button appears on results page if opacuserlogin is off

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixed capitalization and standardized statements.
Nicole Engard [Sun, 24 May 2009 01:35:46 +0000 (20:35 -0500)]
Fixed capitalization and standardized statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3253: Fixes XHTML for the Patron Statistics form page.
Garry Collum [Mon, 25 May 2009 13:24:44 +0000 (09:24 -0400)]
Bug 3253: Fixes XHTML for the Patron Statistics form page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3254: Fixes the Catalog by Item Type report XHTML.
Garry Collum [Mon, 25 May 2009 13:49:01 +0000 (09:49 -0400)]
Bug 3254: Fixes the Catalog by Item Type report XHTML.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 3233, tabs on detail page change when clicking on MARC view
Owen Leonard [Fri, 22 May 2009 17:52:37 +0000 (12:52 -0500)]
Fix for Bug 3233, tabs on detail page change when clicking on MARC view

This change adds a check for the XSLTDetailsDisplay preference since different MARC view tabs display on the detail page if that pref is on or off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circ/overdue.pl
Joe Atzberger [Fri, 22 May 2009 18:37:49 +0000 (13:37 -0500)]
Cleanup circ/overdue.pl

This also fixes a deficiency with overdue.tmpl not retaining the
user's selection of sort order when displaying results.
Removed 9 unused variables.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix DBrev messages in updatedatabase.pl
Galen Charlton [Fri, 22 May 2009 18:35:39 +0000 (13:35 -0500)]
fix DBrev messages in updatedatabase.pl

021 - added change description
034 - corrected change description

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agocorrected POD for NewSubscription()
Galen Charlton [Thu, 21 May 2009 17:15:43 +0000 (12:15 -0500)]
corrected POD for NewSubscription()

Merge serials display and grace period
changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3020) forgotten cronjob
Nahuel ANGELINETTI [Mon, 9 Mar 2009 16:03:02 +0000 (17:03 +0100)]
(bug #3020) forgotten cronjob

this is the cronjob needed for grace period.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3020) add a grace period to subscriptions
Nahuel ANGELINETTI [Mon, 9 Mar 2009 15:55:17 +0000 (16:55 +0100)]
(bug #3020) add a grace period to subscriptions

This patch modify the database to have a grace period which can be set. And is used to create automatically new waited issues with a
cronjob(which is in this patch), and set old issues to "late" status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: fix display of message queue
Galen Charlton [Wed, 20 May 2009 16:35:58 +0000 (11:35 -0500)]
bug 3222: fix display of message queue

If no messages have been sent to the patron, display
a notice that that effect in the staff patron messaging
tab rather than just a blank page.

[LL bug 452]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: fix Safari display of patron category preferences
Galen Charlton [Wed, 20 May 2009 16:35:57 +0000 (11:35 -0500)]
bug 3222: fix Safari display of patron category preferences

[LL bug 454]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: tweak sending of hold filled notification
Galen Charlton [Wed, 20 May 2009 16:35:56 +0000 (11:35 -0500)]
bug 3222: tweak sending of hold filled notification

Send a hold filled notification only when the item
is (assumed) to enter the hold shelf, i.e., when
the request status (reserves.found) is set to 'W'.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: moved messaging preference editing
Galen Charlton [Wed, 20 May 2009 16:35:55 +0000 (11:35 -0500)]
bug 3222: moved messaging preference editing

The display and editing of messaging preferences
for a patron have been moved as follows:

* the prefs for a patron are now displayed on the
  patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
  record, not on the messaging tab.

The messaging tab now contains only the list of
messages that have been or will be sent to the patron.

When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron.  If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.

Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.

Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: set messaging preferences during patron import
Galen Charlton [Wed, 20 May 2009 16:35:54 +0000 (11:35 -0500)]
bug 3222: set messaging preferences during patron import

If the EnhancedMessagingPreferences option is ON, when
creating a new patron record via the patron import, set
the default messaging preferences to the applicable values
the default preferences for the patron category.

Messaging preferences are currently changed only when
*adding* a patron record via the import; if the import
updates an existing record, the patron's existing
preferences are not changed.

API changes:

SetMessagingPreferencesFromDefaults() is a new function
in C4::Members::Messaging to unconditionally replace
the current messaging preferences of a patron with the
default preferences from a specified patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: messaging preferences for patron categories
Galen Charlton [Wed, 20 May 2009 16:35:53 +0000 (11:35 -0500)]
bug 3222: messaging preferences for patron categories

Add the ability to set the default circulation messages preferences
for a patron category.  When the EnhancedMessagingPreferences
syspref is ON, the administrator will be able to define
default patron messaging preferences for a patron category.  When
a new patron record is created (either manually or via a patron
import), the new patron's preferences will be copied from the default
for that patron's category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: new module to handle messaging preferences form
Galen Charlton [Wed, 20 May 2009 16:35:52 +0000 (11:35 -0500)]
bug 3222: new module to handle messaging preferences form

Define and use a new module, C4::Form::MessagingPreferences,
to handle displaying and processing the messaging preferences
form.  This change reduces code duplication between OPAC
and staff.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: changes to messaging preferences form
Galen Charlton [Wed, 20 May 2009 16:35:51 +0000 (11:35 -0500)]
bug 3222: changes to messaging preferences form

Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: C4::Members::Messaging changes
Galen Charlton [Wed, 20 May 2009 16:35:50 +0000 (11:35 -0500)]
bug 3222: C4::Members::Messaging changes

Updated GetMessagingPreferences() and SetMessagingPreferences()
in this module to allow a categorycode to be passed
instead of a borrowernumber, permitting default preferences
for a patron category to be stored.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: database changes for messaging preferences (DB rev 033)
Galen Charlton [Wed, 20 May 2009 16:35:49 +0000 (11:35 -0500)]
bug 3222: database changes for messaging preferences (DB rev 033)

This patch modifies the database for the messaging
preferences enhancement <http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_defaultmessagingsettings>
as follows:

* adds a categorycode column to borrower_message_preferences

This allows a set of messaging preferences to be linked
to a patron category

* allow the borrowernumber column to be null

This allows a messaging preference set to be linked
*only* to a patron category.  If MySQL had check
constraints, I would add one so that exactly
one of borrowernumber and categorycode in a row in
borrower_message_preferences could be NULL.

* add a FK constraint from borrower_message_preferences.categorycode
to categories; if you delete a patron category, any default preferences
associated with it will be automatically deleted.

The messaging preference enhancement was sponsored by the Northeast
Kansas Library System (NEKLS).

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3243: fix adding patron after resorting in patron label search
Galen Charlton [Fri, 22 May 2009 14:18:37 +0000 (09:18 -0500)]
bug 3243: fix adding patron after resorting in patron label search

Also needed to keep track of the batch type.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3243: pcard-members-search fails to add patrons to batch after using some links
MJ Ray [Thu, 21 May 2009 14:27:19 +0000 (15:27 +0100)]
bug 3243: pcard-members-search fails to add patrons to batch after using some links

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd patron card member searching by category code
MJ Ray [Fri, 22 May 2009 13:53:13 +0000 (14:53 +0100)]
Add patron card member searching by category code

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3239 - Content-Script-Type and Content-Style-Type
Joe Atzberger [Fri, 22 May 2009 01:37:46 +0000 (20:37 -0500)]
Bug 3239 - Content-Script-Type and Content-Style-Type

This adds headers to define the default script and style languages.
Please note that this output isn't 100% canonical from CGI yet, but
that is due to a bug in CGI:
  http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3243

So either CGI will perfect it's output, or we can switch to using
HTTP::Headers.  The latter may be desirable anyway, since then we
would not need a CGI $query argument at all.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to previous patch - don't use TMPL_IF EXPR
Galen Charlton [Fri, 22 May 2009 12:41:22 +0000 (07:41 -0500)]
followup to previous patch - don't use TMPL_IF EXPR

Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:

non-initialized variable new_subfield

For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago =?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure
Andrei V. Toutoukine [Fri, 22 May 2009 11:53:29 +0000 (15:53 +0400)]
 =?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2001, 2432: improve unAPI implementation
Galen Charlton [Fri, 22 May 2009 00:10:50 +0000 (19:10 -0500)]
bug 2001, 2432: improve unAPI implementation

Improves Koha's unAPI support as follows:

* The implementation no longer depends on there being
  an accessible Zebra or SRW server.  Instead, responses
  are created by running the bib MARCXML through local
  stylesheets.
* unAPI now works for all bibs, not just ones that have
  an ISBN.  The ID format is changed from koha:isbn:ISBN
  to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
  http://validator.unapi.info/ .
* MODS3 support now works correctly.  As a consequence, this
  patch fixes bug 2432 (Zotero support when using the XSLT
  OPAC stylesheets).

TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circ/billing.pl
Joe Atzberger [Fri, 22 May 2009 01:37:49 +0000 (20:37 -0500)]
Cleanup circ/billing.pl

Remove ton of unused variables.
Remove wrong use of BiblioDefaultView on INTRANET side.
Consolidate failover values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circ/stats.pl
Joe Atzberger [Fri, 22 May 2009 01:37:47 +0000 (20:37 -0500)]
Cleanup circ/stats.pl

Use elsif and else.  FIXME's added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup C4/Stats.pm
Joe Atzberger [Fri, 22 May 2009 01:37:48 +0000 (20:37 -0500)]
Cleanup C4/Stats.pm

Use C4::Debug.  Remove $sth->finish and an unconditional warn.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a new committer to the history docs
Chris Cormack [Fri, 22 May 2009 00:11:10 +0000 (12:11 +1200)]
Adding a new committer to the history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>