XHTML corrections: guided reports

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

XHTML corrections: tools and reports

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

XHTML corrections for bib display and item add

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't sort @INC when displaying on about page

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

display path to Perl interpreter on about page

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

display Perl @INC on about page

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add a required Debian package & fix a wrong character encoding

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing zebraqueue daemon for delete operation part two

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes to indexing process for deleted records

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Zconn not creating a new connection when zebra goes away and comes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

completed XHTML fixes for addbiblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix XHTML validation errors in addbiblio.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

restore tabbing function in MARC bib editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added back use of C4::Charset

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed XHTML validation error

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

OPAC: display bib record URLs even if bib has no items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

FRBR: configure PazPar2 during installation

Also added koha-pazpar2-ctl.sh to start and stop
PazPar2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

FRBR: fixed paging through grouped results

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

FRBR: added OPAC search result grouping option

Because this feature is experimental, the syspref will
not be added to the list just yet.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

FRBR: added work-author to PazPar2 search defs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

PazPar2 FRBRize - adjusted UT and author keys

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more experimental work on grouping with pazpar2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added 440* and 490* 'series' indexes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

now fetching missing MARCSERIES/440 values too.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfixing inventory

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moving fr installer to fr-FR

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

INNER JOIN was too much restrictive for migrated libraries.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUG FIX : detailed page for supplier failed to get supplier information

GetSupplier was split into two functions.
Using GetSupplierFromId

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying Sort Authorised values if linked to authorisedvalue list.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

ordering branches by branchcodes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

</div> were missing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

using Warn and not print for debugging purpose

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

ordering branches by branchcodes on Auth page.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

overduenotices-csv from 2.2 + DL file from overdue.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

overdues list, adding links to biblio & patron

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding missing lcn index for NoZebra (in UNIMARC)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

HomeOrHoldingBranch syspref in french

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

switching home and holdingbranch (rewritten)

This is an improvement of a patch that has previously been rejected: I wanted to display holdingbranch, kados prefer homebranch
(and in fact it depends on the library choice...)
now, the library can choose, thanks to HomeOrHoldingBranch syspref.

Note that I have changed the description of the syspref to reflect this new use

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moved use of C4::Heading to avoid symbol export problem

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: added LinkBibHeadingsToAuthorities

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changed behavior of barcode.pl plugin to generate barcode onClick of the ... button

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

952 $y was marked as 'hidden' for supplemental frameworks

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1372: count MARC records correctly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added StripNonXmlChars to C4::Charset

Added invocations of StripNonXmlChars to uses
of new_from_xml() that involve records
saved to Koha fields via MARC::Record->as_xml();
for batch jobs that work on MARC XML files
coming from external sources, StripNonXmlChars
should not necessarily be used, as it may
be better to reject a file or record if it
contains that kind of encoding error.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

keep biblioitems.cn_sort in sync with MARC record

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

synching opac search with staff search

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing a bug where the query cgi was loaded twice for re-sort forms

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

handling multiple languages gracefully in sysprefs, allow the user to enable specific languages (and language groups)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding translators for Amaric

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a media=print stylesheet and removing menus from printing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Members.pm - make sure we don't return empty refs (is firstname fallback really needed?)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

replacing ' by " in javascript translatable strings

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Allow stage_biblios_file to take matcher id as parameter.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change homebranch to branch for advanced search.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: new batch job to link bibs to authorities

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authority headings search: remove CCL metacharacters

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moved use of C4::Heading to avoid symbol export problem

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: added LinkBibHeadingsToAuthorities

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

FRBR: OPAC template for displaying grouped results

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added grouplabel class for FRBR group labels

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

experiment: use PazPar2 to group related works

The approach is to use PazPar2 to search just one
target, the biblio Zebra database.  The results
of each set are merged by PazPar2 to generate a
hitlist that combines related bibs together; as an
example, if a library has the first Harry Potter
book in three languages and an audiobook format,
the hitlist should ideally return one result
for the work that includes links to the individual
bibs.

The new module C4::Search::PazPar2 implements a
simple client for PazPar2's XML-over-HTTP API.  It is
designed to be generic, and thus may end up getting
moved out of Koha to become a stand-alone CPAN module.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting biblio view link options, other CSS tweaks; Adding record export widget from dev_week (seems to work?)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Writing the cart button to the DOM with js so that non-js users don't see it

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Re-marking basket count with spans to avoid validation errors

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes for display of cart contents number, other minor markup corrections

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Styling cart and list buttons with icons, styling search 'Go' button similarly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cart and lists icon placement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Trying to get float correct for cart and lists button

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: limit by heading type during matching

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities - new module - C4::Heading

Objects of type C4::Heading represent
headings and are (currently) initialized
from bib MARC::Field objects.  A C4::Heading
has the ability via SimpleSearch to locate
the authority records that are either authorizing
the heading itself or contained more preferred
terms for the heading via See links.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities -- added CCL indexes for heading matching

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

quell warnings for SimpleSearch under 'use warnings'

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities indexing: qualify indexes with ":w"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities indexing - MAJOR changes

For DOM indexing, added index_matching_heading option
to create indexes for matching an entire authority
heading -- the index works by indexing a heading
such

150 $aCars$xElectric$zEngland$vScience fiction

as something like

"cars generalsubdiv electric geographicsubdiv england
formsubdiv science fiction"

Also started adjust names of some indexes to conform
to languaged used in the MARC21 and UNIMARC standards, e.g.,

"See" => "See-from"
"See-also" => "See-also-from"
"Conference-name-heading" => "Meeting-name-heading"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities - enabled DOM indexing

All new authority features will be based on the DOM indexing.

To update an existing installation, do the following:

[1] run perl Makefile.PL
[2] make
[3] make update_zebra_conf
[4] copy the new koha-conf.xml to $KOHA_CONF

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding 'more_subfields_xml' column to deleteditems table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

SMS - widespread cleanup and moving code away from Cyprus/Turkey-specific implementation. Much more needed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Makefile.PL - trivial perldoc correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes bug #1808

  OPAC:   $8 - Koha collection, decoded with ccode authorised
          values
  Staff:  $c - Shelving location

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

templates - HTML validation tweaks, FIXME's added

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Context.pm - file size test (-s) is subset of file exists test (-e), so testing both is same as testing -s.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

masthead.inc - several validation fixes (no div inside <a>, unpaired closing tags)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac.css - button background fix for input.icon

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

shelves - corrections and HTML validation changes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

charset: fixed bug that prevented ISO-5426 conversion

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Modified viewlog.pl to discern where it was called from and display the appropriate menu.

If viewlog.pl is called from the circulation menu, then the circulation menu is displayed.
If viewlog.pl is called otherwise, the tools menu is displayed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add MARC21 to USMARC label

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More fixes for patron images

Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on picture-upload.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fixing : Could not add new undefined tag if searchfield>0

For instance, search for tag 290
cannot find.
Click on addTag
Save
Then wouldnot add tag 290 because used UPDATE.
Now, if tag is not found then Add tag is done.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Second installment on Patron Images fixes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

temp bugfix -- restore file upload functionality

CGI->new() should not be used in any C4 module -
it has a side-effect that breaks the AJAX
file upload script.  Specifically, any file upload
field is slurped when a new CGI object is created, and
is not available to a second object created by CGI->new().

Consequently, C4::Debug should not be instantiating
a CGI object in its BEGIN block.  It can use other CGI::* modules
to parse QUERY_STRING to get the value of the debug
parameter (note that this means that the debug param
can be reliably set only in a GET, not as part of a
form submission).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT - refactor MARC character set handling

* IsStringUTF8ish - determine if scalar contains a string in UTF8
* MarcToUTF8Record - convert MARC blob or MARC::Record to UTF8
* SetMarcUnicodeFlag - set appropriate MARC21 or UNIMARC field to
  indicate that record is in UTF-8.

Design points of this module include:

* No dependencies on other C4 modules, making it easier to add
  more test cases
* All character conversion code in one place
* Single entry point for doing a character conversion on a
  MARC record
* Capture of errors and warnings produced by Text::Iconv
  and MARC::Charset
* Start of support for guessing the source character set of
  a MARC record.

Several functions were moved from other scripts
or modules to C4::Charset:

* C4::Koha->FixEncoding (expanded and renamed
  MarcToUTF8Record)
* C4::Koha->char_decode5426
* fMARC8ToUTF8 from bulkmarcimport.pl (renamed
  _marc_marc8_to_utf8)

Several batch jobs were adjusted to use MarcToUTF8Record instead of
FixEncoding.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup correction, formatting for translator

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting DEBUG var

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for Bug 1618: First Installment

This corrects the major template issues once files are uploaded.
The changes need dressing up a bit still.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing extra warn

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Quick fix to bug 1809

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix a bug in authorised values admin

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Previous change hid global search on results page too, fixing.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>