From 1428615dad77f4a9702f287c461d792e908b5dcf Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 23 Feb 2018 14:20:17 +0100 Subject: [PATCH] Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart --- catalogue/detail.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index f2e8fae5d0..6455604eb3 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -216,7 +216,7 @@ if ( $mss->count ) { $template->param( itemwithdrawnloop => GetAuthorisedValues( $mss->next->authorised_value) ); } -$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { not => undef } }); +$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => [ -and => {'!=' => undef }, {'!=' => ''}] }); my %materials_map; if ($mss->count) { my $materials_authvals = GetAuthorisedValues($mss->next->authorised_value); -- 2.39.5