From 1957cb64ca8efab68001a9bdec3c0ce02133907b Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 21 Oct 2019 13:24:45 -0300
Subject: [PATCH] Bug 23843: Add mapping to Koha::Checkout
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This patch adds a to_api_mapping method to the class. This in effect
enables calling ->to_api on the object. The mapping is borrowed from the
API controller. It is not removed from the controller so we are able to
verify (through the tests) that there is no behavior change.
Once this is pushed we need to implement the counter-wise methods and
clean the controllers.
To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/checkouts.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 Koha/Checkout.pm          | 25 ++++++++++++++++++++++++-
 Koha/REST/V1/Checkouts.pm |  8 ++++----
 2 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm
index b7a752cdc5..1cba41ea3f 100644
--- a/Koha/Checkout.pm
+++ b/Koha/Checkout.pm
@@ -88,7 +88,30 @@ sub patron {
     return Koha::Patron->_new_from_dbic( $patron_rs );
 }
 
-=head3 type
+=head3 to_api_mapping
+
+This method returns the mapping for representing a Koha::Checkout object
+on the API.
+
+=cut
+
+sub to_api_mapping {
+    return {
+        issue_id        => 'checkout_id',
+        borrowernumber  => 'patron_id',
+        itemnumber      => 'item_id',
+        date_due        => 'due_date',
+        branchcode      => 'library_id',
+        returndate      => 'checkin_date',
+        lastreneweddate => 'last_renewed_date',
+        issuedate       => 'checkout_date',
+        notedate        => 'note_date',
+    };
+}
+
+=head2 Internal methods
+
+=head3 _type
 
 =cut
 
diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm
index b3a0699006..c8ded14ef7 100644
--- a/Koha/REST/V1/Checkouts.pm
+++ b/Koha/REST/V1/Checkouts.pm
@@ -92,8 +92,8 @@ sub get {
     }
 
     return $c->render(
-        status => 200,
-        openapi => _to_api($checkout->TO_JSON)
+        status  => 200,
+        openapi => $checkout->to_api
     );
 }
 
@@ -134,8 +134,8 @@ sub renew {
 
     $c->res->headers->location( $c->req->url->to_string );
     return $c->render(
-        status => 201,
-        openapi => _to_api( $checkout->TO_JSON )
+        status  => 201,
+        openapi => $checkout->to_api
     );
 }
 
-- 
2.39.5