From 205993cf65f7fc07ab617a1caaa5d709f93d938e Mon Sep 17 00:00:00 2001 From: Paul Poulain Date: Thu, 25 Oct 2012 16:08:31 +0200 Subject: [PATCH] Bug 8895 follow-up fix for Jonathan's QA comment useless use of defined($data->{value}) because it's set to "" 2 lines earlier --- admin/systempreferences.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl index 41130b2051..af9104159c 100755 --- a/admin/systempreferences.pl +++ b/admin/systempreferences.pl @@ -422,7 +422,7 @@ sub StringSearch { while ( my $data = $sth->fetchrow_hashref ) { unless (defined $data->{value}) { $data->{value} = "";} $data->{shortvalue} = $data->{value}; - $data->{shortvalue} = substr( $data->{value}, 0, 60 ) . "..." if defined( $data->{value} ) and length( $data->{value} ) > 60; + $data->{shortvalue} = substr( $data->{value}, 0, 60 ) . "..." if length( $data->{value} ) > 60; push( @results, $data ); $cnt++; } -- 2.39.5