From 28fb7a6c1966e2a77dcd686bb6bfa6c42ff933e7 Mon Sep 17 00:00:00 2001
From: Galen Charlton <galen.charlton@liblime.com>
Date: Sun, 1 Jun 2008 21:43:28 -0500
Subject: [PATCH] kohabug 2180 - improve display when fines block checkouts

If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
---
 circ/circulation.pl                                    |  3 ++-
 .../prog/en/modules/circ/circulation.tmpl              | 10 +++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/circ/circulation.pl b/circ/circulation.pl
index 644f6e0e18..004e7c8b13 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -568,7 +568,8 @@ foreach $flag ( sort keys %$flags ) {
         if ( $flag eq 'CHARGES' ) {
             $template->param(
                 charges    => 'true',
-                chargesmsg => $flags->{'CHARGES'}->{'message'}
+                chargesmsg => $flags->{'CHARGES'}->{'message'},
+                charges_is_blocker => 1
             );
         }
         if ( $flag eq 'CREDITS' ) {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl
index 8c043f1ad6..9b91040428 100755
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl
@@ -330,7 +330,15 @@ No patron matched <span class="ex"><!-- TMPL_VAR name="message" --></span>
             <!-- /TMPL_IF -->
 			
         	<!-- TMPL_IF NAME="charges" -->
-			<li><span class="circ-hlt">Fines:</span> Patron has  <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=<!-- TMPL_VAR name="borrowernumber" -->">Outstanding fines</a>.
+                <!-- TMPL_IF NAME="charges_is_blocker" -->
+			        <li class="blocker">
+                <!-- TMPL_ELSE -->
+			        <li>
+                <!-- /TMPL_IF -->
+            <span class="circ-hlt">Fines:</span> Patron has  <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=<!-- TMPL_VAR name="borrowernumber" -->">Outstanding fines</a>.
+                <!-- TMPL_IF NAME="charges_is_blocker" -->
+                    Checkouts are blocked because fine balance is over the limit.
+                <!-- /TMPL_IF -->
             Make <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=<!-- TMPL_VAR name="borrowernumber" -->">Payment</a></li>
 			<!-- /TMPL_IF -->
 
-- 
2.39.5