From 2bb2dbf9590f3ddcf952f80edf9d25e49bd7d477 Mon Sep 17 00:00:00 2001 From: Janusz Kaczmarek Date: Sat, 11 Mar 2023 11:45:32 +0100 Subject: [PATCH] Bug 33205: (bug 28268 follow-up) Method call $row->authid inside quotes - produces meaningless warning Bug 28268, in Koha::MetadataRecord::Authority::get_all_authorities_iterator, introduced a warning: warn "Something went wrong reading record for authority $row->authid: $@\n"; But a method cannot be called from within quotes in Perl - extrapolation does not work for functions/methods. So, if something really goes wrong, this line of code produces a warning like: Something went wrong reading record for authority Koha::Schema::Result::AuthHeader=HASH(0x55cf7e0d0958)->authid: Empty String at /usr/share/perl5/MARC/File/XML.pm line 450. which is not very informative -- authid is missing. Test plan ========= Hard to reproduce. This problem occurs only in rare cases of some weird problem in stores authority data or if a auth record had been deleted after a ES reindex action has been initiated. But the problem in the code and the fix seem obvious. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit 9c2510ea2ef1db46bf42cf948b6c599250d6dd9e) Signed-off-by: Fridolin Somers (cherry picked from commit fb3473dfe3abe71b9545f19035d47e84f59c69d6) Signed-off-by: Lucas Gass --- Koha/MetadataRecord/Authority.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/MetadataRecord/Authority.pm b/Koha/MetadataRecord/Authority.pm index d16970a828..ed0ebfc016 100644 --- a/Koha/MetadataRecord/Authority.pm +++ b/Koha/MetadataRecord/Authority.pm @@ -209,7 +209,7 @@ sub get_all_authorities_iterator { my $auth = __PACKAGE__->get_from_authid($row->authid); if (!$auth) { - warn "Something went wrong reading record for authority $row->authid: $@\n"; + warn "Something went wrong reading record for authority " . $row->authid . ": $@\n"; next; } return $auth; -- 2.20.1