From 6302ec6200fb26f38edbc1a5e127431108dc54a9 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Wed, 10 Apr 2024 14:50:04 +0300 Subject: [PATCH] Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer (cherry picked from commit f5e9f9634fd0d3ea1d06ca24141cb10660a2cf66) Signed-off-by: Fridolin Somers --- t/db_dependent/Circulation.t | 8 ++++---- t/db_dependent/Circulation/dateexpiry.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 509c69275d..6727fd0a4c 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2464,8 +2464,8 @@ subtest 'AddIssue & illrequests.due_date' => sub { set_userenv($library); - my $custom_date_due = '9999-12-18 12:34:56'; - my $expected_date_due = '9999-12-18 23:59:00'; + my $custom_date_due = '4999-12-18 12:34:56'; + my $expected_date_due = '4999-12-18 23:59:00'; my $illrequest = Koha::Illrequest->new({ borrowernumber => $patron->borrowernumber, biblio_id => $item->biblionumber, @@ -2478,8 +2478,8 @@ subtest 'AddIssue & illrequests.due_date' => sub { $patron = $builder->build_object( { class => 'Koha::Patrons' } ); $item = $builder->build_sample_item(); - $custom_date_due = '9999-12-19'; - $expected_date_due = '9999-12-19 23:59:00'; + $custom_date_due = '4999-12-19'; + $expected_date_due = '4999-12-19 23:59:00'; $illrequest = Koha::Illrequest->new({ borrowernumber => $patron->borrowernumber, biblio_id => $item->biblionumber, diff --git a/t/db_dependent/Circulation/dateexpiry.t b/t/db_dependent/Circulation/dateexpiry.t index 79ba9e0a02..f992219687 100755 --- a/t/db_dependent/Circulation/dateexpiry.t +++ b/t/db_dependent/Circulation/dateexpiry.t @@ -124,7 +124,7 @@ sub calc_date_due { is( ref $d eq "DateTime" && $d->mdy() =~ /^\d+/, 1, "CalcDateDue with expiry tomorrow" ); # fourth test far future - $patron->dateexpiry('9876-12-31')->store; + $patron->dateexpiry('4999-12-31')->store; my $t1 = time; $d = C4::Circulation::CalcDateDue( $today, $item->effective_itemtype, $branch->{branchcode}, $patron ); my $t2 = time; -- 2.20.1