From 8a63c17f79d63bcdb669b74b084b83b65295d246 Mon Sep 17 00:00:00 2001 From: Robin Sheat Date: Mon, 15 Sep 2014 14:08:03 +1200 Subject: [PATCH] Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi --- t/{ => db_dependent}/Templates.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename t/{ => db_dependent}/Templates.t (97%) diff --git a/t/Templates.t b/t/db_dependent/Templates.t similarity index 97% rename from t/Templates.t rename to t/db_dependent/Templates.t index f50297bf1c..ade6f1d11f 100755 --- a/t/Templates.t +++ b/t/db_dependent/Templates.t @@ -40,7 +40,7 @@ my $columns = C4::Templates::GetColumnDefs( $query ); is( ref( $columns ) eq 'HASH', 1, 'GetColumnDefs returns a hashref' ); # get the tables names, sorted -my @keys = sort keys $columns; +my @keys = sort keys %$columns; is( scalar @keys, 5, "GetColumnDefs correctly returns the 5 tables defined in columns.def" ); my @tables = ( 'biblio', 'biblioitems', 'borrowers', 'items', 'statistics'); cmp_deeply( \@keys, \@tables, "GetColumnDefs returns the expected tables"); -- 2.39.2