From 9e8d89dd70d1a5dde4dc700eea16b5b1d6edf3fe Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 16 Sep 2015 11:12:04 +0100
Subject: [PATCH] Bug 14321: QA Fix

Remove QA errors (keys on reference is experimental).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 Koha/Upload.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Koha/Upload.pm b/Koha/Upload.pm
index e30b354bb2..9b580ecc97 100644
--- a/Koha/Upload.pm
+++ b/Koha/Upload.pm
@@ -122,7 +122,7 @@ sub cgi {
 
 sub count {
     my ( $self ) = @_;
-    return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys $self->{files};
+    return scalar grep { !exists $self->{files}->{$_}->{errcode} } keys %{ $self->{files} };
 }
 
 =head2 result
@@ -135,7 +135,7 @@ sub result {
     my ( $self ) = @_;
     my @a = map { $self->{files}->{$_}->{id} }
         grep { !exists $self->{files}->{$_}->{errcode} }
-        keys $self->{files};
+        keys %{ $self->{files} };
     return @a? ( join ',', @a ): undef;
 }
 
@@ -149,7 +149,7 @@ sub result {
 sub err {
     my ( $self ) = @_;
     my $err;
-    foreach my $f ( keys $self->{files} ) {
+    foreach my $f ( keys %{ $self->{files} } ) {
         my $e = $self->{files}->{$f}->{errcode};
         $err->{ $f } = $e if $e;
     }
@@ -328,7 +328,7 @@ sub _hook {
 sub _done {
     my ( $self ) = @_;
     $self->{done} = 1;
-    foreach my $f ( keys $self->{files} ) {
+    foreach my $f ( keys %{ $self->{files} } ) {
         my $fh = $self->_fh($f);
         $self->_register( $f, $fh? tell( $fh ): undef )
             if !$self->{files}->{$f}->{errcode};
-- 
2.39.5