From c188ec1567e69a1ee9e9fff19320a273e4ea65dd Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 18 Mar 2021 10:23:57 +0000 Subject: [PATCH] Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart --- Koha/Account/Line.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm index 222dcc60df..13e9b07a48 100644 --- a/Koha/Account/Line.pm +++ b/Koha/Account/Line.pm @@ -416,7 +416,7 @@ sub cancel { { credit_id => $cancellation->accountlines_id, type => 'CREATE', - amount => $self->amount + amount => 0 - $self->amount } )->store(); @@ -535,7 +535,7 @@ sub reduce { { credit_id => $reduction->accountlines_id, type => 'CREATE', - amount => $params->{amount} + amount => 0 - $params->{amount} } )->store(); -- 2.39.5