From c3b41cb12465249cc87ed8866855e06e61842872 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 16 Jan 2019 13:19:45 +0000 Subject: [PATCH] Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm AddIssue already checks for holds in the item being issued and deals with them The sip code, additionally, does not consider that multiple holds per bib is allowed To test: 0 - Apply only first patch (unit tests) 1 - Place two holds for a patron on a bib 2 - Checkout that item via sip_cli_emulator 3 - Note all holds are cancelled/filled 4 - prove -v t/db_dependent/SIP/Transaction.t 5 - it fails 6 - Apply second patch 7 - prove tests, all green 8 - Place two holds on a single bib for one patron again 9 - Checkout the item via sip_cli_emulator 10 - Only one holds is filled Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens --- C4/SIP/ILS/Transaction/Checkout.pm | 9 --------- 1 file changed, 9 deletions(-) diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm index 23cdec92c4..09028ab14c 100644 --- a/C4/SIP/ILS/Transaction/Checkout.pm +++ b/C4/SIP/ILS/Transaction/Checkout.pm @@ -129,15 +129,6 @@ sub do_checkout { $self->ok(0); return $self; } - # Fill any reserves the patron had on the item. - # TODO: this logic should be pulled internal to AddIssue for all Koha. - $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]'; - foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}} @$pending) { - $debug and warn "Filling reserve (borrowernumber,biblionumber,reservedate): " - . sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate}); - ModReserveFill($_); - # TODO: adjust representation in $self->item - } # can issue $debug and warn "do_checkout: calling AddIssue(\$borrower,$barcode, $overridden_duedate, 0)\n" # . "w/ \$borrower: " . Dumper($borrower) -- 2.39.5