From e7dbe4124272bfcaa212f71f4da07541f01ec0d8 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 1 Nov 2018 11:08:51 +0000
Subject: [PATCH] Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 C4/Reserves.pm | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 05bf00bb68..3617549582 100644
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -570,24 +570,20 @@ sub GetOtherReserves {
 
 sub ChargeReserveFee {
     my ( $borrowernumber, $fee, $title ) = @_;
-
     return if !$fee || $fee == 0;    # the last test is needed to include 0.00
-
-    my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
-    my $nextacctno = C4::Accounts::getnextacctno($borrowernumber);
-
-    Koha::Account::Line->new(
+    Koha::Account->new( { patron_id => $borrowernumber } )->add_debit(
         {
-            borrowernumber    => $borrowernumber,
-            accountno         => $nextacctno,
-            date              => dt_from_string(),
-            amount            => $fee,
-            description       => "Reserve Charge - $title",
-            accounttype       => 'Res',
-            amountoutstanding => $fee,
-            branchcode        => $branchcode
+            amount       => $fee,
+            description  => "Reserve Charge - " . $title,
+            note         => undef,
+            user_id      => C4::Context->userenv ? C4::Context->userenv->{'number'} : 0,
+            library_id   => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
+            sip          => undef,
+            invoice_type => undef,
+            type         => 'reserve',
+            item_id      => undef
         }
-    )->store();
+    );
 }
 
 =head2 GetReserveFee
-- 
2.39.5