From eb62686630ec89d61fea048d645d333e6049ca98 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 20 Mar 2017 10:48:21 -0400 Subject: [PATCH] Bug 18251: (QA follow-up) Add alerts for all SCO actions To test: Add sound alerts for sco-alert-warning Test various actions (return,renew) and verify success/failure notices and sounds Note additional classes (return,renew,issue) to allow for more specificity of sounds alerts Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens --- .../bootstrap/en/modules/sco/sco-main.tt | 22 ++++++++++++++++++- opac/sco/sco-main.pl | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt index a67033e104..14f543add4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -39,6 +39,7 @@ [% IF ( impossible ) %]
+

Item cannot be checked out.

Sorry, this item cannot be checked out at this station.

[% IF ( title ) %] @@ -102,6 +103,7 @@ [% IF ( confirm ) %]

Please confirm the checkout:

+ [% IF ( confirm_renew_issue ) %]

This item is already checked out to you.

[% END %] @@ -149,6 +151,7 @@ [% IF ( nopermission ) %]
+

Access denied

Sorry, this self-checkout station has lost authentication. Please contact the administrator to resolve this problem.

@@ -157,6 +160,7 @@ [% IF ( different_ip ) %]
+

Session lost

You are accessing self-checkout from a different IP address! please log in again.

@@ -165,16 +169,32 @@ [% IF ( invalid_username_or_password ) %]
+

Record not found

Your userid was not found in the database. Please try again.

[% END %] [% IF ( issued ) %] - +

Item checked out

+ [% ELSIF ( renewed ) %] + +
+

Item renewed

+
+ [% ELSIF ( returned == 0 ) %] + +
+

Item not checked in: please see circulation staff for assistance

+
+ [% ELSIF ( returned == 1 ) %] + +
+

Item checked in

+
[% END %] diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl index 16e598dfa0..bbe0e9086a 100755 --- a/opac/sco/sco-main.pl +++ b/opac/sco/sco-main.pl @@ -124,10 +124,12 @@ my $return_only = 0; #warn "issuer cardnumber: " . $issuer->{cardnumber}; #warn "patron cardnumber: " . $borrower->{cardnumber}; if ($op eq "logout") { + $template->param( loggedout => 1 ); $query->param( patronid => undef, patronlogin => undef, patronpw => undef ); } elsif ( $op eq "returnbook" && $allowselfcheckreturns ) { my ($doreturn) = AddReturn( $barcode, $branch ); + $template->param( returned => $doreturn ); } elsif ( $patron and $op eq "checkout" ) { my $impossible = {}; @@ -177,6 +179,7 @@ elsif ( $patron and $op eq "checkout" ) { #warn "renewing"; AddRenewal( $borrower->{borrowernumber}, $item->{itemnumber} ); push @newissueslist, $barcode; + $template->param( renewed => 1 ); } else { #warn "renew confirmation"; $template->param( -- 2.39.5