From f08260c8606d15d69721e3b8ad399cfcc7a20261 Mon Sep 17 00:00:00 2001 From: rangi Date: Thu, 9 Feb 2006 01:52:14 +0000 Subject: [PATCH] Cleaning up some unessecary my statements --- C4/AuthoritiesMarc.pm | 7 +++++-- C4/Suggestions.pm | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm index e8c29771ba..d133a9e0f2 100644 --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -121,7 +121,7 @@ sub authoritysearch { # Finds the basic results without the NOT requests my ($sql_tables, $sql_where1, $sql_where2) = create_request($dbh,\@normal_tags, \@normal_and_or, \@normal_operator, \@normal_value); - my $sth; + if ($sql_where2) { $sth = $dbh->prepare("select distinct m1.authid from auth_header,$sql_tables where m1.authid=auth_header.authid and auth_header.authtypecode=? and $sql_where2 and ($sql_where1)"); @@ -167,7 +167,7 @@ sub authoritysearch { $summary =~ s/\n/
/g; # find biblio MARC field using this authtypecode (to jump to biblio) - my $authtypecode = AUTHfind_authtypecode($dbh,$result[$counter]); + $authtypecode = AUTHfind_authtypecode($dbh,$result[$counter]); my $sth = $dbh->prepare("select distinct tagfield from marc_subfield_structure where authtypecode=?"); $sth->execute($authtypecode); my $tags_using_authtype; @@ -939,6 +939,9 @@ Paul POULAIN paul.poulain@free.fr # $Id$ # $Log$ +# Revision 1.23 2006/02/09 01:52:14 rangi +# Cleaning up some unessecary my statements +# # Revision 1.22 2006/01/06 16:39:37 tipaul # synch'ing head and rel_2_2 (from 2.2.5, including npl templates) # Seems not to break too many things, but i'm probably wrong here. diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm index dc4e7b3015..dbe147c329 100644 --- a/C4/Suggestions.pm +++ b/C4/Suggestions.pm @@ -248,8 +248,8 @@ sub findsuggestion_from_biblionumber { my ($dbh,$biblionumber) = @_; my $sth = $dbh->prepare("select suggestionid from suggestions where biblionumber=?"); $sth->execute($biblionumber); - my ($biblionumber) = $sth->fetchrow; - return $biblionumber; + my ($suggestionid) = $sth->fetchrow; + return $suggestionid; } =back -- 2.39.5