From f2a05fadd06f40ad385ed8f7792ac7b68c16e7d7 Mon Sep 17 00:00:00 2001 From: Magnus Enger Date: Fri, 5 Apr 2024 13:41:08 +0000 Subject: [PATCH] Bug 36517: Fix output from install_plugins.pl When misc/devel/install_plugins.pl does not find any plugins, it prints the list of pluginsdir, but with a literal \n separating the dirs, and no newline at the end. To test: - Edit koha-conf.xml and add a second entry for , so there are two entries. The second one could just be a copy of the original. - Run "perl misc/devel/install_plugins.pl" - Note the output looks something like this: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ - Apply the patch and run the script again. Output should be: No plugins found pluginsdir contains: /var/lib/koha/kohadev/plugins /var/lib/koha/kohadev/plugins root@kohadevbox:koha(master)$ - Sign off Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer (cherry picked from commit 4848def5e2a336e01bf0dd0ff61a75a30b35f137) Signed-off-by: Fridolin Somers --- misc/devel/install_plugins.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/devel/install_plugins.pl b/misc/devel/install_plugins.pl index 8e2cee9ad9..74f43edc56 100755 --- a/misc/devel/install_plugins.pl +++ b/misc/devel/install_plugins.pl @@ -56,7 +56,7 @@ unless (@installed_plugins) { my $plugins_dir = C4::Context->config("pluginsdir"); if ( ref($plugins_dir) eq 'ARRAY' ) { print "No plugins found\n"; - print "pluginsdir contains: \n" . join( '\n', @{$plugins_dir} ); + print "pluginsdir contains: \n" . join( "\n", @{$plugins_dir} ) . "\n"; } else { print "No plugins found at $plugins_dir\n"; -- 2.20.1