From 8e7b3709c6b6956f67df89479994d9b85c2dee0e Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Fri, 8 Sep 2023 16:01:03 +0000
Subject: [PATCH] Bug 34724: (QA follow-up):

Replace href from thumbnail link with a # to keep pointer event. The href link gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists, then the imagenumber must also exist

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit bc8a0620012a79567c44d863c029a4b0025a2fbd)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 167f5aa3bb833764ed8e0ecc29d09740533e508c)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt    | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt
index 4bc57d82b6..107c6b5f14 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt
@@ -87,7 +87,7 @@
                                 <div class="col-lg-3">
                                     <div id="thumbnails">
                                         [% FOREACH image IN images %]
-                                            <a class="cover_thumbnail" data-imagenumber="[% image.imagenumber| html %]" href="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | url %]&amp;imagenumber=[% image.imagenumber| uri %]">
+                                            <a class="cover_thumbnail" data-imagenumber="[% image.imagenumber| html %]" href="#">
                                             [% IF loop.first %]
                                                 <img class="thumbnail selected" id="[% image.imagenumber| html %]" src="/cgi-bin/koha/opac-image.pl?imagenumber=[% image.imagenumber | html %]&amp;thumbnail=1" alt="Thumbnail"/>
                                             [% ELSE %]
@@ -114,11 +114,7 @@
             $("#largeCoverImg").attr("src","[% interface | html %]/[% theme | html %]/images/loading.gif");
             showCover([% imagenumber | html %]);
             $("a.cover_thumbnail").on('click',function(){
-                let imagenumber = this.dataset.imagenumber;
-                if (imagenumber){
-                    showCover(imagenumber);
-                }
-                return false;
+                showCover(this.dataset.imagenumber);
             });
         });
 
-- 
2.39.5