]> git.koha-community.org Git - koha.git/commit
Bug 11108: fix duplicate display of basket whose receipt has just been cancelled
authorGalen Charlton <gmc@esilibrary.com>
Tue, 22 Oct 2013 00:14:47 +0000 (00:14 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 5 Dec 2013 17:40:47 +0000 (14:40 -0300)
commit3941dd649a7d0cb9d1ecb3e64c7c9f071faa0231
tree5bfdcc22a811c65fbcbdd662772a403fa09052e3
parenteb877dbb79593f48b64af42830988aa77be95f09
Bug 11108: fix duplicate display of basket whose receipt has just been cancelled

After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, all tests and QA script.
Works as described.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 0010c27ea17a515683f5ae01b9e97d4f80e3d55f)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
acqui/parcel.pl