]> git.koha-community.org Git - koha.git/commit
Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t
authorMark Tompsett <mtompset@hotmail.com>
Thu, 7 Jul 2016 06:34:28 +0000 (02:34 -0400)
committerFrédéric Demians <f.demians@tamil.fr>
Mon, 1 Aug 2016 08:43:57 +0000 (10:43 +0200)
commit5129b29b02f1b4f586a0c6bc943f8cea8f605619
tree4924265e43bd01cd82728840dcc6fb5b4d61e614
parent6f5b5a2cb0fab29ca27005eb01eca43ceb716a60
Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t

By properly defining a opachtdocs (intranethtdocs was done too)
in the mock function, uninitialized variable warnings are
eliminated. Given that we can check if $KOHA_CONF is defined or
not, we can catch the warning as part of testing, so the output
of the test is cleaner.

TEST PLAN
---------
1) unset KOHA_CONF
2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t
   -- lots of noise
3) apply patch
4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t
   -- no noise
5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t
   -- see the warnings were caught and not just ignored.
6) run koha qa test tools

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
No warnings. Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 5ec641fbbb67501e2a71be64b12c9224caee1b55)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
t/db_dependent/SuggestionEngine_ExplodedTerms.t [changed mode: 0755->0644]