]> git.koha-community.org Git - koha.git/commit
Bug 37210: Escape single quote in search string in overdue.pl
authorHammat Wele <hammat.wele@inlibro.com>
Thu, 27 Jun 2024 14:09:04 +0000 (14:09 +0000)
committerwainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
Tue, 23 Jul 2024 23:16:39 +0000 (23:16 +0000)
commit91b727d5e71107addb585fa9762700c403698a97
treed8d46b135c58ed195b23961e0900888ada8e6664
parentbb09e474a05567e391860c8253084538a4b47a85
Bug 37210: Escape single quote in search string in overdue.pl

To Test:
1. Go to /cgi-bin/koha/circ/overdue.pl
2. In the «Name or card number» field, type «Tommy'and(select(0)from(select(sleep(10)))v)and'»
3. Apply the filter
   ==> It takes 10 seconds, sleep(10) is executed
4. Inspect the page, in «Patron category:» field, put «Tommy'and(select(0)from(select(sleep(10)))v)and'» in one of his option's value
5. select the option from the filter and Apply the filter
   ==> It takes 10 seconds, sleep(10) is executed
we can inject SQL to the followin field : borname, itemtype, borcat, holdingbranch, homebranch and branch
6. Apply the patch
7. Repeat step 1,2,3
   ==> it doesn't take 10 seconds, the injected sql is not executed
8. Repeat step 5
==> it doesn't take 10 seconds, the injected sql is not executed
9. Repeat step 5 with the followin field : itemtype, holdingbranch, homebranch and branch
   ==> it doesn't take 10 seconds, the injected sql is not executed

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
circ/overdue.pl