]> git.koha-community.org Git - koha.git/commit
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm
authorroot <root@kenza-VirtualBox>
Thu, 25 Jul 2013 12:03:32 +0000 (14:03 +0200)
committerBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Fri, 13 Sep 2013 22:17:01 +0000 (19:17 -0300)
commit0a47d3444dfa749f5b9c99252cd129bc80cee54a
treee4b9b5d46f0fc4f01e968f0b3a38f11451cbcaef
parentfb7c0d5a1afe23b2c7e1ebe09f48b522ac6821c5
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm

This patch gets rid of finish() and replace prepare_cached by prepare.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 5cba6457aa00f3f3b2038f70057df300d9c6b9c3)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit cfb48010ad23e50fc93d893963164a17d4208c7b)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit cfb48010ad23e50fc93d893963164a17d4208c7b)
C4/ClassSource.pm