From 30f4726697e572948a69e7347567f670d4bfd6a0 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 25 Oct 2021 15:02:55 +0200 Subject: [PATCH] Bug 28847: Remove diag statements Signed-off-by: Jonathan Druart --- t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 3 --- t/db_dependent/Koha/SearchEngine/Zebra/QueryBuilder.t | 3 --- 2 files changed, 6 deletions(-) diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t index b322fb8d03..2991ee39b6 100755 --- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t +++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t @@ -723,7 +723,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { my $query_builder = Koha::SearchEngine::Elasticsearch::QueryBuilder->new({index => $Koha::SearchEngine::BIBLIOS_INDEX}); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'both'); - diag(" SearchLimitLibrary set to 'both'"); my ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(homebranch: CPL OR holdingbranch: CPL)", "Branch limit expanded to home/holding branch"); @@ -736,7 +735,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { is( $limit_cgi, "&limit=multibranchlimit%3A$groupid", "Multibranch limit cgi does not get expanded"); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'homebranch'); - diag(" SearchLimitLibrary set to 'homebranch'"); ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(homebranch: CPL)", "branch limit expanded to home branch"); @@ -749,7 +747,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { is( $limit_cgi, "&limit=multibranchlimit%3A$groupid", "Limit cgi does not get expanded"); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'holdingbranch'); - diag(" SearchLimitLibrary set to 'homebranch'"); ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(holdingbranch: CPL)", "branch limit expanded to holding branch"); diff --git a/t/db_dependent/Koha/SearchEngine/Zebra/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Zebra/QueryBuilder.t index f26fc2e516..02c129aa64 100755 --- a/t/db_dependent/Koha/SearchEngine/Zebra/QueryBuilder.t +++ b/t/db_dependent/Koha/SearchEngine/Zebra/QueryBuilder.t @@ -60,7 +60,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { my $query_builder = Koha::SearchEngine::Zebra::QueryBuilder->new({index => $Koha::SearchEngine::BIBLIOS_INDEX}); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'both'); - diag(" SearchLimitLibrary set to 'both'"); my ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(homebranch= CPL or holdingbranch= CPL)", "Branch limit expanded to home/holding branch"); @@ -73,7 +72,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { is( $limit_cgi, "&limit=multibranchlimit%3A$groupid", "Multibranch limit cgi does not get expanded"); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'homebranch'); - diag(" SearchLimitLibrary set to 'homebranch'"); ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(homebranch= CPL)", "branch limit expanded to home branch"); @@ -86,7 +84,6 @@ subtest 'build_query_compat() SearchLimitLibrary tests' => sub { is( $limit_cgi, "&limit=multibranchlimit%3A$groupid", "Limit cgi does not get expanded"); t::lib::Mocks::mock_preference('SearchLimitLibrary', 'holdingbranch'); - diag(" SearchLimitLibrary set to 'homebranch'"); ( undef, undef, undef, undef, undef, $limit, $limit_cgi, $limit_desc, undef ) = $query_builder->build_query_compat( undef, undef, undef, [ "branch:CPL" ], undef, undef, undef, undef ); is( $limit, "(holdingbranch= CPL)", "branch limit expanded to holding branch"); -- 2.39.5