3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
26 use C4::Overdues qw(UpdateFine);
30 use t::lib::TestBuilder;
32 use Test::More tests => 83;
35 use_ok('C4::Circulation');
38 my $schema = Koha::Database->schema;
39 $schema->storage->txn_begin;
40 my $builder = t::lib::TestBuilder->new;
41 my $dbh = C4::Context->dbh;
44 $dbh->{RaiseError} = 1;
46 # Start with a clean slate
47 $dbh->do('DELETE FROM issues');
49 my $library = $builder->build({
52 my $library2 = $builder->build({
56 my $CircControl = C4::Context->preference('CircControl');
57 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
60 homebranch => $library2->{branchcode},
61 holdingbranch => $library2->{branchcode}
65 branchcode => $library2->{branchcode}
68 # No userenv, PickupLibrary
69 C4::Context->set_preference('CircControl', 'PickupLibrary');
71 C4::Context->preference('CircControl'),
73 'CircControl changed to PickupLibrary'
76 C4::Circulation::_GetCircControlBranch($item, $borrower),
77 $item->{$HomeOrHoldingBranch},
78 '_GetCircControlBranch returned item branch (no userenv defined)'
81 # No userenv, PatronLibrary
82 C4::Context->set_preference('CircControl', 'PatronLibrary');
84 C4::Context->preference('CircControl'),
86 'CircControl changed to PatronLibrary'
89 C4::Circulation::_GetCircControlBranch($item, $borrower),
90 $borrower->{branchcode},
91 '_GetCircControlBranch returned borrower branch'
94 # No userenv, ItemHomeLibrary
95 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
97 C4::Context->preference('CircControl'),
99 'CircControl changed to ItemHomeLibrary'
102 $item->{$HomeOrHoldingBranch},
103 C4::Circulation::_GetCircControlBranch($item, $borrower),
104 '_GetCircControlBranch returned item branch'
108 C4::Context->_new_userenv('xxx');
109 C4::Context->set_userenv(0,0,0,'firstname','surname', $library2->{branchcode}, 'Midway Public Library', '', '', '');
110 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
112 # Userenv set, PickupLibrary
113 C4::Context->set_preference('CircControl', 'PickupLibrary');
115 C4::Context->preference('CircControl'),
117 'CircControl changed to PickupLibrary'
120 C4::Circulation::_GetCircControlBranch($item, $borrower),
121 $library2->{branchcode},
122 '_GetCircControlBranch returned current branch'
125 # Userenv set, PatronLibrary
126 C4::Context->set_preference('CircControl', 'PatronLibrary');
128 C4::Context->preference('CircControl'),
130 'CircControl changed to PatronLibrary'
133 C4::Circulation::_GetCircControlBranch($item, $borrower),
134 $borrower->{branchcode},
135 '_GetCircControlBranch returned borrower branch'
138 # Userenv set, ItemHomeLibrary
139 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
141 C4::Context->preference('CircControl'),
143 'CircControl changed to ItemHomeLibrary'
146 C4::Circulation::_GetCircControlBranch($item, $borrower),
147 $item->{$HomeOrHoldingBranch},
148 '_GetCircControlBranch returned item branch'
151 # Reset initial configuration
152 C4::Context->set_preference('CircControl', $CircControl);
154 C4::Context->preference('CircControl'),
156 'CircControl reset to its initial value'
159 # Set a simple circ policy
160 $dbh->do('DELETE FROM issuingrules');
162 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
163 maxissueqty, issuelength, lengthunit,
164 renewalsallowed, renewalperiod,
165 norenewalbefore, auto_renew,
182 # Test C4::Circulation::ProcessOfflinePayment
183 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
185 my ( $original_count ) = $sth->fetchrow_array();
187 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', 'S', ? )", undef, $library2->{branchcode} );
189 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
192 my ( $new_count ) = $sth->fetchrow_array();
194 ok( $new_count == $original_count + 1, 'ProcessOfflinePayment makes payment correctly' );
196 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
197 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
198 C4::Context->dbh->do("DELETE FROM accountlines");
200 # CanBookBeRenewed tests
202 # Generate test biblio
203 my $biblio = MARC::Record->new();
204 my $title = 'Silence in the library';
205 $biblio->append_fields(
206 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
207 MARC::Field->new('245', ' ', ' ', a => $title),
210 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
212 my $barcode = 'R00000342';
213 my $branch = $library2->{branchcode};
215 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
217 homebranch => $branch,
218 holdingbranch => $branch,
220 replacementprice => 12.00
225 my $barcode2 = 'R00000343';
226 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
228 homebranch => $branch,
229 holdingbranch => $branch,
230 barcode => $barcode2,
231 replacementprice => 23.00
236 my $barcode3 = 'R00000346';
237 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
239 homebranch => $branch,
240 holdingbranch => $branch,
241 barcode => $barcode3,
242 replacementprice => 23.00
251 my %renewing_borrower_data = (
253 surname => 'Renewal',
255 branchcode => $branch,
258 my %reserving_borrower_data = (
259 firstname => 'Katrin',
260 surname => 'Reservation',
262 branchcode => $branch,
265 my %hold_waiting_borrower_data = (
267 surname => 'Reservation',
269 branchcode => $branch,
272 my %restricted_borrower_data = (
273 firstname => 'Alice',
274 surname => 'Reservation',
276 debarred => '3228-01-01',
277 branchcode => $branch,
280 my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
281 my $reserving_borrowernumber = AddMember(%reserving_borrower_data);
282 my $hold_waiting_borrowernumber = AddMember(%hold_waiting_borrower_data);
283 my $restricted_borrowernumber = AddMember(%restricted_borrower_data);
285 my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
286 my $restricted_borrower = GetMember( borrowernumber => $restricted_borrowernumber );
293 my $checkitem = undef;
296 my $issue = AddIssue( $renewing_borrower, $barcode);
297 my $datedue = dt_from_string( $issue->date_due() );
298 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
300 my $issue2 = AddIssue( $renewing_borrower, $barcode2);
301 $datedue = dt_from_string( $issue->date_due() );
302 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
305 my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber};
306 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
308 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
309 is( $renewokay, 1, 'Can renew, no holds for this title or item');
312 # Biblio-level hold, renewal test
314 $branch, $reserving_borrowernumber, $biblionumber,
315 $bibitems, $priority, $resdate, $expdate, $notes,
316 $title, $checkitem, $found
319 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
320 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
321 C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 1 );
322 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
323 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
324 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
325 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
327 # Now let's add an item level hold, we should no longer be able to renew the item
328 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
330 borrowernumber => $hold_waiting_borrowernumber,
331 biblionumber => $biblionumber,
332 itemnumber => $itemnumber,
333 branchcode => $branch,
337 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
338 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
341 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
342 # be able to renew these items
343 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
345 borrowernumber => $hold_waiting_borrowernumber,
346 biblionumber => $biblionumber,
347 itemnumber => $itemnumber3,
348 branchcode => $branch,
353 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
354 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
355 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
356 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
357 C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 0 );
359 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
360 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
361 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
363 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
364 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
365 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
367 my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber});
368 my $reserving_borrower = GetMember( borrowernumber => $reserving_borrowernumber );
369 AddIssue($reserving_borrower, $barcode3);
370 my $reserve = $dbh->selectrow_hashref(
371 'SELECT * FROM old_reserves WHERE reserve_id = ?',
375 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
377 # Item-level hold, renewal test
379 $branch, $reserving_borrowernumber, $biblionumber,
380 $bibitems, $priority, $resdate, $expdate, $notes,
381 $title, $itemnumber, $found
384 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
385 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
386 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
388 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
389 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
391 # Items can't fill hold for reasons
392 ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
393 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
394 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
395 ModItem({ notforloan => 0, itype => '' }, $biblionumber, $itemnumber,1);
397 # FIXME: Add more for itemtype not for loan etc.
399 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
400 my $barcode5 = 'R00000347';
401 my ( $item_bibnum5, $item_bibitemnum5, $itemnumber5 ) = AddItem(
403 homebranch => $branch,
404 holdingbranch => $branch,
405 barcode => $barcode5,
406 replacementprice => 23.00
410 my $datedue5 = AddIssue($restricted_borrower, $barcode5);
411 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
413 C4::Context->set_preference('RestrictionBlockRenewing','1');
414 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
415 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
416 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $itemnumber5);
417 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
419 # Users cannot renew an overdue item
420 my $barcode6 = 'R00000348';
421 my ( $item_bibnum6, $item_bibitemnum6, $itemnumber6 ) = AddItem(
423 homebranch => $branch,
424 holdingbranch => $branch,
425 barcode => $barcode6,
426 replacementprice => 23.00
431 my $barcode7 = 'R00000349';
432 my ( $item_bibnum7, $item_bibitemnum7, $itemnumber7 ) = AddItem(
434 homebranch => $branch,
435 holdingbranch => $branch,
436 barcode => $barcode7,
437 replacementprice => 23.00
441 my $datedue6 = AddIssue( $renewing_borrower, $barcode6);
442 is (defined $datedue6, 1, "Item 2 checked out, due date: $datedue6");
444 my $passeddatedue1 = AddIssue($renewing_borrower, $barcode7, DateTime->from_epoch(epoch => 1));
445 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: $passeddatedue1");
448 C4::Context->set_preference('OverduesBlockRenewing','blockitem');
449 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
450 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
451 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
452 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
455 $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber});
456 CancelReserve({ reserve_id => $reserveid });
459 # Test automatic renewal before value for "norenewalbefore" in policy is set
460 # In this case automatic renewal is not permitted prior to due date
461 my $barcode4 = '11235813';
462 my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
464 homebranch => $branch,
465 holdingbranch => $branch,
466 barcode => $barcode4,
467 replacementprice => 16.00
472 $issue = AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
473 ( $renewokay, $error ) =
474 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
475 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
476 is( $error, 'auto_too_soon',
477 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
480 # Test premature manual renewal
481 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
483 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
484 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
485 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
488 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
489 C4::Context->set_preference( 'NoRenewalBeforePrecision', 'exact_time' );
491 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
492 $datedue->clone->add( days => -7 ),
493 'Bug 14395: Renewals permitted 7 days before due date, as expected'
497 # Test 'date' setting for syspref NoRenewalBeforePrecision
498 C4::Context->set_preference( 'NoRenewalBeforePrecision', 'date' );
500 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
501 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
502 'Bug 14395: Renewals permitted 7 days before due date, as expected'
506 # Test premature automatic renewal
507 ( $renewokay, $error ) =
508 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
509 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
510 is( $error, 'auto_too_soon',
511 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
514 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
515 # and test automatic renewal again
516 $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
517 ( $renewokay, $error ) =
518 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
519 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
520 is( $error, 'auto_too_soon',
521 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
524 # Change policy so that loans can be renewed 99 days prior to the due date
525 # and test automatic renewal again
526 $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
527 ( $renewokay, $error ) =
528 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
529 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
530 is( $error, 'auto_renew',
531 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
536 # set policy to forbid renewals
537 $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
539 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
540 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
541 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
543 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
544 C4::Context->set_preference('WhenLostForgiveFine','1');
545 C4::Context->set_preference('WhenLostChargeReplacementFee','1');
547 C4::Overdues::UpdateFine(
549 issue_id => $issue->id(),
550 itemnumber => $itemnumber,
551 borrowernumber => $renewing_borrower->{borrowernumber},
554 due => Koha::DateUtils::output_pref($datedue)
558 LostItem( $itemnumber, 1 );
560 my $item = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber);
561 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
563 my $total_due = $dbh->selectrow_array(
564 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
565 undef, $renewing_borrower->{borrowernumber}
568 ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
570 C4::Context->dbh->do("DELETE FROM accountlines");
572 C4::Context->set_preference('WhenLostForgiveFine','0');
573 C4::Context->set_preference('WhenLostChargeReplacementFee','0');
575 C4::Overdues::UpdateFine(
577 issue_id => $issue2->id(),
578 itemnumber => $itemnumber2,
579 borrowernumber => $renewing_borrower->{borrowernumber},
582 due => Koha::DateUtils::output_pref($datedue)
586 LostItem( $itemnumber2, 0 );
588 my $item2 = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber2);
589 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
591 $total_due = $dbh->selectrow_array(
592 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
593 undef, $renewing_borrower->{borrowernumber}
596 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
598 my $now = dt_from_string();
599 my $future = dt_from_string();
600 $future->add( days => 7 );
601 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
602 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
604 # Users cannot renew any item if there is an overdue item
605 C4::Context->set_preference('OverduesBlockRenewing','block');
606 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
607 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
608 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
609 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
614 # GetUpcomingDueIssues tests
615 my $barcode = 'R00000342';
616 my $barcode2 = 'R00000343';
617 my $barcode3 = 'R00000344';
618 my $branch = $library2->{branchcode};
620 #Create another record
621 my $biblio2 = MARC::Record->new();
622 my $title2 = 'Something is worng here';
623 $biblio2->append_fields(
624 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
625 MARC::Field->new('245', ' ', ' ', a => $title2),
627 my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, '');
632 homebranch => $branch,
633 holdingbranch => $branch,
640 my %a_borrower_data = (
641 firstname => 'Fridolyn',
644 branchcode => $branch,
647 my $a_borrower_borrowernumber = AddMember(%a_borrower_data);
648 my $a_borrower = GetMember( borrowernumber => $a_borrower_borrowernumber );
650 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
651 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
652 my $today = DateTime->today(time_zone => C4::Context->tz());
654 my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
655 my $datedue = dt_from_string( $issue->date_due() );
656 my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
657 my $datedue2 = dt_from_string( $issue->date_due() );
661 # GetUpcomingDueIssues tests
663 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
664 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
667 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
668 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
669 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
672 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
673 is ( scalar( @$upcoming_dues ), 1,
674 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
677 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
679 my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
681 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
682 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
684 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
685 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
687 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
688 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
690 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
691 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
693 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
694 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
696 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
697 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
702 my $barcode = '1234567890';
703 my $branch = $library2->{branchcode};
705 my $biblio = MARC::Record->new();
706 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
709 my ( undef, undef, $itemnumber ) = AddItem(
711 homebranch => $branch,
712 holdingbranch => $branch,
719 my %a_borrower_data = (
723 branchcode => $branch,
726 my $borrowernumber = AddMember(%a_borrower_data);
728 my $issue = AddIssue( GetMember( borrowernumber => $borrowernumber ), $barcode );
731 issue_id => $issue->id(),
732 itemnumber => $itemnumber,
733 borrowernumber => $borrowernumber,
738 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
739 my $count = $hr->{count};
741 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
745 $dbh->do('DELETE FROM issues');
746 $dbh->do('DELETE FROM items');
747 $dbh->do('DELETE FROM issuingrules');
750 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
751 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
760 my $biblio = MARC::Record->new();
761 my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $biblio, '' );
763 my $barcode1 = '1234';
764 my ( undef, undef, $itemnumber1 ) = AddItem(
766 homebranch => $library2->{branchcode},
767 holdingbranch => $library2->{branchcode},
768 barcode => $barcode1,
772 my $barcode2 = '4321';
773 my ( undef, undef, $itemnumber2 ) = AddItem(
775 homebranch => $library2->{branchcode},
776 holdingbranch => $library2->{branchcode},
777 barcode => $barcode2,
782 my $borrowernumber1 = AddMember(
786 branchcode => $library2->{branchcode},
788 my $borrowernumber2 = AddMember(
789 firstname => 'Chelsea',
792 branchcode => $library2->{branchcode},
795 my $borrower1 = GetMember( borrowernumber => $borrowernumber1 );
796 my $borrower2 = GetMember( borrowernumber => $borrowernumber2 );
798 my $issue = AddIssue( $borrower1, $barcode1 );
800 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
801 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
804 $library2->{branchcode}, $borrowernumber2, $biblionumber,
805 '', 1, undef, undef, '',
809 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
810 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
811 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
812 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
814 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
815 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
816 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
817 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
819 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
820 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
821 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
822 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
824 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
825 C4::Context->set_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
826 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
827 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
829 # Setting item not checked out to be not for loan but holdable
830 ModItem({ notforloan => -1 }, $biblionumber, $itemnumber2);
832 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
833 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
837 # Don't allow renewing onsite checkout
838 my $barcode = 'R00000XXX';
839 my $branch = $library->{branchcode};
841 #Create another record
842 my $biblio = MARC::Record->new();
843 $biblio->append_fields(
844 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
845 MARC::Field->new('245', ' ', ' ', a => 'A title'),
847 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
849 my (undef, undef, $itemnumber) = AddItem(
851 homebranch => $branch,
852 holdingbranch => $branch,
858 my $borrowernumber = AddMember(
862 branchcode => $branch,
865 my $borrower = GetMember( borrowernumber => $borrowernumber );
866 my $issue = AddIssue( $borrower, $barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
867 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $itemnumber );
868 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
869 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );