3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 94;
25 use t::lib::TestBuilder;
33 use C4::Overdues qw(UpdateFine CalcFine);
36 use Koha::IssuingRules;
37 use Koha::Subscriptions;
39 my $schema = Koha::Database->schema;
40 $schema->storage->txn_begin;
41 my $builder = t::lib::TestBuilder->new;
42 my $dbh = C4::Context->dbh;
45 $dbh->{RaiseError} = 1;
47 # Start with a clean slate
48 $dbh->do('DELETE FROM issues');
50 my $library = $builder->build({
53 my $library2 = $builder->build({
56 my $itemtype = $builder->build(
57 { source => 'Itemtype',
58 value => { notforloan => undef, rentalcharge => 0 }
61 my $patron_category = $builder->build({ source => 'Category', value => { enrolmentfee => 0 } });
63 my $CircControl = C4::Context->preference('CircControl');
64 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
67 homebranch => $library2->{branchcode},
68 holdingbranch => $library2->{branchcode}
72 branchcode => $library2->{branchcode}
75 # No userenv, PickupLibrary
76 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
78 C4::Context->preference('CircControl'),
80 'CircControl changed to PickupLibrary'
83 C4::Circulation::_GetCircControlBranch($item, $borrower),
84 $item->{$HomeOrHoldingBranch},
85 '_GetCircControlBranch returned item branch (no userenv defined)'
88 # No userenv, PatronLibrary
89 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
91 C4::Context->preference('CircControl'),
93 'CircControl changed to PatronLibrary'
96 C4::Circulation::_GetCircControlBranch($item, $borrower),
97 $borrower->{branchcode},
98 '_GetCircControlBranch returned borrower branch'
101 # No userenv, ItemHomeLibrary
102 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
104 C4::Context->preference('CircControl'),
106 'CircControl changed to ItemHomeLibrary'
109 $item->{$HomeOrHoldingBranch},
110 C4::Circulation::_GetCircControlBranch($item, $borrower),
111 '_GetCircControlBranch returned item branch'
115 C4::Context->_new_userenv('xxx');
116 C4::Context->set_userenv(0,0,0,'firstname','surname', $library2->{branchcode}, 'Midway Public Library', '', '', '');
117 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
119 # Userenv set, PickupLibrary
120 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
122 C4::Context->preference('CircControl'),
124 'CircControl changed to PickupLibrary'
127 C4::Circulation::_GetCircControlBranch($item, $borrower),
128 $library2->{branchcode},
129 '_GetCircControlBranch returned current branch'
132 # Userenv set, PatronLibrary
133 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
135 C4::Context->preference('CircControl'),
137 'CircControl changed to PatronLibrary'
140 C4::Circulation::_GetCircControlBranch($item, $borrower),
141 $borrower->{branchcode},
142 '_GetCircControlBranch returned borrower branch'
145 # Userenv set, ItemHomeLibrary
146 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
148 C4::Context->preference('CircControl'),
150 'CircControl changed to ItemHomeLibrary'
153 C4::Circulation::_GetCircControlBranch($item, $borrower),
154 $item->{$HomeOrHoldingBranch},
155 '_GetCircControlBranch returned item branch'
158 # Reset initial configuration
159 t::lib::Mocks::mock_preference('CircControl', $CircControl);
161 C4::Context->preference('CircControl'),
163 'CircControl reset to its initial value'
166 # Set a simple circ policy
167 $dbh->do('DELETE FROM issuingrules');
169 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
170 maxissueqty, issuelength, lengthunit,
171 renewalsallowed, renewalperiod,
172 norenewalbefore, auto_renew,
189 # Test C4::Circulation::ProcessOfflinePayment
190 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
192 my ( $original_count ) = $sth->fetchrow_array();
194 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', ?, ? )", undef, $patron_category->{categorycode}, $library2->{branchcode} );
196 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
199 my ( $new_count ) = $sth->fetchrow_array();
201 ok( $new_count == $original_count + 1, 'ProcessOfflinePayment makes payment correctly' );
203 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
204 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
205 C4::Context->dbh->do("DELETE FROM accountlines");
207 # CanBookBeRenewed tests
209 # Generate test biblio
210 my $biblio = MARC::Record->new();
211 my $title = 'Silence in the library';
212 $biblio->append_fields(
213 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
214 MARC::Field->new('245', ' ', ' ', a => $title),
217 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
219 my $barcode = 'R00000342';
220 my $branch = $library2->{branchcode};
222 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
224 homebranch => $branch,
225 holdingbranch => $branch,
227 replacementprice => 12.00,
233 my $barcode2 = 'R00000343';
234 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
236 homebranch => $branch,
237 holdingbranch => $branch,
238 barcode => $barcode2,
239 replacementprice => 23.00,
245 my $barcode3 = 'R00000346';
246 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
248 homebranch => $branch,
249 holdingbranch => $branch,
250 barcode => $barcode3,
251 replacementprice => 23.00,
261 my %renewing_borrower_data = (
263 surname => 'Renewal',
264 categorycode => $patron_category->{categorycode},
265 branchcode => $branch,
268 my %reserving_borrower_data = (
269 firstname => 'Katrin',
270 surname => 'Reservation',
271 categorycode => $patron_category->{categorycode},
272 branchcode => $branch,
275 my %hold_waiting_borrower_data = (
277 surname => 'Reservation',
278 categorycode => $patron_category->{categorycode},
279 branchcode => $branch,
282 my %restricted_borrower_data = (
283 firstname => 'Alice',
284 surname => 'Reservation',
285 categorycode => $patron_category->{categorycode},
286 debarred => '3228-01-01',
287 branchcode => $branch,
290 my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
291 my $reserving_borrowernumber = AddMember(%reserving_borrower_data);
292 my $hold_waiting_borrowernumber = AddMember(%hold_waiting_borrower_data);
293 my $restricted_borrowernumber = AddMember(%restricted_borrower_data);
295 my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
296 my $restricted_borrower = GetMember( borrowernumber => $restricted_borrowernumber );
303 my $checkitem = undef;
306 my $issue = AddIssue( $renewing_borrower, $barcode);
307 my $datedue = dt_from_string( $issue->date_due() );
308 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
310 my $issue2 = AddIssue( $renewing_borrower, $barcode2);
311 $datedue = dt_from_string( $issue->date_due() );
312 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
315 my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber};
316 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
318 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
319 is( $renewokay, 1, 'Can renew, no holds for this title or item');
322 # Biblio-level hold, renewal test
324 $branch, $reserving_borrowernumber, $biblionumber,
325 $bibitems, $priority, $resdate, $expdate, $notes,
326 $title, $checkitem, $found
329 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
330 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
331 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
332 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
333 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
334 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
335 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
337 # Now let's add an item level hold, we should no longer be able to renew the item
338 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
340 borrowernumber => $hold_waiting_borrowernumber,
341 biblionumber => $biblionumber,
342 itemnumber => $itemnumber,
343 branchcode => $branch,
347 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
348 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
351 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
352 # be able to renew these items
353 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
355 borrowernumber => $hold_waiting_borrowernumber,
356 biblionumber => $biblionumber,
357 itemnumber => $itemnumber3,
358 branchcode => $branch,
363 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
364 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
365 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
366 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
367 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
369 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
370 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
371 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
373 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
374 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
375 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
377 my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber});
378 my $reserving_borrower = GetMember( borrowernumber => $reserving_borrowernumber );
379 AddIssue($reserving_borrower, $barcode3);
380 my $reserve = $dbh->selectrow_hashref(
381 'SELECT * FROM old_reserves WHERE reserve_id = ?',
385 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
387 # Item-level hold, renewal test
389 $branch, $reserving_borrowernumber, $biblionumber,
390 $bibitems, $priority, $resdate, $expdate, $notes,
391 $title, $itemnumber, $found
394 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
395 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
396 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
398 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
399 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
401 # Items can't fill hold for reasons
402 ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
403 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
404 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
405 ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber,1);
407 # FIXME: Add more for itemtype not for loan etc.
409 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
410 my $barcode5 = 'R00000347';
411 my ( $item_bibnum5, $item_bibitemnum5, $itemnumber5 ) = AddItem(
413 homebranch => $branch,
414 holdingbranch => $branch,
415 barcode => $barcode5,
416 replacementprice => 23.00,
421 my $datedue5 = AddIssue($restricted_borrower, $barcode5);
422 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
424 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
425 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
426 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
427 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $itemnumber5);
428 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
430 # Users cannot renew an overdue item
431 my $barcode6 = 'R00000348';
432 my ( $item_bibnum6, $item_bibitemnum6, $itemnumber6 ) = AddItem(
434 homebranch => $branch,
435 holdingbranch => $branch,
436 barcode => $barcode6,
437 replacementprice => 23.00,
443 my $barcode7 = 'R00000349';
444 my ( $item_bibnum7, $item_bibitemnum7, $itemnumber7 ) = AddItem(
446 homebranch => $branch,
447 holdingbranch => $branch,
448 barcode => $barcode7,
449 replacementprice => 23.00,
454 my $datedue6 = AddIssue( $renewing_borrower, $barcode6);
455 is (defined $datedue6, 1, "Item 2 checked out, due date: $datedue6");
457 my $now = dt_from_string();
458 my $five_weeks = DateTime::Duration->new(weeks => 5);
459 my $five_weeks_ago = $now - $five_weeks;
461 my $passeddatedue1 = AddIssue($renewing_borrower, $barcode7, $five_weeks_ago);
462 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
464 my ( $fine ) = CalcFine( GetItem(undef, $barcode7), $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
465 C4::Overdues::UpdateFine(
467 issue_id => $passeddatedue1->id(),
468 itemnumber => $itemnumber7,
469 borrowernumber => $renewing_borrower->{borrowernumber},
472 due => Koha::DateUtils::output_pref($five_weeks_ago)
475 t::lib::Mocks::mock_preference('RenewalLog', 0);
476 my $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
477 my $old_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
478 AddRenewal( $renewing_borrower->{borrowernumber}, $itemnumber7, $branch );
479 my $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
480 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
482 t::lib::Mocks::mock_preference('RenewalLog', 1);
483 $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } );
484 $old_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
485 AddRenewal( $renewing_borrower->{borrowernumber}, $itemnumber7, $branch );
486 $new_log_size = scalar(@{GetLogs( $date, $date, undef,["CIRCULATION"], ["RENEWAL"]) } );
487 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
490 $fine = $schema->resultset('Accountline')->single( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $itemnumber7 } );
491 is( $fine->accounttype, 'F', 'Fine on renewed item is closed out properly' );
494 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
495 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
496 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
497 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
498 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
501 $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber});
502 CancelReserve({ reserve_id => $reserveid });
505 # Test automatic renewal before value for "norenewalbefore" in policy is set
506 # In this case automatic renewal is not permitted prior to due date
507 my $barcode4 = '11235813';
508 my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
510 homebranch => $branch,
511 holdingbranch => $branch,
512 barcode => $barcode4,
513 replacementprice => 16.00,
519 $issue = AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
520 ( $renewokay, $error ) =
521 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
522 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
523 is( $error, 'auto_too_soon',
524 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
527 # Test premature manual renewal
528 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
530 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
531 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
532 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
535 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
536 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
538 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
539 $datedue->clone->add( days => -7 ),
540 'Bug 14395: Renewals permitted 7 days before due date, as expected'
544 # Test 'date' setting for syspref NoRenewalBeforePrecision
545 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
547 GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
548 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
549 'Bug 14395: Renewals permitted 7 days before due date, as expected'
553 # Test premature automatic renewal
554 ( $renewokay, $error ) =
555 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
556 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
557 is( $error, 'auto_too_soon',
558 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
561 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
562 # and test automatic renewal again
563 $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
564 ( $renewokay, $error ) =
565 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
566 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
567 is( $error, 'auto_too_soon',
568 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
571 # Change policy so that loans can be renewed 99 days prior to the due date
572 # and test automatic renewal again
573 $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
574 ( $renewokay, $error ) =
575 CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
576 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
577 is( $error, 'auto_renew',
578 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
581 subtest "too_late_renewal / no_auto_renewal_after" => sub {
583 my $item_to_auto_renew = $builder->build(
586 biblionumber => $biblionumber,
587 homebranch => $branch,
588 holdingbranch => $branch,
593 my $ten_days_before = dt_from_string->add( days => -10 );
594 my $ten_days_ahead = dt_from_string->add( days => 10 );
595 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
597 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 9');
598 ( $renewokay, $error ) =
599 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
600 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
601 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
603 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 10');
604 ( $renewokay, $error ) =
605 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
606 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
607 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
609 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 11');
610 ( $renewokay, $error ) =
611 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
612 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
613 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
615 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
616 ( $renewokay, $error ) =
617 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
618 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
619 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
622 subtest "GetLatestAutoRenewDate" => sub {
624 my $item_to_auto_renew = $builder->build(
627 biblionumber => $biblionumber,
628 homebranch => $branch,
629 holdingbranch => $branch,
634 my $ten_days_before = dt_from_string->add( days => -10 );
635 my $ten_days_ahead = dt_from_string->add( days => 10 );
636 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
637 $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = ""');
638 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
639 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after is not defined' );
640 my $five_days_before = dt_from_string->add( days => -5 );
641 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 5');
642 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
643 is( $latest_auto_renew_date->truncate( to => 'minute' ),
644 $five_days_before->truncate( to => 'minute' ),
645 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
647 my $five_days_ahead = dt_from_string->add( days => 5 );
648 $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15');
649 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
650 is( $latest_auto_renew_date->truncate( to => 'minute' ),
651 $five_days_ahead->truncate( to => 'minute' ),
652 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
658 # set policy to forbid renewals
659 $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
661 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
662 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
663 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
665 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
666 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
667 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
669 C4::Overdues::UpdateFine(
671 issue_id => $issue->id(),
672 itemnumber => $itemnumber,
673 borrowernumber => $renewing_borrower->{borrowernumber},
676 due => Koha::DateUtils::output_pref($datedue)
680 LostItem( $itemnumber, 1 );
682 my $item = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber);
683 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
685 my $total_due = $dbh->selectrow_array(
686 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
687 undef, $renewing_borrower->{borrowernumber}
690 ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
692 C4::Context->dbh->do("DELETE FROM accountlines");
694 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
695 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
697 C4::Overdues::UpdateFine(
699 issue_id => $issue2->id(),
700 itemnumber => $itemnumber2,
701 borrowernumber => $renewing_borrower->{borrowernumber},
704 due => Koha::DateUtils::output_pref($datedue)
708 LostItem( $itemnumber2, 0 );
710 my $item2 = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber2);
711 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
713 $total_due = $dbh->selectrow_array(
714 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
715 undef, $renewing_borrower->{borrowernumber}
718 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
720 my $future = dt_from_string();
721 $future->add( days => 7 );
722 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
723 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
725 # Users cannot renew any item if there is an overdue item
726 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
727 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
728 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
729 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
730 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
735 # GetUpcomingDueIssues tests
736 my $barcode = 'R00000342';
737 my $barcode2 = 'R00000343';
738 my $barcode3 = 'R00000344';
739 my $branch = $library2->{branchcode};
741 #Create another record
742 my $biblio2 = MARC::Record->new();
743 my $title2 = 'Something is worng here';
744 $biblio2->append_fields(
745 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
746 MARC::Field->new('245', ' ', ' ', a => $title2),
748 my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, '');
753 homebranch => $branch,
754 holdingbranch => $branch,
755 barcode => $barcode3,
762 my %a_borrower_data = (
763 firstname => 'Fridolyn',
765 categorycode => $patron_category->{categorycode},
766 branchcode => $branch,
769 my $a_borrower_borrowernumber = AddMember(%a_borrower_data);
770 my $a_borrower = GetMember( borrowernumber => $a_borrower_borrowernumber );
772 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
773 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
774 my $today = DateTime->today(time_zone => C4::Context->tz());
776 my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
777 my $datedue = dt_from_string( $issue->date_due() );
778 my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
779 my $datedue2 = dt_from_string( $issue->date_due() );
783 # GetUpcomingDueIssues tests
785 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
786 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
789 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
790 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
791 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
794 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
795 is ( scalar( @$upcoming_dues ), 1,
796 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
799 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
801 my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
803 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
804 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
806 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
807 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
809 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
810 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
812 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
813 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
815 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
816 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
818 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
819 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
824 my $barcode = '1234567890';
825 my $branch = $library2->{branchcode};
827 my $biblio = MARC::Record->new();
828 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
831 my ( undef, undef, $itemnumber ) = AddItem(
833 homebranch => $branch,
834 holdingbranch => $branch,
842 my %a_borrower_data = (
845 categorycode => $patron_category->{categorycode},
846 branchcode => $branch,
849 my $borrowernumber = AddMember(%a_borrower_data);
851 my $issue = AddIssue( GetMember( borrowernumber => $borrowernumber ), $barcode );
854 issue_id => $issue->id(),
855 itemnumber => $itemnumber,
856 borrowernumber => $borrowernumber,
862 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
863 my $count = $hr->{count};
865 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
869 $dbh->do('DELETE FROM issues');
870 $dbh->do('DELETE FROM items');
871 $dbh->do('DELETE FROM issuingrules');
874 INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
875 norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
884 my $biblio = MARC::Record->new();
885 my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $biblio, '' );
887 my $barcode1 = '1234';
888 my ( undef, undef, $itemnumber1 ) = AddItem(
890 homebranch => $library2->{branchcode},
891 holdingbranch => $library2->{branchcode},
892 barcode => $barcode1,
897 my $barcode2 = '4321';
898 my ( undef, undef, $itemnumber2 ) = AddItem(
900 homebranch => $library2->{branchcode},
901 holdingbranch => $library2->{branchcode},
902 barcode => $barcode2,
908 my $borrowernumber1 = AddMember(
911 categorycode => $patron_category->{categorycode},
912 branchcode => $library2->{branchcode},
914 my $borrowernumber2 = AddMember(
915 firstname => 'Chelsea',
917 categorycode => $patron_category->{categorycode},
918 branchcode => $library2->{branchcode},
921 my $borrower1 = GetMember( borrowernumber => $borrowernumber1 );
922 my $borrower2 = GetMember( borrowernumber => $borrowernumber2 );
924 my $issue = AddIssue( $borrower1, $barcode1 );
926 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
927 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
930 $library2->{branchcode}, $borrowernumber2, $biblionumber,
931 '', 1, undef, undef, '',
935 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
936 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
937 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
938 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
940 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
941 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
942 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
943 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
945 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
946 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
947 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
948 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
950 C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
951 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
952 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
953 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
955 # Setting item not checked out to be not for loan but holdable
956 ModItem({ notforloan => -1 }, $biblionumber, $itemnumber2);
958 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
959 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
963 # Don't allow renewing onsite checkout
964 my $barcode = 'R00000XXX';
965 my $branch = $library->{branchcode};
967 #Create another record
968 my $biblio = MARC::Record->new();
969 $biblio->append_fields(
970 MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
971 MARC::Field->new('245', ' ', ' ', a => 'A title'),
973 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
975 my (undef, undef, $itemnumber) = AddItem(
977 homebranch => $branch,
978 holdingbranch => $branch,
985 my $borrowernumber = AddMember(
988 categorycode => $patron_category->{categorycode},
989 branchcode => $branch,
992 my $borrower = GetMember( borrowernumber => $borrowernumber );
993 my $issue = AddIssue( $borrower, $barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
994 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $itemnumber );
995 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
996 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1000 my $library = $builder->build({ source => 'Branch' });
1002 my $biblio = MARC::Record->new();
1003 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
1005 my $barcode = 'just a barcode';
1006 my ( undef, undef, $itemnumber ) = AddItem(
1008 homebranch => $library->{branchcode},
1009 holdingbranch => $library->{branchcode},
1010 barcode => $barcode,
1016 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode} } } );
1018 my $issue = AddIssue( GetMember( borrowernumber => $patron->{borrowernumber} ), $barcode );
1021 issue_id => $issue->id(),
1022 itemnumber => $itemnumber,
1023 borrowernumber => $patron->{borrowernumber},
1030 issue_id => $issue->id(),
1031 itemnumber => $itemnumber,
1032 borrowernumber => $patron->{borrowernumber},
1037 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1040 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1043 my $homebranch = $builder->build( { source => 'Branch' } );
1044 my $holdingbranch = $builder->build( { source => 'Branch' } );
1045 my $otherbranch = $builder->build( { source => 'Branch' } );
1046 my $patron_1 = $builder->build( { source => 'Borrower' } );
1047 my $patron_2 = $builder->build( { source => 'Borrower' } );
1049 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1050 my $item = $builder->build(
1053 homebranch => $homebranch->{branchcode},
1054 holdingbranch => $holdingbranch->{branchcode},
1058 biblionumber => $biblioitem->{biblionumber}
1063 set_userenv($holdingbranch);
1065 my $issue = AddIssue( $patron_1, $item->{barcode} );
1066 is( ref($issue), 'Koha::Schema::Result::Issue' ); # FIXME Should be Koha::Checkout
1068 my ( $error, $question, $alerts );
1070 # AllowReturnToBranch == anywhere
1071 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1072 ## Can be issued from homebranch
1073 set_userenv($homebranch);
1074 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1075 is( keys(%$error) + keys(%$alerts), 0 );
1076 is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1077 ## Can be issued from holdingbranch
1078 set_userenv($holdingbranch);
1079 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1080 is( keys(%$error) + keys(%$alerts), 0 );
1081 is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1082 ## Can be issued from another branch
1083 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1084 is( keys(%$error) + keys(%$alerts), 0 );
1085 is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1087 # AllowReturnToBranch == holdingbranch
1088 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1089 ## Cannot be issued from homebranch
1090 set_userenv($homebranch);
1091 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1092 is( keys(%$question) + keys(%$alerts), 0 );
1093 is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1094 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1095 ## Can be issued from holdinbranch
1096 set_userenv($holdingbranch);
1097 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1098 is( keys(%$error) + keys(%$alerts), 0 );
1099 is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1100 ## Cannot be issued from another branch
1101 set_userenv($otherbranch);
1102 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1103 is( keys(%$question) + keys(%$alerts), 0 );
1104 is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1105 is( $error->{branch_to_return}, $holdingbranch->{branchcode} );
1107 # AllowReturnToBranch == homebranch
1108 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1109 ## Can be issued from holdinbranch
1110 set_userenv($homebranch);
1111 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1112 is( keys(%$error) + keys(%$alerts), 0 );
1113 is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1114 ## Cannot be issued from holdinbranch
1115 set_userenv($holdingbranch);
1116 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1117 is( keys(%$question) + keys(%$alerts), 0 );
1118 is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1119 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1120 ## Cannot be issued from holdinbranch
1121 set_userenv($otherbranch);
1122 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1123 is( keys(%$question) + keys(%$alerts), 0 );
1124 is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1125 is( $error->{branch_to_return}, $homebranch->{branchcode} );
1127 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1130 subtest 'AddIssue & AllowReturnToBranch' => sub {
1133 my $homebranch = $builder->build( { source => 'Branch' } );
1134 my $holdingbranch = $builder->build( { source => 'Branch' } );
1135 my $otherbranch = $builder->build( { source => 'Branch' } );
1136 my $patron_1 = $builder->build( { source => 'Borrower' } );
1137 my $patron_2 = $builder->build( { source => 'Borrower' } );
1139 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1140 my $item = $builder->build(
1143 homebranch => $homebranch->{branchcode},
1144 holdingbranch => $holdingbranch->{branchcode},
1148 biblionumber => $biblioitem->{biblionumber}
1153 set_userenv($holdingbranch);
1155 my $ref_issue = 'Koha::Schema::Result::Issue'; # FIXME Should be Koha::Checkout
1156 my $issue = AddIssue( $patron_1, $item->{barcode} );
1158 my ( $error, $question, $alerts );
1160 # AllowReturnToBranch == homebranch
1161 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1162 ## Can be issued from homebranch
1163 set_userenv($homebranch);
1164 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1165 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1166 ## Can be issued from holdinbranch
1167 set_userenv($holdingbranch);
1168 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1169 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1170 ## Can be issued from another branch
1171 set_userenv($otherbranch);
1172 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1173 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1175 # AllowReturnToBranch == holdinbranch
1176 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1177 ## Cannot be issued from homebranch
1178 set_userenv($homebranch);
1179 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1180 ## Can be issued from holdingbranch
1181 set_userenv($holdingbranch);
1182 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1183 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1184 ## Cannot be issued from another branch
1185 set_userenv($otherbranch);
1186 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1188 # AllowReturnToBranch == homebranch
1189 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1190 ## Can be issued from homebranch
1191 set_userenv($homebranch);
1192 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1193 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1194 ## Cannot be issued from holdinbranch
1195 set_userenv($holdingbranch);
1196 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1197 ## Cannot be issued from another branch
1198 set_userenv($otherbranch);
1199 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1200 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1203 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1206 my $library = $builder->build( { source => 'Branch' } );
1207 my $patron = $builder->build( { source => 'Borrower' } );
1209 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1210 my $item_1 = $builder->build(
1213 homebranch => $library->{branchcode},
1214 holdingbranch => $library->{branchcode},
1218 biblionumber => $biblioitem_1->{biblionumber}
1222 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1223 my $item_2 = $builder->build(
1226 homebranch => $library->{branchcode},
1227 holdingbranch => $library->{branchcode},
1231 biblionumber => $biblioitem_2->{biblionumber}
1236 my ( $error, $question, $alerts );
1238 # Patron cannot issue item_1, he or she has overdues
1239 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1240 my $issue = AddIssue( $patron, $item_1->{barcode}, $yesterday ); # Add an overdue
1242 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1243 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1244 is( keys(%$error) + keys(%$alerts), 0 );
1245 is( $question->{USERBLOCKEDOVERDUE}, 1 );
1247 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1248 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1249 is( keys(%$question) + keys(%$alerts), 0 );
1250 is( $error->{USERBLOCKEDOVERDUE}, 1 );
1252 # Patron cannot issue item_1, he or she is debarred
1253 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1254 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->{borrowernumber}, expiration => $tomorrow } );
1255 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1256 is( keys(%$question) + keys(%$alerts), 0 );
1257 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ) );
1259 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->{borrowernumber} } );
1260 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1261 is( keys(%$question) + keys(%$alerts), 0 );
1262 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31' );
1265 subtest 'MultipleReserves' => sub {
1268 my $biblio = MARC::Record->new();
1269 my $title = 'Silence in the library';
1270 $biblio->append_fields(
1271 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
1272 MARC::Field->new('245', ' ', ' ', a => $title),
1275 my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
1277 my $branch = $library2->{branchcode};
1279 my $barcode1 = 'R00110001';
1280 my ( $item_bibnum1, $item_bibitemnum1, $itemnumber1 ) = AddItem(
1282 homebranch => $branch,
1283 holdingbranch => $branch,
1284 barcode => $barcode1,
1285 replacementprice => 12.00,
1291 my $barcode2 = 'R00110002';
1292 my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
1294 homebranch => $branch,
1295 holdingbranch => $branch,
1296 barcode => $barcode2,
1297 replacementprice => 12.00,
1305 my $resdate = undef;
1306 my $expdate = undef;
1308 my $checkitem = undef;
1311 my %renewing_borrower_data = (
1312 firstname => 'John',
1313 surname => 'Renewal',
1314 categorycode => $patron_category->{categorycode},
1315 branchcode => $branch,
1317 my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
1318 my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
1319 my $issue = AddIssue( $renewing_borrower, $barcode1);
1320 my $datedue = dt_from_string( $issue->date_due() );
1321 is (defined $issue->date_due(), 1, "item 1 checked out");
1322 my $borrowing_borrowernumber = GetItemIssue($itemnumber1)->{borrowernumber};
1324 my %reserving_borrower_data1 = (
1325 firstname => 'Katrin',
1326 surname => 'Reservation',
1327 categorycode => $patron_category->{categorycode},
1328 branchcode => $branch,
1330 my $reserving_borrowernumber1 = AddMember(%reserving_borrower_data1);
1332 $branch, $reserving_borrowernumber1, $biblionumber,
1333 $bibitems, $priority, $resdate, $expdate, $notes,
1334 $title, $checkitem, $found
1337 my %reserving_borrower_data2 = (
1338 firstname => 'Kirk',
1339 surname => 'Reservation',
1340 categorycode => $patron_category->{categorycode},
1341 branchcode => $branch,
1343 my $reserving_borrowernumber2 = AddMember(%reserving_borrower_data2);
1345 $branch, $reserving_borrowernumber2, $biblionumber,
1346 $bibitems, $priority, $resdate, $expdate, $notes,
1347 $title, $checkitem, $found
1351 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber1, 1);
1352 is($renewokay, 0, 'Bug 17641 - should cover the case where 2 books are both reserved, so failing');
1355 my $barcode3 = 'R00110003';
1356 my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
1358 homebranch => $branch,
1359 holdingbranch => $branch,
1360 barcode => $barcode3,
1361 replacementprice => 12.00,
1368 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber1, 1);
1369 is($renewokay, 1, 'Bug 17641 - should cover the case where 2 books are reserved, but a third one is available');
1373 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1376 my $library = $builder->build( { source => 'Branch' } );
1377 my $patron = $builder->build( { source => 'Borrower' } );
1379 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1380 my $biblionumber = $biblioitem->{biblionumber};
1381 my $item_1 = $builder->build(
1384 homebranch => $library->{branchcode},
1385 holdingbranch => $library->{branchcode},
1389 biblionumber => $biblionumber,
1393 my $item_2 = $builder->build(
1396 homebranch => $library->{branchcode},
1397 holdingbranch => $library->{branchcode},
1401 biblionumber => $biblionumber,
1406 my ( $error, $question, $alerts );
1407 my $issue = AddIssue( $patron, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1409 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1410 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1411 is( keys(%$error) + keys(%$alerts), 0, 'No error or alert should be raised' );
1412 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
1414 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1415 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1416 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1' );
1418 # Add a subscription
1419 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1421 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1422 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1423 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' );
1425 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1426 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1427 is( keys(%$error) + keys(%$question) + keys(%$alerts), 0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' );
1430 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1433 my $library = $builder->build( { source => 'Branch' } );
1434 my $patron = $builder->build( { source => 'Borrower' } );
1437 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
1438 my $item_1 = $builder->build(
1442 homebranch => $library->{branchcode},
1443 holdingbranch => $library->{branchcode},
1447 biblionumber => $biblioitem_1->{biblionumber}
1451 my $biblioitem_2 = $builder->build( { source => 'Biblioitem' } );
1452 my $item_2 = $builder->build(
1456 homebranch => $library->{branchcode},
1457 holdingbranch => $library->{branchcode},
1461 biblionumber => $biblioitem_2->{biblionumber}
1466 # And the issuing rule
1467 Koha::IssuingRules->search->delete;
1468 my $rule = Koha::IssuingRule->new(
1470 categorycode => '*',
1475 firstremind => 1, # 1 day of grace
1476 finedays => 2, # 2 days of fine per day of overdue
1477 lengthunit => 'days',
1482 # Patron cannot issue item_1, he or she has overdues
1483 my $five_days_ago = dt_from_string->subtract( days => 5 );
1484 my $ten_days_ago = dt_from_string->subtract( days => 10 );
1485 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1486 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1487 ; # Add another overdue
1489 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
1490 AddReturn( $item_1->{barcode}, $library->{branchcode},
1491 undef, undef, dt_from_string );
1492 my $debarments = Koha::Patron::Debarments::GetDebarments(
1493 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1494 is( scalar(@$debarments), 1 );
1496 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
1497 # Same for the others
1498 my $expected_expiration = output_pref(
1500 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1501 dateformat => 'sql',
1505 is( $debarments->[0]->{expiration}, $expected_expiration );
1507 AddReturn( $item_2->{barcode}, $library->{branchcode},
1508 undef, undef, dt_from_string );
1509 $debarments = Koha::Patron::Debarments::GetDebarments(
1510 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1511 is( scalar(@$debarments), 1 );
1512 $expected_expiration = output_pref(
1514 dt => dt_from_string->add( days => ( 10 - 1 ) * 2 ),
1515 dateformat => 'sql',
1519 is( $debarments->[0]->{expiration}, $expected_expiration );
1521 Koha::Patron::Debarments::DelUniqueDebarment(
1522 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1524 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
1525 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
1526 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1527 ; # Add another overdue
1528 AddReturn( $item_1->{barcode}, $library->{branchcode},
1529 undef, undef, dt_from_string );
1530 $debarments = Koha::Patron::Debarments::GetDebarments(
1531 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1532 is( scalar(@$debarments), 1 );
1533 $expected_expiration = output_pref(
1535 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1536 dateformat => 'sql',
1540 is( $debarments->[0]->{expiration}, $expected_expiration );
1542 AddReturn( $item_2->{barcode}, $library->{branchcode},
1543 undef, undef, dt_from_string );
1544 $debarments = Koha::Patron::Debarments::GetDebarments(
1545 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1546 is( scalar(@$debarments), 1 );
1547 $expected_expiration = output_pref(
1549 dt => dt_from_string->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
1550 dateformat => 'sql',
1554 is( $debarments->[0]->{expiration}, $expected_expiration );
1558 my ( $library ) = @_;
1559 C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, $library->{branchname}, '', '', '');