]> git.koha-community.org Git - koha.git/commit
Bug 15524: (QA follow-up) Fix meaningless test
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 16 Feb 2018 08:02:39 +0000 (09:02 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 24 Aug 2018 16:27:26 +0000 (16:27 +0000)
commit038e86a3951b701619c0b5e338d684c93b2bba5f
treed35131306369aec721428f3e7e243929d0157e06
parentcb04cc6242222342c6149b0e6dd866cb657de117
Bug 15524: (QA follow-up) Fix meaningless test

The last test claims to allow a hold when branch=5 and patron=5, but look
at the preceding statements:
    $rule_branch->max_holds(5);
    $rule_branch->update();
    $rule_branch->max_holds(5);
    $rule_branch->insert();
The last insert will not be done, since the record is already present.
A create should have triggered an error on the primary key.
Obviously, we should use $rule_all.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
t/db_dependent/Holds.t