]> git.koha-community.org Git - koha.git/commit
Bug 23416: Add PreserveSerialNotes system preference
authorNick Clemens <nick@bywatersolutions.com>
Fri, 2 Aug 2019 13:22:37 +0000 (13:22 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 29 Aug 2019 08:26:48 +0000 (10:26 +0200)
commit0960ddb6107e1e7401c8ba26669a802f698c02aa
tree2ebeb0917b2ac1f10171c9177eb718fcf03b826d
parentc71d2439359746380c9b81be3916ddc2afd8c083
Bug 23416: Add PreserveSerialNotes system preference

Bug 11492 intended to pass routinglists forward. It also passed forward serial notes.
This may or not me desired behvaiour, to avoid changing functionality twice I add a syspref
to control this behaviour.

To test:
 1 - Have or create a subscription in the serials module
 2 - Recieve an issue, making sure ot ad a note
 3 - Go to receive again, note the note from the last serial is set for the expected issue
 4 - Apply patch
 5 - Update database, restart all the things
 6 - Receive the issue leaving the note in place
 7 - Note the next expected issue has the note
 8 - Find the syspref PreserveSerialNotes
 9 - Confirm it defaulted to Do
10 - Set it to 'Do not'
11 - Receive the expected serial leavign the note
12 - Note the newly generated expected serial has no note
13 - prove -v t/db_dependent/Serials.t

Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a64c8cd1a4b2c237b3abf777480d7fc8733986d3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Serials.pm
installer/data/mysql/atomicupdate/Bug_23416_add_PreserveSerialNotes_pref.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref
t/db_dependent/Serials.t