]> git.koha-community.org Git - koha.git/commit
Bug 14048: (QA followup) Default to 1 if no default rule
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Jun 2016 13:17:20 +0000 (10:17 -0300)
committerJesse Weaver <jweaver@bywatersolutions.com>
Thu, 7 Jul 2016 16:37:01 +0000 (10:37 -0600)
commit0bb144bbaf578ef7e4a131d640b3866bfe05fdf5
tree97ff74a79e60c42144e13c0fcf5647ca517d925d
parent1887b7ab3ea50f9721eba070bc156c7f268d966a
Bug 14048: (QA followup) Default to 1 if no default rule

This patch answers Jonathan's request to simplify this patchset a bit.

It removes the need for the .sql file, as _default_rule now defaults to
a fixed value (1, which was set by the removed .sql file).
This allowed to remove the overloaded ->delete method.

The tests have been adjusted to reflect this changes, including tests for
the new 'default'-if-absent situation.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Koha/RefundLostItemFeeRule.pm
Koha/RefundLostItemFeeRules.pm
installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql [deleted file]
t/db_dependent/RefundLostItemFeeRule.t