]> git.koha-community.org Git - koha.git/commit
Bug 14893: Separate temporary storage per instance in Upload.pm
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 25 Sep 2015 06:50:17 +0000 (08:50 +0200)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Fri, 29 Jan 2016 01:17:55 +0000 (01:17 +0000)
commit0c138700b21341b2fd79e53722605cb3e87fb9d2
tree17f24f012f1423bd4c66d93aed6cf4dc107adf82
parent8d072272fa396820ec655fb7b45d30eee6fca3e8
Bug 14893: Separate temporary storage per instance in Upload.pm

To make life easier when multiple instances are uploading temporary
files to Koha, this patch adds the database name to the upload subfolder
in your /tmp folder.

Note: Although multiple instances could share the same subfolder for
temporary storage (hashvalue is based on a timestamp too), it will be
better to separate them for efficient housekeeping (removing older or
partial files with a cronjob etc.)
Since multiple instances come with separate permissions, keeping them in
separate folders will be much simpler.

Permanent storage is not affected by this patch. The location of permanent
storage is ruled by the upload_path in each config file. Sharing that
space is not recommended too.

Although it may not be strictly necessary yet to remove files from the old
temp storage folder (before the 3.22 release), the accompanying db rev
performs that housekeeping task.

Test plan:
[1] Do not yet apply this patch. Upload a temporary file (use the
    tools/upload.pl script without selecting a category).
[2] Check /tmp/koha_upload.
[3] Apply this patch. Run the db rev with web installer.
[4] Upload another temporary file.
[5] Check /tmp for folder [your_database]_upload.
[6] Check that /tmp/koha_upload is gone and the associated records too.
[7] Run the adjusted t/db../Upload.t

Followed test plan. Could not do steps before applying patch [1]-[2]
(I suppose a local permission problem).
After applying patch and updating db file appears in /tmp/[database]
as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Koha/Upload.pm
installer/data/mysql/atomicupdate/14893_cleanup.perl [new file with mode: 0644]
t/db_dependent/Upload.t