]> git.koha-community.org Git - koha.git/commit
Bug 28959: Add virtualshelves.public as a boolean
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 7 Sep 2021 15:19:03 +0000 (12:19 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 Oct 2021 15:47:38 +0000 (17:47 +0200)
commit0c720315394f76a809ef26f533c9d6414dfb0473
treee690a658631dbbc36a6c20951e421321f9ee3c51
parentd38be59a48bb4f3a2dce64947731f3288ba58a50
Bug 28959: Add virtualshelves.public as a boolean

This patchset moves the 'category' attribute for virtual shelves, that
takes values of 1 and 2 (private and public respectively) into a boolean
for public.

The DBRev is trivial, and the changes to the code are as well.

To test:
1. have some known public and private lists
2. Apply this patches
3. Run:
   $ updatedatabase
=> SUCCESS: Public lists have public=1, private have public=0
4. Run:
   $ kshell
  k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Try the feature in staff and OPAC
=> SUCCESS: All good
6. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Utils/DataTables/VirtualShelves.pm
Koha/Virtualshelf.pm
Koha/Virtualshelves.pm
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
opac/opac-shelves.pl
svc/virtualshelves/search
t/db_dependent/Utils/Datatables_Virtualshelves.t
t/db_dependent/Virtualshelves.t
virtualshelves/shelves.pl