]> git.koha-community.org Git - koha.git/commit
Bug 17088: [Follow-up] Use Logger for failed exports
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 16 Sep 2016 09:27:05 +0000 (11:27 +0200)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Mon, 10 Oct 2016 12:24:00 +0000 (12:24 +0000)
commit0eec191ed3ab1ae1bd24972a559d12627b70f681
treec639bf095dd0c1ef3a3c9c6c009b7d75a60c29d3
parent44b51ed80224d0361796c1a70cb66bb5096a427c
Bug 17088: [Follow-up] Use Logger for failed exports

Fixes a TODO for logging unsupported record_type in _get_record_for_export.
Also logs a warning when the record_type parameter is not supplied at all in sub export.
Replaces a warn by a log message about an invalid record for format iso2709.
Also adds a log message about an invalid record for format xml.
Adds a trivial unit test for passing no record_type to export.

Test plan:
See also first patch.
Run t/db_dependent/Exporter/Record.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Also tested the log messages for iso2709 and xml by manipulating
the record_type parameter with:
    $params->{record_type}='xx';
before calling _get_record_for_export in Record.pm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Koha/Exporter/Record.pm
t/db_dependent/Exporter/Record.t