]> git.koha-community.org Git - koha.git/commit
Bug 33341: Address some perlcritic errors in 5.36
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Mar 2023 12:17:31 +0000 (14:17 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 28 Mar 2023 12:50:33 +0000 (14:50 +0200)
commit10d12f999f9b8bff228c9c20f1ca4f0c7144201f
treedc84cbd1b172c9c47961e3d1b6ee22fe70722473
parentd8721bbc3687b13cd95abdcb73b3b7f9576e8190
Bug 33341: Address some perlcritic errors in 5.36

Some old-style code is making our tests fail when run in Debian Testing.

This patch addresses this.

To test:
1. Launch bookworm KTD:
   $ KOHA_IMAGE=master-bookworm ktd up -d
2. Run:
   $ ktd --shell
  k$ prove t/00-testcritic.t
=> FAIL: It fails!
3. Apply the patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
13 files changed:
C4/Installer.pm
C4/Koha.pm
C4/Languages.pm
C4/Ris.pm
Koha/AuthUtils.pm
admin/auth_subfields_structure.pl
admin/marc_subfields_structure.pl
installer/install.pl
misc/maintenance/generate_MARC21Languages.pl
misc/translator/tmpl_process3.pl
misc/translator/xgettext.pl
tools/access_files.pl
tools/picture-upload.pl