]> git.koha-community.org Git - koha.git/commit
Bug 14711: Change prototype for AddReserve - pass a hashref
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 16 Aug 2018 17:41:37 +0000 (14:41 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 11 Feb 2020 14:32:47 +0000 (14:32 +0000)
commit11b44869d95c47a7e6daec8dcb124762a9ee0026
tree27ddd685b8baf0c2dee503ff5894f3efe453c526
parent987cbc606a1b46c418e7e19eba2f23f63abefbf3
Bug 14711: Change prototype for AddReserve - pass a hashref

The number of parameters of AddReserve makes it hard to read and
maintain.
This patch replace it with a hashref, which will make the calls more
readable.

Moreover the bibitems has been removed as it was not used by the
subroutine.

Test plan:
- Make sure the tests pass
- Read the diff and search for typos
- Place a hold on few items

Note for QA: reservation_date and expiration_date do not match the DB column's names,
should we?

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
28 files changed:
C4/ILSDI/Services.pm
C4/Reserves.pm
C4/SIP/ILS/Transaction/Hold.pm
Koha/Club/Hold.pm
Koha/REST/V1/Holds.pm
opac/opac-reserve.pl
reserve/placerequest.pl
serials/routing-preview.pl
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Items/GetItemsForInventory.t
t/db_dependent/Koha/Acquisition/Order.t
t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Holds.t
t/db_dependent/Koha/Patrons.t
t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Reserves.t
t/db_dependent/Reserves/GetReserveFee.t
t/db_dependent/Reserves/MultiplePerRecord.t
t/db_dependent/SIP/Transaction.t
t/db_dependent/UsageStats.t
t/db_dependent/api/v1/holds.t