]> git.koha-community.org Git - koha.git/commit
Bug 15760: Avoid SQL injections
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 11 Feb 2016 10:16:12 +0000 (10:16 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Thu, 11 Feb 2016 19:42:31 +0000 (19:42 +0000)
commit16e55c1f3283402f766ed844baa5db333ed2f585
treeaa1fcee6e72e777b7c3fcb03c31294b4da01729e
parenta8942c28847e145f74e8373c3447313672cafe1d
Bug 15760: Avoid SQL injections

Asking on #dbix-class, ribasushi told me to set quote_names to the
connection options.

Indeed it does the fix, globally :)

Test plan:
1/ Add the following snippet to the a script (mainpage.pl is a good candidate)
 use Koha::Virtualshelves;
 my $s = Koha::Virtualshelves->search({}, { order_by => '1,(select case when (3*2*1=6 AND 000227=000227) then 1 else 1*(select table_name from information_schema.tables)end)=1' });
 $s->next;
2/ Execute the script
=> Without the patch, you should not get any error. If you have the mysql logs
enable, you will see the query
=> With the patch applied, you will get a "unknown column" error

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Koha/Database.pm