]> git.koha-community.org Git - koha.git/commit
bug_6253: Unified member Search()
authorSrdjan Jankovic <srdjan@catalyst.net.nz>
Thu, 22 Sep 2011 14:43:12 +0000 (09:43 -0500)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 19 Oct 2011 03:23:02 +0000 (16:23 +1300)
commit18b8991cf1832a0ee79a526e6438b51fdb4f3208
tree42e2c8a54ce32a88656f08a1c850f801e16dd410
parentfb3272febd08e2e570931f1a0eba4c3dbacc89b2
bug_6253: Unified member Search()

Removed SearchMembers() and replaced with more generic Search()
Amended Search() to try cardnumber first
Replaced SearchMembers() calls with Search()
Replaced SELECT with Search() where appropriate
C4::SQLHelper:
- added support for '' key for search filter.
- when passing an array to filter, join with OR (rather than AND)
- added support for key => [val1, val2] in filter
- did not document - there was no input documentation to start with,
  and SQLHelper should be replaced with something better anyway

Signed-off-by: Liz Rea <lrea@nekls.org>
(again - testing merge issue)
The functionality of the patch seems to be maintained with Biblibre's changes.

I tested the following:
Extended attribute searching: works
3 part name searching: works
2 part name searching: works
1 part name searching: works

From:
mainpage.pl
members-home.pl
Patron search limited by branch: Works
Patron search limited by patron category: works
Ordering by cardnumber instead of surname: works
The "Check Out" field in the masthead.

Circ Autocomplete is not reliably functional at this time, but the problem appears to predate this patch.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 files changed:
C4/Members.pm
C4/Members/Attributes.pm
C4/SQLHelper.pm
admin/aqbudget_owner_search.pl
circ/circulation.pl
circ/ysearch.pl
members/guarantor_search.pl
members/member.pl
patroncards/members-search.pl
reserve/request.pl
t/db_dependent/Koha.t
t/db_dependent/Members.t
t/db_dependent/lib/KohaTest/Members.pm