]> git.koha-community.org Git - koha.git/commit
Bug 20272: Replace error numbers by codes in XSLT_Handler
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 22 Feb 2018 13:52:29 +0000 (14:52 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 2 Jul 2018 12:12:48 +0000 (12:12 +0000)
commit295ae33800a322facfdf56795f4c02b2fd53432b
tree8fa322ac07ce2259793990df2c1aaad817e9899b
parentcdb6b68488fd33c20db7e35e4caa8a9b9bd8f4d4
Bug 20272: Replace error numbers by codes in XSLT_Handler

We remove the error numbers 1 to 7 by readable codes.
And remove the errstr attribute (not used widely).
Make XSLT_Handler a little bit less noisy by defaulting print_warns to
false unless $ENV{DEBUG} is set. (See also bug 19018).

The unit has been changed accordingly.
(A few warnings are no longer tested.)

Test plan:
Run t/db_dependent/XSLT_Handler.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/XSLT_Handler.pm
t/db_dependent/XSLT_Handler.t