]> git.koha-community.org Git - koha.git/commit
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts
authorOwen Leonard <oleonard@myacpl.org>
Sun, 3 May 2020 01:04:41 +0000 (01:04 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Oct 2020 12:50:07 +0000 (14:50 +0200)
commit31eb8196ed88850cf56ec84d3bb55354023438c1
treebbe707eb1f429097f917ac6400f111e05a5800aa
parent5cf01e6ca06eef4a3377505bae051170fae7a118
Bug 25354: Clean up JavaScript markup in cataloging plugin scripts

This patch makes some minor changes to the JavaScript generated by the
cataloging plugins: <script> "type" attribute removed; single-line
comments converted to multi-line style; obsolete //<![CDATA[ marks
removed.

These changes help the JavaScript conform to current coding guidelines.
The comment style change allows for whitespace in the scripts to be
collapsed by the Template::Toolkit "collapse" filter.

Since the patch makes small cosmetic changes to many files it may be
easiest to test this patch by visually inspecting the changes.

It's also simple to test some plugins which are enabled by default (at
least in MARC21): In the basic MARC editor, the leader, 007, and 008. In
the item editor, subfield d - Date acquired.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
37 files changed:
cataloguing/value_builder/EXAMPLE.pl
cataloguing/value_builder/barcode.pl
cataloguing/value_builder/barcode_manual.pl
cataloguing/value_builder/callnumber-KU.pl
cataloguing/value_builder/callnumber.pl
cataloguing/value_builder/cn_browser.pl
cataloguing/value_builder/dateaccessioned.pl
cataloguing/value_builder/macles.pl
cataloguing/value_builder/marc21_field_005.pl
cataloguing/value_builder/marc21_field_006.pl
cataloguing/value_builder/marc21_field_007.pl
cataloguing/value_builder/marc21_field_008.pl
cataloguing/value_builder/marc21_field_008_authorities.pl
cataloguing/value_builder/marc21_field_008_classifications.pl
cataloguing/value_builder/marc21_field_245h.pl
cataloguing/value_builder/marc21_leader.pl
cataloguing/value_builder/marc21_leader_authorities.pl
cataloguing/value_builder/marc21_linking_section.pl
cataloguing/value_builder/marc21_orgcode.pl
cataloguing/value_builder/normarc_field_007.pl
cataloguing/value_builder/normarc_field_008.pl
cataloguing/value_builder/normarc_leader.pl
cataloguing/value_builder/stocknumber.pl
cataloguing/value_builder/stocknumberam123.pl
cataloguing/value_builder/unimarc_field_010.pl
cataloguing/value_builder/unimarc_field_100.pl
cataloguing/value_builder/unimarc_field_100_authorities.pl
cataloguing/value_builder/unimarc_field_105.pl
cataloguing/value_builder/unimarc_field_110.pl
cataloguing/value_builder/unimarc_field_115a.pl
cataloguing/value_builder/unimarc_field_115b.pl
cataloguing/value_builder/unimarc_field_210c.pl
cataloguing/value_builder/unimarc_field_210c_bis.pl
cataloguing/value_builder/unimarc_field_225a.pl
cataloguing/value_builder/unimarc_field_225a_bis.pl
cataloguing/value_builder/unimarc_field_4XX.pl
cataloguing/value_builder/upload.pl