]> git.koha-community.org Git - koha.git/commit
Bug 10682: remove inappropriate uses of finish() from C4::Reserves
authorKenza Zaki <kenza.zaki@biblibre.com>
Mon, 5 Aug 2013 09:50:40 +0000 (11:50 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 9 Oct 2013 03:37:15 +0000 (03:37 +0000)
commit3b56392a6f99577c69c5636f52be7c51ddbbec73
tree9eeb692da61558d25c3307820ae1bb9c92a12288
parentb6577d13af2319f03b98ff19ac1d17773f55bff8
Bug 10682: remove inappropriate uses of finish() from C4::Reserves

This patch gets rid of finish.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Similar to other patches from the same author
I run prove t/db_dependent/Reserves.t without errors
don't know if more tests are needed.
No koha-qa errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Reserves.pm