]> git.koha-community.org Git - koha.git/commit
Bug 26296: (follow-up) Make sure title remains mandatory
authorOwen Leonard <oleonard@myacpl.org>
Mon, 8 Nov 2021 17:27:03 +0000 (17:27 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 10 Jan 2022 07:04:17 +0000 (21:04 -1000)
commit432f296b965485b56e9fdead1873c28fdcb87a65
treeeaae1794e73458d03b719043c99faad340ca5dc4
parentfe46f077a7b27ebb82891abf37144ba9f4fd59ea
Bug 26296: (follow-up) Make sure title remains mandatory

This patch adds a flag to the OPAC preferences file marking suggestion
title as mandatory OPACSuggestionMandatoryFields and excluded from
OPACSuggestionUnwantedFields.

The patch also modifies the markup around required fields in the OPAC
suggestion form to comply with changes made in Bug 27668 to mandatory
field styling.

To test, apply the patch and restart services.

- Test the OPACSuggestionMandatoryFields preference. In the modal,
  "title" should be checked and the label in red. It should not be
  possible to uncheck the checkbox.
  - Test that the "Select all" and "Clear all" links don't affect the
    "title" checkbox.
  - Confirm that your selections are still saved correctly.
- Test the OPACSuggestionUnwantedFields preference. In the modal,
  "title" should be unchecked and disabled.
  - Test that the "Select all" and "Clear all" links don't affect the
    "title" checkbox.
  - Confirm that your selections are saved correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/suggestions.json
koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt