]> git.koha-community.org Git - koha.git/commit
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 10 Jan 2017 09:03:36 +0000 (10:03 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 13 Apr 2017 12:34:15 +0000 (08:34 -0400)
commit476179a12311b32643087cc8ec10c31409bb1b99
tree5faeee3325e92e8fc7b415b41731b8a9c219013a
parent17f4b05d23cb19cebeedb361005bf411a5f25c60
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls

In aqbudgetperiods.pl a commented line is removed that contains a
wrong userenv hash key. Should be branch instead of branchcode.

In aqbudgets GetBudgetHierarchy is called with the same wrong userenv
hash key. Should be userenv->{branch}.
This made another bug visible: if you call GetBudgetHierarchy with a
branch and without owner, the where clause should take into account
that the branchcode can be empty (not null).

Test plan:
[1] Run Budgets.t
[2] Run aqbudgets.pl from Administration
[3] Add the show_mine=1 parameter in the URL
[4] Change owner of one of the funds and repeat step 2 and 3.

t/Budgets.t returns green. Followed test plan, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Budgets.pm
admin/aqbudgetperiods.pl
admin/aqbudgets.pl