]> git.koha-community.org Git - koha.git/commit
Bug 28782: Use query param list instead of splitting elements using '/'
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Thu, 29 Jul 2021 14:23:01 +0000 (17:23 +0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 4 Mar 2022 02:11:50 +0000 (16:11 -1000)
commit52b5a22edfbab0e211f5c5a3a8aa51b6fbd25202
tree87f32a3fc39cd915f269decb7264ffe8926f32e6
parentee957fc812daba845f8515e0254d082741e43eca
Bug 28782: Use query param list instead of splitting elements using '/'

This removes the need to handle single and multiple cases separately,
thus removing bunch if-else cases and simplifying our code. This
coding style is also in line with our other .pl scripts.

To test:
 1) Make sure placing a hold still works from the following pages:

   /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX

   /cgi-bin/koha/catalogue/search.pl?q=a

   /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX

   /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron
   there and through the clubs.pl create a hold to a bib)

Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
koha-tmpl/intranet-tmpl/prog/js/cart.js
koha-tmpl/intranet-tmpl/prog/js/pages/results.js
reserve/modrequest.pl
reserve/placerequest.pl
reserve/request.pl