]> git.koha-community.org Git - koha.git/commit
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm
authorroot <root@kenza-VirtualBox>
Thu, 25 Jul 2013 12:03:32 +0000 (14:03 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 9 Aug 2013 15:32:22 +0000 (15:32 +0000)
commit5cba6457aa00f3f3b2038f70057df300d9c6b9c3
treeeaa3331fcd74d105c8cc259c0246d4b1a01f07ef
parent8acce47efc0b6f9dd35115b76756c4cf42be1975
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm

This patch gets rid of finish() and replace prepare_cached by prepare.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/ClassSource.pm