]> git.koha-community.org Git - koha.git/commit
Bug 30262: Trim whitespace off tracklinks.pl URLs
authorDavid Cook <dcook@prosentient.com.au>
Thu, 10 Mar 2022 04:02:49 +0000 (04:02 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 31 Aug 2022 11:46:11 +0000 (08:46 -0300)
commit5fe49c7db1113026d242ad081c6b100fc8bae76e
tree0bf64705f047a59b20aaf231dd50e24cc3078643
parente574aea6bb1b19e6c1836fc522dca8857272d63e
Bug 30262: Trim whitespace off tracklinks.pl URLs

This patch trims whitespace off tracklinks.pl URLs so that
the URL is in the same format as the URLs returned by
C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally.

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29
2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0
3. Save record
4. Change 'TrackClicks' syspref to 'Track'
5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29
6. Click on the online resource (eg
http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29
)
7. Note you are redirected to https://koha-community.org

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Added the link with a space at the end. Verified that without the
patch, clickin on "Click here to access online" gives a 404. After
applying the patch the redirect works as expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
opac/tracklinks.pl