]> git.koha-community.org Git - koha.git/commit
Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Aug 2018 18:59:38 +0000 (15:59 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 31 Aug 2018 10:15:23 +0000 (10:15 +0000)
commit62a075987af70ec5ed3665fe662adb31a17fdde4
tree9ae4fbf4795a3d101c5986ab2fec0cc5d6e877d1
parent5d6efd4847cfb81ef9752f58e95ed761b50d13b4
Bug 21184: Replace C4::Items::GetBarcodeFromItemnumber calls

Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with
    my $barcode = Koha::Items->find($itemnumber)->barcode;
But if we are not sure that the item exists, we should test the return
of ->find before ->barcode

Test plan:
- Edit an item
- Check an item in

- Test SIP - I do not really know how to trigger that code, apparently
misc/sip_cli_emulator.pl does not deal with holds. Any ideas?

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/SIP/ILS/Patron.pm
cataloguing/additem.pl
svc/checkin