]> git.koha-community.org Git - koha.git/commit
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN...
authorTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 29 Oct 2014 19:24:49 +0000 (16:24 -0300)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 31 Oct 2014 17:13:31 +0000 (14:13 -0300)
commit65e0fba94b8e0f16de20214f6f2c89c2327fb3d0
treeb718fd3657dd9b0325b87593e14e9f172efc1c44
parent7b7a45269a6d949df84b6760857b83da8bda065c
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT
logic used introduces punctuation characters for those $z occurences.

This patch adds a check for the existence of subfield a, and only loops
on $a subfields.

To test:
- Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a on UNIMARC).
- Open the detail page for the record (on both OPAC and staff).
=> FAIL: the ISSN label and ';' and '.' characters incorrectly shown.
- Repeat mixing with 022$a occurences to notice the bug.
- Apply the patch, reload
=> SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped.
           no matter how many ISSN fields you add.
- Sign off :-D

Regards
To+

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Works as described on an UNIMARC DB. Mimics what's done for ISBN field.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl